Thanks - all applied! On Thu, Jun 22, 2017 at 8:00 PM, Matthew Kleiman <mklei...@pivotal.io> wrote:
> Hello Dave, > > We noticed that the makefile is not installing node_modules dependencies, > so we created a new patch that changes the makefile to install > node_modules first and then execute the tasks. > > Thanks > Matt && João > > On Tue, Jun 20, 2017 at 5:23 AM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi, >> >> This fails tests: >> >> (pgadmin4)piranha:pgadmin4 dpage$ make check-feature >> cd web && yarn run bundle && python regression/runtests.py --pkg >> feature_tests >> yarn run v0.24.6 >> $ yarn run linter && yarn run webpacker >> yarn run v0.24.6 >> $ yarn run eslint pgadmin/static/jsx/**/*.jsx >> pgadmin/static/js/selection/*.js regression/javascript/**/*.jsx >> regression/javascript/**/*.js *.js >> yarn run v0.24.6 >> $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/eslint" >> pgadmin/static/jsx/history/query_history.jsx >> pgadmin/static/jsx/history/query_history_entry.jsx >> pgadmin/static/js/selection/active_cell_capture.js >> pgadmin/static/js/selection/clipboard.js >> pgadmin/static/js/selection/column_selector.js >> pgadmin/static/js/selection/copy_data.js >> pgadmin/static/js/selection/grid_selector.js >> pgadmin/static/js/selection/range_boundary_navigator.js >> pgadmin/static/js/selection/range_selection_helper.js >> pgadmin/static/js/selection/row_selector.js >> pgadmin/static/js/selection/set_staged_rows.js >> pgadmin/static/js/selection/xcell_selection_model.js >> regression/javascript/history/query_history_entry_spec.jsx >> regression/javascript/history/query_history_spec.jsx >> regression/javascript/browser/menu_spec.js >> regression/javascript/history/history_collection_spec.js >> regression/javascript/selection/active_cell_capture_spec.js >> regression/javascript/selection/column_selector_spec.js >> regression/javascript/selection/copy_data_spec.js >> regression/javascript/selection/grid_selector_spec.js >> regression/javascript/selection/range_boundary_navigator_spec.js >> regression/javascript/selection/range_selection_helper_spec.js >> regression/javascript/selection/row_selector_spec.js >> regression/javascript/selection/set_staged_rows_spec.js >> regression/javascript/selection/xcell_selection_model_spec.js >> regression/javascript/slickgrid/cell_selector_spec.js karma.conf.js >> webpack.config.js webpack.test.config.js >> ✨ Done in 1.17s. >> ✨ Done in 1.40s. >> yarn run v0.24.6 >> $ yarn run webpack -- --config webpack.config.js >> yarn run v0.24.6 >> $ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/webpack" --config >> webpack.config.js >> (node:33997) DeprecationWarning: loaderUtils.parseQuery() received a >> non-string value which can be problematic, see >> https://github.com/webpack/loader-utils/issues/56 >> parseQuery() will be replaced with getOptions() in the next major >> version of loader-utils. >> Hash: fe4471bbef0e7c5081ef >> Version: webpack 2.3.3 >> Time: 1552ms >> Asset Size Chunks Chunk Names >> reactComponents.js 1.21 MB 0 [emitted] [big] reactComponents >> history.js 5.37 kB 1 [emitted] history >> slickgrid.js 4.78 kB 2 [emitted] slickgrid >> [5] /Users/dpage/git/pgadmin4/web/~/object-assign/index.js 2.11 kB >> {0} [built] >> [20] /Users/dpage/git/pgadmin4/web/~/react/lib/React.js 2.69 kB {0} >> [built] >> [32] /Users/dpage/git/pgadmin4/web/~/react/react.js 56 bytes {0} >> [built] >> [196] ./js/history/history_collection.js 1.91 kB {1} [built] >> [197] ./jsx/history/query_history.jsx 3.65 kB {0} [built] >> [198] /Users/dpage/git/pgadmin4/web/~/react-dom/index.js 59 bytes {0} >> [built] >> [199] ./bundle/components.js 604 bytes {0} [built] >> [200] ./bundle/slickgrid.js 620 bytes {2} [built] >> [201] ./js/history/index.js 690 bytes {1} [built] >> [202] ./jsx/history/query_history_entry.jsx 5.21 kB {0} [built] >> [233] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/ReactDOM.js 5.14 >> kB {0} [built] >> [282] /Users/dpage/git/pgadmin4/web/~/react-dom/lib/findDOMNode.js >> 2.46 kB {0} [built] >> [296] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPropTypes.js >> 15.8 kB {0} [built] >> [297] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactPureComponent.js >> 1.32 kB {0} [built] >> [298] /Users/dpage/git/pgadmin4/web/~/react/lib/ReactVersion.js 350 >> bytes {0} [built] >> + 288 hidden modules >> >> ERROR in ./bundle/slickgrid.js >> Module not found: Error: Can't resolve 'slickgrid/slick.grid.css' in >> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle' >> @ ./bundle/slickgrid.js 7:0-35 >> >> ERROR in ./bundle/slickgrid.js >> Module not found: Error: Can't resolve >> 'slickgrid/slick-default-theme.css' in >> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle' >> @ ./bundle/slickgrid.js 9:0-44 >> >> ERROR in ./bundle/slickgrid.js >> Module not found: Error: Can't resolve 'slickgrid/slick.core' in >> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle' >> @ ./bundle/slickgrid.js 13:0-31 >> >> ERROR in ./bundle/slickgrid.js >> Module not found: Error: Can't resolve 'slickgrid/slick.grid' in >> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle' >> @ ./bundle/slickgrid.js 15:0-31 >> >> ERROR in ./bundle/slickgrid.js >> Module not found: Error: Can't resolve 'slickgrid/slick.editors' in >> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle' >> @ ./bundle/slickgrid.js 17:0-34 >> >> ERROR in ./bundle/slickgrid.js >> Module not found: Error: Can't resolve 'slickgrid/slick.formatters' in >> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle' >> @ ./bundle/slickgrid.js 19:0-37 >> >> ERROR in ./bundle/slickgrid.js >> Module not found: Error: Can't resolve >> 'slickgrid/plugins/slick.autotooltips' in >> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle' >> @ ./bundle/slickgrid.js 21:0-47 >> >> ERROR in ./bundle/slickgrid.js >> Module not found: Error: Can't resolve >> 'slickgrid/plugins/slick.cellrangedecorator' in >> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle' >> @ ./bundle/slickgrid.js 23:0-53 >> >> ERROR in ./bundle/slickgrid.js >> Module not found: Error: Can't resolve >> 'slickgrid/plugins/slick.cellrangeselector' in >> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle' >> @ ./bundle/slickgrid.js 25:0-52 >> >> ERROR in ./bundle/slickgrid.js >> Module not found: Error: Can't resolve >> 'slickgrid/lib/jquery.event.drag-2.3.0' in >> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle' >> @ ./bundle/slickgrid.js 27:0-48 >> >> ERROR in ./bundle/slickgrid.js >> Module not found: Error: Can't resolve >> 'slickgrid/css/smoothness/jquery-ui-1.11.3.custom.css' in >> '/Users/dpage/git/pgadmin4/web/pgadmin/static/bundle' >> @ ./bundle/slickgrid.js 11:0-63 >> error Command failed with exit code 2. >> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about >> this command. >> error Command failed with exit code 1. >> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about >> this command. >> error Command failed with exit code 1. >> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about >> this command. >> make: *** [check-feature] Error 1 >> >> >> On Mon, Jun 19, 2017 at 8:28 PM, Joao Pedro De Almeida Pereira >> <jdealmeidapere...@pivotal.io> wrote: >> > Hi Hackers, >> > >> > This patch will upgrade Slickgrid Version to 2.3.7 to include a PR we >> > created for it. This PR made SlickGrid Cell Decorator and Cell Selection >> > more configurable. >> > >> > With SlickGrid more configurable we can, by changing options, change the >> > border position when the user is drag selecting inside the query >> results. >> > >> > >> > Thanks >> > Joao >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
