Re: [pgadmin-hackers][patch]

Thanks, applied. On Fri, Jul 21, 2017 at 10:38 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi hackers, > With the last commits, the behavior of focusing on a selected entry when > entering the History Tab was not working as expected. > This patch will bring this behavior

Re: [pgadmin-hackers][patch] Update the error alerts style in dialog

Thanks, applied. On Fri, Jul 7, 2017 at 9:53 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > We updated the style of the error alerts in the dialogs window to match > the style guide. Below is a screenshot of how it looks: > > [image: Inline image 1] > > > Tha

Re: [pgadmin-hackers][patch] delete icon width in security labels form

Hi On Thu, Jul 6, 2017 at 4:13 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Hackers, > > We found a discrepancy with the width of inserted columns in some backform > tables. It is at least present in Create Table -> Security [tab] -> > clicking [+] for new rows under

Re: [pgadmin-hackers][Patch] Change alert styling

OK, thanks - patch applied. Note to all hackers: As we modify our override CSS moving forwards, it should be migrated to SCSS, and use the defined colour variable names. Thanks. On Thu, Jun 29, 2017 at 2:25 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi! > > Are you c

Re: [pgadmin-hackers][Patch] Change alert styling

Hi! Are you committing to migrating all the main CSS to SCSS? Whilst I can see > the advantages of SCSS, I don't want to end up with a mix and match mess of > the two (though, I'd be fine with keeping the smaller, module-specific CSS > if it doesn't make sense to migrate it). It makes more sense

Re: [pgadmin-hackers][Patch] Change alert styling

Hi On Wed, Jun 28, 2017 at 4:40 PM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Hackers, > > In this patch we are introducing SCSS that we generated for the style > guide. > [image: Inline image 1] > > The patch is split into 2 files: > - 01-add-scss-building-to-webp

Re: [pgadmin-hackers][patch] History Detail Pane

On Tue, Jun 27, 2017 at 8:26 PM, Dave Page wrote: > Thanks - patch applied (just in time for Raffi's & my talk)! > > The history tab looks really very good. > On Tue, Jun 27, 2017 at 10:05 AM, Joao Pedro De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Yep, >> please see attached

Re: [pgadmin-hackers][patch] History Detail Pane

Harshal, Thanks for taking a look. That exact feature should be in our next patch along with a few style changes. -- Rob On Tue, Jun 27, 2017 at 2:03 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > New history pane is really nice and informative than existing one. > I'm j

Re: [pgadmin-hackers][patch] History Detail Pane

Hi, New history pane is really nice and informative than existing one. I'm just thinking about one minor improvement we can make, to allow history tab to respond to up and down arrow keys so that user can easily switch between executed queries without using mouse. Thanks, -- *Harshal Dhumal* *

Re: [pgadmin-hackers][patch] History Detail Pane

Thanks - patch applied (just in time for Raffi's & my talk)! On Tue, Jun 27, 2017 at 10:05 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Yep, > please see attached > > On Tue, Jun 27, 2017 at 9:11 AM, Dave Page wrote: > >> Can you rebase this patch please? >> >> Than

Re: [pgadmin-hackers][patch] History Detail Pane

Can you rebase this patch please? Thankfully I think we're basically at the end of our changes in this area! On Mon, Jun 26, 2017 at 10:08 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Surinder, > > You can find our answers inline and attached the patch with the c

Re: [pgadmin-hackers][patch] History Detail Pane

On Mon, Jun 26, 2017 at 10:08 AM, Joao Pedro De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi Surinder, > > You can find our answers inline and attached the patch with the change of > scrolls from "scroll" to "auto" > > On Mon, Jun 26, 2017 at 4:47 AM, Surinder Kumar > wrote: >> >> H

Re: [pgadmin-hackers][patch] History Detail Pane

Hi On Fri, Jun 23, 2017 at 11:39 PM, George Gelashvili wrote: > On Fri, Jun 23, 2017 at 11:24 AM, Surinder Kumar sedb.com> wrote: > >> Hi >> >> Review comments: >> >> ​1. ​ >> Can we set "message"(in message detail) style property scroll to >> ​'​ >> auto >> ​'​ >> instead of >> ​'​ >> scroll >

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

On Fri, Jun 23, 2017 at 4:21 PM, Dave Page wrote: > > > On Fri, Jun 23, 2017 at 11:47 AM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Sorry, I forgot to attach screenshot. >> I looked into Query tool HTML using inspect tool. >> >> > That's code that's part of SlickGrid isn't i

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

On Fri, Jun 23, 2017 at 11:47 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Sorry, I forgot to attach screenshot. > I looked into Query tool HTML using inspect tool. > > That's code that's part of SlickGrid isn't it? If there are improvements to be made there, patches should be se

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

Hi On Fri, Jun 23, 2017 at 11:33 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > On latest git pull, couple of issues: > > 1. The edit grid font(text-12) is overriden by 'ui-widget' font - Verdana. > 2. The dotted border around cell appears again. > > The class 'ui-widget' i

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

Hi On latest git pull, couple of issues: 1. The edit grid font(text-12) is overriden by 'ui-widget' font - Verdana. 2. The dotted border around cell appears again. The class 'ui-widget' is added dynamically which i don't know why it is added. Also, Cascaded style is used(i.e. CSS is embedded in

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

Thanks - all applied! On Thu, Jun 22, 2017 at 8:00 PM, Matthew Kleiman wrote: > Hello Dave, > > We noticed that the makefile is not installing node_modules dependencies, > so we created a new patch that changes the makefile to install > node_modules first and then execute the tasks. > > Thanks >

Re: [pgadmin-hackers][patch] History Detail Pane

On Fri, Jun 23, 2017 at 11:24 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Review comments: > > ​1. ​ > Can we set "message"(in message detail) style property scroll to > ​'​ > auto > ​'​ > instead of > ​'​ > scroll > ​'​ > ? > > ​2. ​ > CSS property flex is supported for

Re: [pgadmin-hackers][patch] History Detail Pane

Hi Review comments: ​1. ​ Can we set "message"(in message detail) style property scroll to ​'​ auto ​'​ instead of ​'​ scroll ​'​ ? ​2. ​ CSS property flex is supported for IE >= 9 as per reference

Re: [pgadmin-hackers][patch] History Detail Pane

Hi Looking good. The only issue I found so far occurs if you open the query tool, then immediately click on the history tab: TypeError: Cannot read property 'CodeMirror' of undefined at Object. (sqleditor.js:882) at triggerEvents (backbone.js:208) at Object.trigger (backbone.js:148)

Re: [pgadmin-hackers][patch] Upgrade slickgrid to version 2.3.7

Hi, This fails tests: (pgadmin4)piranha:pgadmin4 dpage$ make check-feature cd web && yarn run bundle && python regression/runtests.py --pkg feature_tests yarn run v0.24.6 $ yarn run linter && yarn run webpacker yarn run v0.24.6 $ yarn run eslint pgadmin/static/jsx/**/*.jsx pgadmin/static/js/selec