Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Thanks, patch applied. On Tue, Nov 5, 2019 at 12:46 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Tue, Nov 5, 2019 at 11:01 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> I have tested it. R

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Hi Aditya I have tested it. Reset functionality not working when preference setting is set to False. Please fix and resend the patch. On Mon, Nov 4, 2019 at 5:15 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > As discussed, extending the changes to Reset button

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

On Wed, Oct 30, 2019 at 3:44 PM Dave Page wrote: > Hi > > On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Tue, Oct 29, 2019 at 9:01 PM Dave Page wrote: >> >>> Hi >>> >>> I just found an, umm, embarrassing issue with this. It asks f

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Hi On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Oct 29, 2019 at 9:01 PM Dave Page wrote: > >> Hi >> >> I just found an, umm, embarrassing issue with this. It asks for the >> cancel confirmation even when pressing the OK button :-o

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Hi, On Tue, Oct 29, 2019 at 9:01 PM Dave Page wrote: > Hi > > I just found an, umm, embarrassing issue with this. It asks for the cancel > confirmation even when pressing the OK button :-o > Tested all but missed the obvious. Bad miss :/ Attached is the patch to fix the issue. > > Can you fix t

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Hi I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o Can you fix that ASAP please? On Tue, Oct 29, 2019 at 2:35 PM Dave Page wrote: > Thanks, applied. > > On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < > aditya.tosh

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Thanks, applied. On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to warn the user before closing an unsaved > properties dialog. > Additionally, I have added a preference option in Browser->Display where > the us