Hi Aditya I have tested it. Reset functionality not working when preference setting is set to False. Please fix and resend the patch.
On Mon, Nov 4, 2019 at 5:15 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > As discussed, extending the changes to Reset button also. Warning will > appear for Reset button now if opted in preferences and changes are not > saved. > Note that, the preference option is same for Close and Reset button. > > Kindly review. > > On Wed, Oct 30, 2019 at 6:24 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> >> On Wed, Oct 30, 2019 at 3:44 PM Dave Page <dp...@pgadmin.org> wrote: >> >>> Hi >>> >>> On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal < >>> aditya.toshni...@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> On Tue, Oct 29, 2019 at 9:01 PM Dave Page <dp...@pgadmin.org> wrote: >>>> >>>>> Hi >>>>> >>>>> I just found an, umm, embarrassing issue with this. It asks for the >>>>> cancel confirmation even when pressing the OK button :-o >>>>> >>>> Tested all but missed the obvious. Bad miss :/ >>>> Attached is the patch to fix the issue. >>>> >>> >>> Thanks - applied. Should we also warn on Reset? That seems logical to me. >>> >> Can be added. Preference option should be common for both Cancel and >> Reset. Will send an add-on patch for this. >> >>> >>> >>>> >>>>> Can you fix that ASAP please? >>>>> >>>>> On Tue, Oct 29, 2019 at 2:35 PM Dave Page <dp...@pgadmin.org> wrote: >>>>> >>>>>> Thanks, applied. >>>>>> >>>>>> On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < >>>>>> aditya.toshni...@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> Attached is the patch to warn the user before closing an unsaved >>>>>>> properties dialog. >>>>>>> Additionally, I have added a preference option in Browser->Display >>>>>>> where the user can disable this. Default is enabled. >>>>>>> Docs updated. >>>>>>> >>>>>>> Kindly review. >>>>>>> >>>>>>> -- >>>>>>> Thanks and Regards, >>>>>>> Aditya Toshniwal >>>>>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
