Re: Fixes for pgAdmin4 messages

Thanks, applied with some wording tweaks. On Mon, Nov 6, 2017 at 9:13 AM, Alexander Lakhin wrote: > Hello, > > 05.11.2017 16:36, Dave Page wrote: > > That looks like it - thanks, applied! > > Thank you! > > And another one. > (I've processed onText/offText instances, alertify.* calls and depend

Re: Fixes for pgAdmin4 messages

Hi I think you forgot to attach the patch. Thanks, Dave On Mon, Nov 6, 2017 at 9:00 AM, Alexander Lakhin wrote: > Hello, > > 05.11.2017 16:36, Dave Page wrote: > > That looks like it - thanks, applied! > > Thank you! > > And another one. > (I've processed onText/offText instances, alertify.*

Re: Fixes for pgAdmin4 messages

Hello, 05.11.2017 16:36, Dave Page wrote: That looks like it - thanks, applied! Thank you! And another one. (I've processed onText/offText instances, alertify.*  calls and depends.js) Please look at it. -- Alexander Lakhin Postgres Professional: http://www.postgrespro.com The Russian Post

Re: Fixes for pgAdmin4 messages

Hello, 05.11.2017 16:36, Dave Page wrote: That looks like it - thanks, applied! Thank you! And another one. (I've processed onText/offText instances, alertify.*  calls and depends.js) Please look at it. -- Alexander Lakhin Postgres Professional: http://www.postgrespro.com The Russian Post

Re: Fixes for pgAdmin4 messages

That looks like it - thanks, applied! On Sat, Nov 4, 2017 at 2:25 AM, Alexander Lakhin wrote: > Hello, > > 04.11.2017 07:05, Ashesh Vashi wrote: > > Looks like - the patch has introduced syntax error in database.js. > > On Nov 3, 2017 22:19, "Dave Page" wrote: > >> Hi >> >> Unfortunately I've h

Re: Fixes for pgAdmin4 messages

Hello, 04.11.2017 07:05, Ashesh Vashi wrote: Looks like - the patch has introduced syntax error in database.js. On Nov 3, 2017 22:19, "Dave Page" > wrote: Hi Unfortunately I've had to revert this. It was causing the treeview to render incorrectly (see th

Re: Fixes for pgAdmin4 messages

Looks like - the patch has introduced syntax error in database.js. On Nov 3, 2017 22:19, "Dave Page" wrote: > Hi > > Unfortunately I've had to revert this. It was causing the treeview to > render incorrectly (see the attached screenshot). > > Can you take a look please? I've CC'd Ashesh as he kn

Re: Fixes for pgAdmin4 messages

Hi Unfortunately I've had to revert this. It was causing the treeview to render incorrectly (see the attached screenshot). Can you take a look please? I've CC'd Ashesh as he knows that area of the code far better than I do and may be able to spot the issue much more quickly (plus I'm travelling f

Re: Fixes for pgAdmin4 messages

Thanks, patch applied. On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin wrote: > Hello, > I have another patch for the better localization of pgAdmin4. > Please consider applying it. > > Best regards, > -- > Alexander Lakhin > Postgres Professional: http://www.postgrespro.com > The Russian

Re: Fixes for pgAdmin4 messages

Hello, I have another patch for the better localization of pgAdmin4. Please consider applying it. Best regards, -- Alexander Lakhin Postgres Professional: http://www.postgrespro.com The Russian Postgres Company diff --git a/web/pgadmin/browser/server_groups/servers/databases/foreign_data_wrap

Re: Fixes for pgAdmin4 messages

Hi On Wed, Nov 1, 2017 at 2:13 PM, Alexander Lakhin wrote: > Hello Dave, > 01.11.2017 16:05, Dave Page wrote: > > Hi > > On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin > wrote: > >> >> > I did - albeit with a couple of additional tweaks. > > Thanks! > > No, I don't think there are reasons to

Re: Fixes for pgAdmin4 messages

Hello Dave, 01.11.2017 16:05, Dave Page wrote: Hi On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin > wrote: I did - albeit with a couple of additional tweaks. Thanks! No, I don't think there are reasons to have exclamation marks. pgAdmin shouldn't ever be surpri

Re: Fixes for pgAdmin4 messages

Hi On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin wrote: > 01.11.2017 12:04, Dave Page wrote: > > Hi, > > Can you re-sent this as a single patch please? Working through 23 will > take me significantly more time (which I have little of). > > Sure, If you are going to accept all (or almost all)

Re: Fixes for pgAdmin4 messages

01.11.2017 12:04, Dave Page wrote: Hi, Can you re-sent this as a single patch please? Working through 23 will take me significantly more time (which I have little of). Sure, If you are going to accept all (or almost all) the changes, a single patch is better. On Wed, Nov 1, 2017 at 7:33 AM,

Re: Fixes for pgAdmin4 messages

Hi, Can you re-sent this as a single patch please? Working through 23 will take me significantly more time (which I have little of). On Wed, Nov 1, 2017 at 7:33 AM, Alexander Lakhin wrote: > Hello, > > While translating the messages, I encountered some English messages, that > I think should be

Fixes for pgAdmin4 messages

Hello, While translating the messages, I encountered some English messages, that I think should be fixed. Please consider applying the attached patches. If you have any concerns or questions, I'm ready to explain all the fixes proposed. And I have a question - do you use some kind of style g