Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Thanks patch applied. On Wed, Jan 23, 2019 at 11:32 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > PFA revised patch as per review. > > On Wed, Jan 23, 2019 at 11:20 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> Found one issue y

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Hi Hackers, PFA revised patch as per review. On Wed, Jan 23, 2019 at 11:20 AM Akshay Joshi wrote: > Hi Aditya > > Found one issue you have remove the function "*disable_tree_state_save*" from > "*web/regression/python_test_utils/test_utils.py*" and move that code > into "*set_preference*" funct

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Hi Aditya Found one issue you have remove the function "*disable_tree_state_save*" from "*web/regression/python_test_utils/test_utils.py*" and move that code into " *set_preference*" function and it is called from " *web/regression/runtests.py*" which is conditional, so please correct that behavio

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Hi Hackers, Attached is the revised patch. The warning occurrence is configurable from Preferences > Browser > Display. Kindly review. On Tue, Jan 22, 2019 at 5:38 PM Dave Page wrote: > On Tue, Jan 22, 2019 at 12:01 PM Aditya Toshniwal > wrote: > > > > > > > > On Tue, Jan 22, 2019 at 5:27 PM

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

On Tue, Jan 22, 2019 at 12:01 PM Aditya Toshniwal wrote: > > > > On Tue, Jan 22, 2019 at 5:27 PM Dave Page wrote: >> >> On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal >> wrote: >> > >> > Any suggestions on preferences name/desc ? >> >> Name: "Confirm on close" >> Desc: "Confirm closure of the

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

On Tue, Jan 22, 2019 at 5:27 PM Dave Page wrote: > On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal > wrote: > > > > Any suggestions on preferences name/desc ? > > Name: "Confirm on close" > Desc: "Confirm closure of the browser or browser tab is intended > before proceeding." > It also warns o

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal wrote: > > Any suggestions on preferences name/desc ? Name: "Confirm on close" Desc: "Confirm closure of the browser or browser tab is intended before proceeding." > On Tue, Jan 22, 2019 at 3:01 PM Dave Page wrote: >> >> Hi >> >> On Tue, Jan 22

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Any suggestions on preferences name/desc ? On Tue, Jan 22, 2019 at 3:01 PM Dave Page wrote: > Hi > > On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi > wrote: > > > > Hi Aditya > > > > Below are my review comments: > > > > You have added new config parameter "DISABLE_BEFOREUNLOAD_MESSAGE" to > make

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Hi On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi wrote: > > Hi Aditya > > Below are my review comments: > > You have added new config parameter "DISABLE_BEFOREUNLOAD_MESSAGE" to make > this request configurable, should it be the part of preferences setting > instead of configuration? @Dave can y

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Hi Aditya Below are my review comments: - You have added new config parameter "*DISABLE_BEFOREUNLOAD_MESSAGE*" to make this request configurable, should it be the part of preferences setting instead of configuration? @Dave can you please comment on this. - Name "*DISABLE_BEFOREUNLOAD_

[pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Hi Hackers, Attached is the patch to throw alert warning when user reloads or closes the browser. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" RM3849.patch Description: Binary data