Hi Aditya Below are my review comments:
- You have added new config parameter "*DISABLE_BEFOREUNLOAD_MESSAGE*" to make this request configurable, should it be the part of preferences setting instead of configuration? @Dave can you please comment on this. - Name "*DISABLE_BEFOREUNLOAD_MESSAGE"* is not clear as users perspective, can you please change it to some meaningful name. Apart from that code looks good to me. On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to throw alert warning when user reloads or closes > the browser. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
