Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Thanks all, applied. On Wed, May 30, 2018 at 5:06 PM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hello Akshay, > > Thanks for taking a look. We did the following changes over your patch: > >- Changed the XPATH to CSS_SELECTOR, please look in >pgadmin/feature_tests/qu

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Thanks, applied. On Wed, May 30, 2018 at 1:52 AM, Akshay Joshi wrote: > Hi Joao > > On Tue, May 29, 2018 at 9:10 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Akshay, >> >> The code looks good, we do have some minor notes for next time: >> >> . To make the code

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hello Akshay, Thanks for taking a look. We did the following changes over your patch: - Changed the XPATH to CSS_SELECTOR, please look in pgadmin/feature_tests/query_tool_tests.py:660 and 667 - Changed the other places in _query_tool_notify_statements to do not use xpath. - Moved t

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Joao On Tue, May 29, 2018 at 9:10 PM, Joao De Almeida Pereira wrote: > Hello Akshay, > > The code looks good, we do have some minor notes for next time: > > . To make the code easier to understand we should decide on 1 term and not > have notifies and notifications to reference the same thing

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hello Akshay, The code looks good, we do have some minor notes for next time: . To make the code easier to understand we should decide on 1 term and not have notifies and notifications to reference the same thing. . It would be nice if we tried not to use XPATH to get the HTML components that we

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Hakers, On my last patch feature tests were failed for GreenPlum5 database only not for PostgreSQL. I have verified that on https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/93 . Can someone from Pivotal team help me, as I don't have GreenPlum dat

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Hackers, As per suggestion by Dave and discussion with in the team, I have modified the logic again. Following are the modifications: - Instead of waiting for another query to execute on the session where 'LISTEN' command has been executed, we fetched the notify messages in the connec

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

On Tue, May 22, 2018 at 10:01 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > On Tue, May 22, 2018 at 2:02 PM, Dave Page wrote: > >> >> >> On Tue, May 22, 2018 at 9:13 AM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, May 22, 2018 at 7:07 AM, Akshay Joshi < >>> akshay.jo...@e

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Dave On Tue, May 22, 2018 at 2:02 PM, Dave Page wrote: > > > On Tue, May 22, 2018 at 9:13 AM, Dave Page wrote: > >> Hi >> >> On Tue, May 22, 2018 at 7:07 AM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> As per suggestion by Dave, I have modified the logi

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

On Tue, May 22, 2018 at 9:13 AM, Dave Page wrote: > Hi > > On Tue, May 22, 2018 at 7:07 AM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> As per suggestion by Dave, I have modified the logic and now >> notifications are popped up in alertify dialog(refer Notify_Mes

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi On Tue, May 22, 2018 at 7:07 AM, Akshay Joshi wrote: > Hi Hackers, > > As per suggestion by Dave, I have modified the logic and now notifications > are popped up in alertify dialog(refer Notify_Messages.png) as and when > received on that session where "LISTEN" is executed. Attached is the >

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi All Please ignore the previous patch. Attached is the latest one. On Tue, May 22, 2018 at 11:37 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Hackers, > > As per suggestion by Dave, I have modified the logic and now notifications > are popped up in alertify dialog(refer Notify

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Hackers, As per suggestion by Dave, I have modified the logic and now notifications are popped up in alertify dialog(refer Notify_Messages.png) as and when received on that session where "LISTEN" is executed. Attached is the modified patch, please review it. To test this feature following step

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Dave On Fri, May 18, 2018 at 4:56 PM, Dave Page wrote: > > > On Fri, May 18, 2018 at 12:11 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Fri, May 18, 2018 at 3:58 PM, Dave Page wrote: >> >>> Hi >>> >>> On Wed, May 16, 2018 at 2:51 PM, Anthony Emengo >>> wr

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

On Fri, May 18, 2018 at 12:11 PM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > On Fri, May 18, 2018 at 3:58 PM, Dave Page wrote: > >> Hi >> >> On Wed, May 16, 2018 at 2:51 PM, Anthony Emengo >> wrote: >> >>> Hey, >>> >>> The code looks great! The tests all passed as well. >

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Dave On Fri, May 18, 2018 at 3:58 PM, Dave Page wrote: > Hi > > On Wed, May 16, 2018 at 2:51 PM, Anthony Emengo > wrote: > >> Hey, >> >> The code looks great! The tests all passed as well. >> > > Agreed - however, unless you check the Messages panel, you're not likely > to see that a message

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi On Wed, May 16, 2018 at 2:51 PM, Anthony Emengo wrote: > Hey, > > The code looks great! The tests all passed as well. > Agreed - however, unless you check the Messages panel, you're not likely to see that a message was received. Can we also show each message in an alertify panel? -- Dave

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hey, The code looks great! The tests all passed as well. Sincerely Anthony and Victoria

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Hackers, On Tue, May 15, 2018 at 9:52 PM, Akshay Joshi wrote: > Hi Joao > > On Tue, 15 May 2018, 19:36 Joao De Almeida Pereira, < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Akshay, >> >> This patch is flaky; it doesn't always pass the tests in our pipeline. >> >> =

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Joao On Tue, 15 May 2018, 19:36 Joao De Almeida Pereira, < jdealmeidapere...@pivotal.io> wrote: > Hi Akshay, > > This patch is flaky; it doesn't always pass the tests in our pipeline. > > == > >

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Akshay, This patch is flaky; it doesn't always pass the tests in our pipeline. == ERROR: runTest (pgadmin.fe

[pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Hackers, Attached is the patch to capture the notification from psycopg2 and displayed it in "Messages" tab of query tool. Added feature test to cover this scenario. Refer Notification.png file to how it looks in "Messages" tab. Please review it. -- *Akshay Joshi* *Sr. Software Architect *