Hi Joao On Tue, 15 May 2018, 19:36 Joao De Almeida Pereira, < jdealmeidapere...@pivotal.io> wrote:
> Hi Akshay, > > This patch is flaky; it doesn't always pass the tests in our pipeline. > > ====================================================================== > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:116> > ERROR: runTest (pgadmin.feature_tests.query_tool_tests.QueryToolFeatureTest) > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:117> > Query tool feature test > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:118> > ---------------------------------------------------------------------- > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:119> > Traceback (most recent call last): > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:120> > File > "/tmp/build/5988fb0a/pgadmin-repo/web/pgadmin/feature_tests/query_tool_tests.py", > line 101, in runTest > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:121> > self._query_tool_notify_statements() > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:122> > File > "/tmp/build/5988fb0a/pgadmin-repo/web/pgadmin/feature_tests/query_tool_tests.py", > line 643, in _query_tool_notify_statements > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:123> > '//div[contains(@class, "sql-editor-message") and ' > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:124> > File > "/tmp/build/5988fb0a/pgadmin-repo/web/regression/feature_utils/pgadmin_page.py", > line 169, in find_by_xpath > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:125> > lambda driver: driver.find_element_by_xpath(xpath) > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:126> > File > "/tmp/build/5988fb0a/pgadmin-repo/web/regression/feature_utils/pgadmin_page.py", > line 261, in wait_for_element > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:127> > return self._wait_for("element to exist", element_if_it_exists) > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:128> > File > "/tmp/build/5988fb0a/pgadmin-repo/web/regression/feature_utils/pgadmin_page.py", > line 327, in _wait_for > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:129> > "Timed out waiting for " + waiting_for_message > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:130> > File > "/root/.pyenv/versions/pgadmin/lib/python2.7/site-packages/selenium/webdriver/support/wait.py", > line 80, in until > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:131> > raise TimeoutException(message, screen, stacktrace) > > <https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/77#L5ae79092:132> > TimeoutException: Message: Timed out waiting for element to exist > > > All the failures are related to query_tool_notify_statements. Please take > another look. > There is some serious problems of timeout issues. I have tested it couple of times and working fine. Will test tomorrow one more time. I have followed the code written in the same file. If those test cases have passed then this should also. > > Sincerely, > > Victoria & Joao > > On Tue, May 15, 2018 at 6:01 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to capture the notification from psycopg2 and >> displayed it in "Messages" tab of query tool. Added feature test to cover >> this scenario. >> >> Refer Notification.png file to how it looks in "Messages" tab. Please >> review it. >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> >
