Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Thanks, applied. On Thu, Jun 22, 2017 at 2:43 PM, Khushboo Vashi wrote: > Hi Dave, > > One more fix for this module. > > Thanks, > Khushboo > > On Thu, Jun 22, 2017 at 4:49 PM, Dave Page wrote: >> >> Thanks, patch applied. >> >> On Thu, Jun 22, 2017 at 11:06 AM, Khushboo Vashi >> wrote: >> > Hi

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hi Dave, One more fix for this module. Thanks, Khushboo On Thu, Jun 22, 2017 at 4:49 PM, Dave Page wrote: > Thanks, patch applied. > > On Thu, Jun 22, 2017 at 11:06 AM, Khushboo Vashi > wrote: > > Hi, > > > > Please find the attached fix for the same. > > > > Thanks, > > Khushboo > > > > On T

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Thanks, patch applied. On Thu, Jun 22, 2017 at 11:06 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached fix for the same. > > Thanks, > Khushboo > > On Thu, Jun 22, 2017 at 2:18 PM, Dave Page wrote: >> >> Hmm, yes - and it's not giving the normal error instructing the user >> to set th

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hi, Please find the attached fix for the same. Thanks, Khushboo On Thu, Jun 22, 2017 at 2:18 PM, Dave Page wrote: > Hmm, yes - and it's not giving the normal error instructing the user > to set the path, but another one: "Failed to load preference > pg_bin_dir of module paths". > > Khushboo, c

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hmm, yes - and it's not giving the normal error instructing the user to set the path, but another one: "Failed to load preference pg_bin_dir of module paths". Khushboo, can you investigate and fix ASAP please? On Thu, Jun 22, 2017 at 9:31 AM, Murtuza Zabuawala wrote: > Hi Khusboo, > > Looks like

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hi Khusboo, Looks like given change have broken Backup, Restore, Import/Export & Maintenance, even if I have binary path set it is throwing an error. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 21, 2017 at 9:40 PM, Dave Pa

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Thanks, patch applied! On Wed, Jun 21, 2017 at 12:44 PM, Khushboo Vashi wrote: > Hi, > > Please find attached patch to fix RM #2487: get_preference() uses a > synchronous AJAX request. > > Introduced the client side caching for preferences to get rid of synchronous > AJAX request. > > > Thanks, >

[pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hi, Please find attached patch to fix RM #2487: get_preference() uses a synchronous AJAX request. Introduced the client side caching for preferences to get rid of synchronous AJAX request. Thanks, Khushboo diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/browser/te