Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

2017-06-30 Thread Dave Page
Thanks - seems to work for me :-). Patch applied. On Thu, Jun 29, 2017 at 1:35 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Wed, Jun 28, 2017 at 7:08 PM, Dave Page wrote: > >> Hi >> >> On Tue, Jun 27,

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

2017-06-29 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Wed, Jun 28, 2017 at 7:08 PM, Dave Page wrote: > Hi > > On Tue, Jun 27, 2017 at 11:54 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Tue, Jun 27, 2017 at 8:08 PM, Dave Page wrote: >> >>> Hi

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

2017-06-27 Thread Khushboo Vashi
Hi Dave, On Tue, Jun 27, 2017 at 8:08 PM, Dave Page wrote: > Hi > > I've had to revert this. Whilst it seems to work, after showing/hiding the > dashboard, I later find that when I completely reload the app, it fails, > leaving just the object menu present. I haven't come up with a concrete > ca

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

2017-06-27 Thread Dave Page
Hi I've had to revert this. Whilst it seems to work, after showing/hiding the dashboard, I later find that when I completely reload the app, it fails, leaving just the object menu present. I haven't come up with a concrete case to reproduce it. In the console, I see: wcDocker.min.js:38 Uncaught

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

2017-06-27 Thread Dave Page
Thanks, patch applied. On Tue, Jun 27, 2017 at 2:58 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Mon, Jun 26, 2017 at 5:08 PM, Dave Page wrote: > >> Hi >> >> Looks good, except that when I close the d

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

2017-06-26 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Mon, Jun 26, 2017 at 5:08 PM, Dave Page wrote: > Hi > > Looks good, except that when I close the dashboard panel, it continues > to run the queries to update the graphs until I change the selected > treeview node. Can we stop it i

Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

2017-06-26 Thread Dave Page
Hi Looks good, except that when I close the dashboard panel, it continues to run the queries to update the graphs until I change the selected treeview node. Can we stop it immediately? On Mon, Jun 26, 2017 at 1:56 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached patch for the feature

[pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

2017-06-25 Thread Khushboo Vashi
Hi, Please find the attached patch for the feature #2506: Allow the dashboard panel to be closed. Thanks, Khushboo diff --git a/web/pgadmin/browser/static/js/panel.js b/web/pgadmin/browser/static/js/panel.js index 71d2c68..bfa2e32 100644 --- a/web/pgadmin/browser/static/js/panel.js +++ b/web/pgad