Hi I've had to revert this. Whilst it seems to work, after showing/hiding the dashboard, I later find that when I completely reload the app, it fails, leaving just the object menu present. I haven't come up with a concrete case to reproduce it. In the console, I see:
wcDocker.min.js:38 Uncaught TypeError: Cannot read property '__save' of null at e.save (wcDocker.min.js:38) at Object.save_current_layout ( browser.js:340) at e.handleVisibility (panel.js:156) at e.__trigger ( wcDocker.min.js:34) at e.trigger (wcDocker.min.js:38) at e.clear ( wcDocker.min.js:38) at Object.init (browser.js:386) at (index):278 at Object.execCb (require.min.js:29) at Z.check (require.min.js:18) On Tue, Jun 27, 2017 at 9:21 AM, Dave Page <dp...@pgadmin.org> wrote: > Thanks, patch applied. > > On Tue, Jun 27, 2017 at 2:58 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> >> Thanks, >> Khushboo >> >> On Mon, Jun 26, 2017 at 5:08 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> Hi >>> >>> Looks good, except that when I close the dashboard panel, it continues >>> to run the queries to update the graphs until I change the selected >>> treeview node. Can we stop it immediately? >>> >>> Fixed >> >>> On Mon, Jun 26, 2017 at 1:56 AM, Khushboo Vashi >>> <khushboo.va...@enterprisedb.com> wrote: >>> > Hi, >>> > >>> > Please find the attached patch for the feature #2506: Allow the >>> dashboard >>> > panel to be closed. >>> > >>> > Thanks, >>> > Khushboo >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
