Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-18 Thread Murtuza Zabuawala
Sure Dave. On Mon, Dec 18, 2017 at 2:55 PM, Dave Page wrote: > Hi > > I've committed this, but a couple of thoughts that should be > considered/implemented: > > 1) The first button should have focus immediately rather than the text > area. In the debugger at least, there is no real reason to hav

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-18 Thread Dave Page
Hi I've committed this, but a couple of thoughts that should be considered/implemented: 1) The first button should have focus immediately rather than the text area. In the debugger at least, there is no real reason to have the text area get focus by default. 2) If a button gets focus and is push

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-14 Thread Murtuza Zabuawala
On Thu, Dec 14, 2017 at 2:17 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Dec 14, 2017 at 2:07 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Yes, we can commit this code, It will add basic button navigation via Tab >> key. >> >> I think we should hold till our

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-14 Thread Khushboo Vashi
On Thu, Dec 14, 2017 at 2:07 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Yes, we can commit this code, It will add basic button navigation via Tab > key. > > I think we should hold till our final design gets ready. > I will keep the RM open until we add Tab navigation :)

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-14 Thread Murtuza Zabuawala
Yes, we can commit this code, It will add basic button navigation via Tab key. I will keep the RM open until we add Tab navigation :) On Wed, Dec 13, 2017 at 9:33 PM, Dave Page wrote: > Hi, > > On Wed, Dec 13, 2017 at 7:55 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> PFA patc

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-13 Thread Dave Page
Hi, On Wed, Dec 13, 2017 at 7:55 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to add basic Tab key navigation in debugger window, where user > will be able to navigate buttons using Tab key. > RM#2897 > > TODO:// Need to work on Debugger window Panel navi

[pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-12 Thread Murtuza Zabuawala
Hi, PFA patch to add basic Tab key navigation in debugger window, where user will be able to navigate buttons using Tab key. RM#2897 TODO:// Need to work on Debugger window Panel navigation. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company