Sure Dave. On Mon, Dec 18, 2017 at 2:55 PM, Dave Page <dp...@pgadmin.org> wrote:
> Hi > > I've committed this, but a couple of thoughts that should be > considered/implemented: > > 1) The first button should have focus immediately rather than the text > area. In the debugger at least, there is no real reason to have the text > area get focus by default. > > 2) If a button gets focus and is pushed, it should retain focus. > Otherwise, stepping through code is *really* tedious. > > Thanks. > > On Thu, Dec 14, 2017 at 9:07 AM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> On Thu, Dec 14, 2017 at 2:17 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Dec 14, 2017 at 2:07 PM, Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>>> Yes, we can commit this code, It will add basic button navigation via >>>> Tab key. >>>> >>>> I think we should hold till our final design gets ready. >>> >> Adding 'tabindex' on button won't hurt in anyway and not become any kind >> of hurdle in design. >> >> >>> I will keep the RM open until we add Tab navigation :) >>>> >>>> >>>> On Wed, Dec 13, 2017 at 9:33 PM, Dave Page <dp...@pgadmin.org> wrote: >>>> >>>>> Hi, >>>>> >>>>> On Wed, Dec 13, 2017 at 7:55 AM, Murtuza Zabuawala < >>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> PFA patch to add basic Tab key navigation in debugger window, where >>>>>> user will be able to navigate buttons using Tab key. >>>>>> RM#2897 >>>>>> >>>>>> TODO:// Need to work on Debugger window Panel navigation. >>>>>> >>>>> >>>>> Given our conversation this morning, do we still want to apply this at >>>>> this time? >>>>> >>>>> (for the benefit of the list, Murtuza, Khushboo, Harshal and I were >>>>> discussing a keyboard navigation strategy for the whole application). >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
