Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Thanks, patch applied. On Mon, Apr 20, 2020 at 2:38 PM Amol Vyavahare < amol.vyavah...@enterprisedb.com> wrote: > Thanks for the feedback. > > 1. The test case is particularly written for Temporary table with Commit > Drop, so please mention it in the comments. > *- Done* > > 2. Also, the class T

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Thanks for the feedback. 1. The test case is particularly written for Temporary table with Commit Drop, so please mention it in the comments. *- Done* 2. Also, the class TestQueryUpdatableResultset is been inherited, so no need to repeat the same methods, for example: setUp, _execute_select_sql,

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Hi Amol, The patch is working fine and looks good to me however some code related review comments: 1. The test case is particularly written for Temporary table with Commit Drop, so please mention it in the comments. 2. Also, the class TestQueryUpdatableResultset is been inherited, so no need to r

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Hi Khushboo, Please find attached the updated patch with the latest changes as suggested along with API test cases for the RM4946 issue fix. Thank You. On Wed, Apr 15, 2020 at 2:26 PM Amol Vyavahare < amol.vyavah...@enterprisedb.com> wrote: > Sure, will do that. > > On Wed, Apr 15, 2020 at 1:33

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Sure, will do that. On Wed, Apr 15, 2020 at 1:33 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Amol, > > On Wed, Apr 15, 2020 at 12:06 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> I am reviewing this patch. >> >> Thanks, >> Khushboo >> >> On Wed,

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Hi Amol, On Wed, Apr 15, 2020 at 12:06 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > I am reviewing this patch. > > Thanks, > Khushboo > > On Wed, Apr 15, 2020 at 11:45 AM Amol Vyavahare < > amol.vyavah...@enterprisedb.com> wrote: > >> Hi Hackers, >> Attached is the patch

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Hi, I am reviewing this patch. Thanks, Khushboo On Wed, Apr 15, 2020 at 11:45 AM Amol Vyavahare < amol.vyavah...@enterprisedb.com> wrote: > Hi Hackers, > Attached is the patch to fix the Issue with temporary tables on commit > drop as. This patch fixes the issue where an error was thrown when t

[pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Hi Hackers, Attached is the patch to fix the Issue with temporary tables on commit drop as. This patch fixes the issue where an error was thrown when the user tried to create a temporary table via query tool and no result was displayed when the query was executed. Please review. -- *Regards,* *A