Thanks, patch applied. On Mon, Apr 20, 2020 at 2:38 PM Amol Vyavahare < amol.vyavah...@enterprisedb.com> wrote:
> Thanks for the feedback. > > 1. The test case is particularly written for Temporary table with Commit > Drop, so please mention it in the comments. > *- Done* > > 2. Also, the class TestQueryUpdatableResultset is been inherited, so no > need to repeat the same methods, for example: setUp, _execute_select_sql, > tearDown > *- Done, some minor changes were done to make this change* > > Please find the updated patch attached herewith. > > On Mon, Apr 20, 2020 at 8:56 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Amol, >> >> The patch is working fine and looks good to me however some code related >> review comments: >> >> 1. The test case is particularly written for Temporary table with Commit >> Drop, so please mention it in the comments. >> 2. Also, the class TestQueryUpdatableResultset is been inherited, so no >> need to repeat the same methods, for example: setUp, >> _execute_select_sql, tearDown >> >> >> Thanks, >> Khushboo >> >> >> On Fri, Apr 17, 2020 at 3:49 PM Amol Vyavahare < >> amol.vyavah...@enterprisedb.com> wrote: >> >>> Hi Khushboo, >>> >>> Please find attached the updated patch with the latest changes as >>> suggested along with API test cases for the RM4946 issue fix. >>> >>> Thank You. >>> >>> On Wed, Apr 15, 2020 at 2:26 PM Amol Vyavahare < >>> amol.vyavah...@enterprisedb.com> wrote: >>> >>>> Sure, will do that. >>>> >>>> On Wed, Apr 15, 2020 at 1:33 PM Khushboo Vashi < >>>> khushboo.va...@enterprisedb.com> wrote: >>>> >>>>> Hi Amol, >>>>> >>>>> On Wed, Apr 15, 2020 at 12:06 PM Khushboo Vashi < >>>>> khushboo.va...@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> I am reviewing this patch. >>>>>> >>>>>> Thanks, >>>>>> Khushboo >>>>>> >>>>>> On Wed, Apr 15, 2020 at 11:45 AM Amol Vyavahare < >>>>>> amol.vyavah...@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> Attached is the patch to fix the Issue with temporary tables on >>>>>>> commit drop as. This patch fixes the issue where an error was thrown >>>>>>> when >>>>>>> the user tried to create a temporary table via query tool and no result >>>>>>> was displayed when the query was executed. >>>>>>> >>>>>>> Please review. >>>>>>> >>>>>>> Please write the API test cases for the same even if the changes are >>>>> very small but they are in the SQL Editor backend code. >>>>> The patch is working fine and looks good to me. >>>>> >>>>> Thanks, >>>>> Khushboo >>>>> >>>>>> -- >>>>>>> *Regards,* >>>>>>> *Amol Vyavahare* >>>>>>> *E**nterpriseDB Corporation* >>>>>>> The Enterprise Postgres Company >>>>>>> *T: +91 20 6644 9600, M: +91 738 738 2128* >>>>>>> [image: EDB Postgres] <http://www.edbpostgres.com/>Unit 301 A, >>>>>>> Third Floor, Godrej Castlemaine, >>>>>>> 155, Sassoon Road, Pune, MH - 411001 >>>>>>> [image: Blog Feed] <http://blogs.edbpostgres.com/> [image: Facebook] >>>>>>> <https://www.facebook.com/EnterpriseDB> [image: Twitter] >>>>>>> <https://twitter.com/EnterpriseDB> [image: LinkedIn] >>>>>>> <https://www.linkedin.com/company/14958?trk=tyah> [image: Google+] >>>>>>> <https://plus.google.com/108046988421677398468> >>>>>>> Website: www.enterprisedb.com >>>>>>> EnterpriseDB Blog: http://blogs.enterprisedb.com/ >>>>>>> Follow us on Twitter: http://www.twitter.com/enterprisedb >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>> >>>> -- >>>> *Regards,* >>>> *Amol Vyavahare* >>>> *E**nterpriseDB Corporation* >>>> The Enterprise Postgres Company >>>> *T: +91 20 6644 9600, M: +91 738 738 2128* >>>> [image: EDB Postgres] <http://www.edbpostgres.com/>Unit 301 A, Third >>>> Floor, Godrej Castlemaine, >>>> 155, Sassoon Road, Pune, MH - 411001 >>>> [image: Blog Feed] <http://blogs.edbpostgres.com/> [image: Facebook] >>>> <https://www.facebook.com/EnterpriseDB> [image: Twitter] >>>> <https://twitter.com/EnterpriseDB> [image: LinkedIn] >>>> <https://www.linkedin.com/company/14958?trk=tyah> [image: Google+] >>>> <https://plus.google.com/108046988421677398468> >>>> Website: www.enterprisedb.com >>>> EnterpriseDB Blog: http://blogs.enterprisedb.com/ >>>> Follow us on Twitter: http://www.twitter.com/enterprisedb >>>> >>>> >>>> >>>> >>> >>> -- >>> *Regards,* >>> *Amol Vyavahare* >>> *E**nterpriseDB Corporation* >>> The Enterprise Postgres Company >>> *T: +91 20 6644 9600, M: +91 738 738 2128* >>> [image: EDB Postgres] <http://www.edbpostgres.com/>Unit 301 A, Third >>> Floor, Godrej Castlemaine, >>> 155, Sassoon Road, Pune, MH - 411001 >>> [image: Blog Feed] <http://blogs.edbpostgres.com/> [image: Facebook] >>> <https://www.facebook.com/EnterpriseDB> [image: Twitter] >>> <https://twitter.com/EnterpriseDB> [image: LinkedIn] >>> <https://www.linkedin.com/company/14958?trk=tyah> [image: Google+] >>> <https://plus.google.com/108046988421677398468> >>> Website: www.enterprisedb.com >>> EnterpriseDB Blog: http://blogs.enterprisedb.com/ >>> Follow us on Twitter: http://www.twitter.com/enterprisedb >>> >>> >>> >>> > > -- > *Regards,* > *Amol Vyavahare* > *E**nterpriseDB Corporation* > The Enterprise Postgres Company > *T: +91 20 6644 9600, M: +91 738 738 2128* > [image: EDB Postgres] <http://www.edbpostgres.com/>Unit 301 A, Third > Floor, Godrej Castlemaine, > 155, Sassoon Road, Pune, MH - 411001 > [image: Blog Feed] <http://blogs.edbpostgres.com/> [image: Facebook] > <https://www.facebook.com/EnterpriseDB> [image: Twitter] > <https://twitter.com/EnterpriseDB> [image: LinkedIn] > <https://www.linkedin.com/company/14958?trk=tyah> [image: Google+] > <https://plus.google.com/108046988421677398468> > Website: www.enterprisedb.com > EnterpriseDB Blog: http://blogs.enterprisedb.com/ > Follow us on Twitter: http://www.twitter.com/enterprisedb > > > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
