Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-06-10 Thread Dave Page
Thanks, applied! On Wed, Jun 5, 2019 at 1:18 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated, rebased patch. I was using the wrong key code for > "[" and "]" while registering, but strangely it was working for me. I have > corrected that.

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-06-05 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated, rebased patch. I was using the wrong key code for "[" and "]" while registering, but strangely it was working for me. I have corrected that. Plus, I found a bug in Preferences. If a preference name is same in two different modules, then it was registered only o

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-30 Thread Dave Page
Hi On Thu, May 30, 2019 at 4:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Thu, May 30, 2019 at 1:38 AM Dave Page wrote: > >> Hi >> >> On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Thu, May

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-30 Thread Aditya Toshniwal
Hi, On Thu, May 30, 2019 at 1:38 AM Dave Page wrote: > Hi > > On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Thu, May 23, 2019 at 1:31 PM Dave Page wrote: >> >>> Hi, >>> >>> On further testing, this doesn't seem to be working as

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-29 Thread Dave Page
Hi On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Thu, May 23, 2019 at 1:31 PM Dave Page wrote: > >> Hi, >> >> On further testing, this doesn't seem to be working as expected. >> Alt+Shift+] or [ in the query tool are typing ’ and ” and

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-28 Thread Aditya Toshniwal
Hi, On Thu, May 23, 2019 at 1:31 PM Dave Page wrote: > Hi, > > On further testing, this doesn't seem to be working as expected. > Alt+Shift+] or [ in the query tool are typing ’ and ” and not changing the > tab. If I switch to a non-input tab (e.g. History), they still don't work. > I am not abl

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-23 Thread Dave Page
Hi, On further testing, this doesn't seem to be working as expected. Alt+Shift+] or [ in the query tool are typing ’ and ” and not changing the tab. If I switch to a non-input tab (e.g. History), they still don't work. Alt+Shift+Tab changes the panel successfully though, and does cause the flash

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-21 Thread Aditya Toshniwal
Hi, Attached is the updated patch with doc changes. On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, May 21, 2019 at 5:32 PM Dave Page wrote: > >> Hi >> >> On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < >> aditya.toshni...@enter

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-21 Thread Aditya Toshniwal
Hi, On Tue, May 21, 2019 at 5:32 PM Dave Page wrote: > Hi > > On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix the accessibility issue in query tool. >> >> The query tool can be completely restruct

Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-21 Thread Dave Page
Hi On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the accessibility issue in query tool. > > The query tool can be completely restructured unlike previously where > query tool used to stick at top and ot

[pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility)

2019-05-21 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix the accessibility issue in query tool. The query tool can be completely restructured unlike previously where query tool used to stick at top and other tabs in the bottom. - I have added a new shortcut to switch between frames if in query tool the tab posit