Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Will work on that too. On Wed, Aug 7, 2019, 11:06 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > Users have also raised issue where they are not able to double click the > cell and see the content. Now, if the result set is not updatable, double > click does nothi

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi Yosry, Users have also raised issue where they are not able to double click the cell and see the content. Now, if the result set is not updatable, double click does nothing. If the data is JSON, there is no way to see the content. It should show the editor without the Save button if the result

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi, On Wed, Aug 7, 2019, 10:31 AM Dave Page wrote: > Hi > > On Tue, Aug 6, 2019 at 5:46 PM Yosry Muhammad wrote: > >> Hi, >> >> On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: >> >>> Hi >>> >>> Seems to work well :-). A few comments: >>> >>> - Should we have an icon by the non-generated queries

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi On Tue, Aug 6, 2019 at 5:46 PM Yosry Muhammad wrote: > Hi, > > On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: > >> Hi >> >> Seems to work well :-). A few comments: >> >> - Should we have an icon by the non-generated queries (the lightning >> flash) and the COMMITs etc (the commit/rollback ico

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi, On Tue, Aug 6, 2019, 6:46 PM Yosry Muhammad wrote: > Hi, > > On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: > >> Hi >> >> Seems to work well :-). A few comments: >> >> - Should we have an icon by the non-generated queries (the lightning >> flash) and the COMMITs etc (the commit/rollback icon

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi, On Tue, Aug 6, 2019, 6:01 PM Dave Page wrote: > Hi > > Seems to work well :-). A few comments: > > - Should we have an icon by the non-generated queries (the lightning > flash) and the COMMITs etc (the commit/rollback icon as appropriate) as > well? I think just having the icon for generated

Re: [GSoC] Query History Integration with updatable query resultsets and improvements

Hi Seems to work well :-). A few comments: - Should we have an icon by the non-generated queries (the lightning flash) and the COMMITs etc (the commit/rollback icon as appropriate) as well? I think just having the icon for generated queries looks a little odd. - PEP-8 checks failed: pycodestyle

[GSoC] Query History Integration with updatable query resultsets and improvements

Hi Dave and Hackers, Please find attached a work-in-progress patch with the following modifications to the query history: 1- Queries generated by pgAdmin in Save Data operations are now recorded in query history. This includes transaction control commands such as 'COMMIT, ROLLBACK, SAVEPOINT, etc