Will work on that too. On Wed, Aug 7, 2019, 11:06 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote:
> Hi Yosry, > > Users have also raised issue where they are not able to double click the > cell and see the content. Now, if the result set is not updatable, double > click does nothing. If the data is JSON, there is no way to see the > content. It should show the editor without the Save button if the result > set is not updatable. > > On Wed, Aug 7, 2019 at 2:05 PM Yosry Muhammad <yosry...@gmail.com> wrote: > >> Hi, >> >> On Wed, Aug 7, 2019, 10:31 AM Dave Page <dp...@pgadmin.org> wrote: >> >>> Hi >>> >>> On Tue, Aug 6, 2019 at 5:46 PM Yosry Muhammad <yosry...@gmail.com> >>> wrote: >>> >>>> Hi, >>>> >>>> On Tue, Aug 6, 2019, 6:01 PM Dave Page <dp...@pgadmin.org> wrote: >>>> >>>>> Hi >>>>> >>>>> Seems to work well :-). A few comments: >>>>> >>>>> - Should we have an icon by the non-generated queries (the lightning >>>>> flash) and the COMMITs etc (the commit/rollback icon as appropriate) as >>>>> well? I think just having the icon for generated queries looks a little >>>>> odd. >>>>> >>>> >>>> I am sorry I don't quite understand. Do you mean having an icon to >>>> show/hide user queries as well? I believe a checkbox is more appropriate >>>> anyway, maybe placed right above the history entries. I am going to need a >>>> design of the checkbox or styling guidlines though. >>>> >>> >>> No, I mean put an icon by all queries to indicate the source of them. >>> We'd probably want one for the EXPLAIN button too. >>> >> >> Okay, got it. >> >> >>> For showing/hiding generate queries, we should use one of our slider >>> switches that we use elsewhere. >>> >>> One other thing I found: The Copy to Query Editor button has gone >>> missing, and the Copy button seems to have stopped working. >>> >>> >>>> >> I will check that, thanks for the feedback. >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" >
