This patch allows create column to see available types in the dropdown
Dave Cramer
diff --git
a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
index 11d40dd..ef08d48 100644
---
a/web
Even better.
I'm a python noob so help me out!
Dave Cramer
On 25 August 2017 at 15:17, Harshal Dhumal
wrote:
> how about this?
>
> default_path = (
> config.DEFAULT_BINARY_PATHS.get(st.stype, "")
> )
>
>
>
>
>
See attached patch
Dave Cramer
keyerror.patch
Description: Binary data
I'm suggesting that it be pushed
Dave Cramer
On 24 August 2017 at 23:00, Teng Zhang wrote:
> Sure, you can get as much as you like.
> Thanks
>
> -- Forwarded message ------
> From: Dave Cramer
> Date: Thu, Aug 24, 2017 at 8:34 PM
> Subject: Re: [pgadmin4]
Can we get some movement on this patch? This seems like a more sane way to
go to support different "products"
Dave Cramer
On 22 August 2017 at 16:56, Dave Cramer wrote:
>
> On 22 August 2017 at 16:41, Dave Cramer wrote:
>
>> Ok,
>>
>> Surely this :
>&g
On 22 August 2017 at 16:41, Dave Cramer wrote:
> Ok,
>
> Surely this :
>
> self.table_template_path = 'table/sql/' + (
> +'#{0}#{1}#'.format(server_type, ver)
> +if server_type == 'gpdb' else
> +
Ok,
Surely this :
self.table_template_path = 'table/sql/' + (
+'#{0}#{1}#'.format(server_type, ver)
+if server_type == 'gpdb' else
+'#{0}#'.format(ver)
+)
could be written in a more readable ma
Hi,
I've been able to get back to this and test it. So far so good. It applies
more or less cleanly against 1.6 and everything I've tried so far works
I'll update more as I test it.
Thanks
Dave Cramer
On 21 August 2017 at 05:29, Teng Zhang wrote:
> Hi,
>
> Thanks f
Hi Violet.
I don't really like the way this has been implemented. It adds a variable
which is only used for gpdb.
There are other places in the code where the behaviour is changed if the
server is ppas or regular postgres.
Candidly I think all of this needs restructuring.
Dave Cramer
So what is the policy of the project? Ideally the cruft should be removed.
Would a patch doing so be committed?
Dave Cramer
On 9 August 2017 at 00:28, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Yes, you are correct, at a moment that's all it does.
>
>
is all it does?
Dave Cramer
On 7 August 2017 at 23:35, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> This piece of code allow us to dynamically import all the available driver
> modules from '../utils/driver/' directory into our applicati
', drivers)
DriverRegistry.load_drivers()
return drivers
Dave Cramer
I don't think this line
in web/pgadmin/browser/server_groups/servers/types.py does what it should.
default_path = config.DEFAULT_BINARY_PATHS[st.stype] or ""
will ever succeed if the key does not exist
Attached patch should work.
Dave Cramer
fixkeyerror.patch
Description: Binary data
Rob,
Will do, thanks!
Dave Cramer
On 29 July 2017 at 02:41, Robert Eckhardt wrote:
> Dave,
>
> We just set up 3 workstations if you don't mind waiting a couple of days
> we can go in on Monday and share the directions we followed. Maybe that
> will help spell out ho
lication server could not be
contacted"
Thanks,
Dave Cramer
On 28 July 2017 at 07:49, Dave Cramer wrote:
> Hi Kushboo,
>
> Thanks for the quick reply. I compiled it from HEAD. I will follow the
> instructions for deployment and get back to you .
>
> Dave
>
> Dave C
Hi Kushboo,
Thanks for the quick reply. I compiled it from HEAD. I will follow the
instructions for deployment and get back to you .
Dave
Dave Cramer
On 27 July 2017 at 21:59, Khushboo Vashi
wrote:
> Hi Dave,
>
> Please provide below information to investigate:
>
> 1. OS Detai
When I start pgadmin4 application I get the following error
The application server could not be contacted!
Thanks,
Dave Cramer
17 matches
Mail list logo
