Hi Violet.

I don't really like the way this has been implemented. It adds a variable
which is only used for gpdb.

There are other places in the code where the behaviour is changed if the
server is ppas or regular postgres.

Candidly I think all of this needs restructuring.

Dave Cramer

On 15 August 2017 at 23:29, Violet Cheng <vch...@pivotal.io> wrote:

> Hi,
>
> Any comment on this patch? If no, will it be committed soon?
>
> Thanks,
> Violet
>
> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear <smcal...@pivotal.io>
> wrote:
>
>> Hi Hackers!
>>
>> This patch enables Greenplum users to see the same charts on the
>> dashboard as postgres users. It also adds some additional information to
>> the DDL that is Greenplum specific and necessary to create a new table.
>>
>> Thanks!
>> Sarah
>>
>>
>>
>

Reply via email to