Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube

Thanks, patch applied. On Mon, Jun 15, 2020 at 6:43 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find patching fixing issues related to shadowing variables - > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > -- *Than

Re: [pgAdmin][patch] SonarQube reported vulnerabilities and design suspicions

Thanks, patch applied. On Tue, Jun 16, 2020 at 10:01 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will fix few vulnerabilities and few design suspicions > where > two conditional structures are having same implementation. > Please review. > > --

Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

Thanks, patch applied. On Mon, Jun 15, 2020 at 6:58 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find an updated patch. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > > > On Mon, Jun 15, 2020 at 3:52 PM Khush

pgAdmin 4 commit: Fixed vulnerabilities and few design suspicions where

Fixed vulnerabilities and few design suspicions where two conditional structures are having the same implementation. Reported by SonarQube Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3e00fe2b0fd19d3837b7ab45c25036d8c96a551f Author: Aditya

pgAdmin 4 commit: Fixed issue related to shadowing variables reported b

Fixed issue related to shadowing variables reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=697f4aec95dc1f7887ab7c2a3c46d2ecfb7681be Author: Yogesh Mahajan Modified Files -- .../server_groups/servers/static/j

pgAdmin 4 commit: Fixed an issue where select all checkbox only selects

Fixed an issue where select all checkbox only selects the first 50 tables. Fixes #4226 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ae5c0ec4f8c29575bde0b18dc0f4ba1faad94bc Author: Yogesh Mahajan Modified Files -- docs/en_US/r

[pgAdmin][patch] SonarQube reported vulnerabilities and design suspicions

Hi Hackers, Attached patch will fix few vulnerabilities and few design suspicions where two conditional structures are having same implementation. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat,

Re: Patch for SonarQube UI fixes.

On Tue, Jun 16, 2020 at 9:20 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Tue, Jun 16, 2020 at 8:57 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Jun 16, 2020 at 8:46 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >

Re: Patch for SonarQube UI fixes.

On Tue, Jun 16, 2020 at 8:57 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, Jun 16, 2020 at 8:46 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> >> On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>

Re: Patch for SonarQube UI fixes.

On Tue, Jun 16, 2020 at 8:46 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > > On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> As per my earlier comment, the dashboard.js fix is still failing. >> > But assigning the return value i

Re: Patch for SonarQube UI fixes.

On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > As per my earlier comment, the dashboard.js fix is still failing. > But assigning the return value is not a solution. Replace map with forEach so that it doesn't expect a return value at all (as there is non

Re: Patch for SonarQube UI fixes.

As per my earlier comment, the dashboard.js fix is still failing. On Mon, Jun 15, 2020 at 5:16 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Mon, Jun 15, 2020 at 4:45 PM Khushbo

Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

Hi Hackers, Please find an updated patch. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Mon, Jun 15, 2020 at 3:52 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Yogesh, > > this.data.splice is not required as you are adding the entire dat

[pgAdmin4][Patch] - Issue fixes reported by SonarQube

Hi, Please find patching fixing issues related to shadowing variables - Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix1_v1.patch Description: Binary data

Re: Patch for SonarQube UI fixes.

Thanks, patch applied. On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal < >> aditya.toshni...@e

pgAdmin 4 commit: Fixed RESQL test cases, regression of RLS policy.

Fixed RESQL test cases, regression of RLS policy. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a21e6448ce7afb43fc56a06cf2d1ce2dbace6729 Modified Files -- .../tables/row_security_policies/tests/default/alter_policy.sql| 7 +++

pgAdmin 4 commit: Remove duplicate properties in CSS and few js standar

Remove duplicate properties in CSS and few js standard fixes reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=023a1f222f05abb2ded1e9f8bfc38f89fd3dd4d2 Author: Nikhil Mohite Modified Files -- web/pgadmin/dash

Re: [pgAdmin][patch] Clumsy coding related fixes

Thanks, patch applied. On Mon, Jun 15, 2020 at 12:08 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please ignore the previous patch, attached is the updated patch. > > On Mon, Jun 15, 2020 at 11:50 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >>

Re: Reg - [sonarqube] Refactor this code so that this expression does not always evaluate to true

Thanks, patch applied. On Mon, Jun 15, 2020 at 4:19 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The patch looks good to me. > > On Mon, Jun 15, 2020 at 11:20 AM Satish V > wrote: > >> Hi Hackers, >> >> Please find the patch in the attachment which clears the sonarqu

Re: Patch to contribute in pgAdmin to increase the maximum length of the server password

Thanks, patch applied. On Mon, Jun 15, 2020 at 4:28 PM Mishika Singh wrote: > Hi Aditya, > > I am part of Adobe Experience Platform - Query Service team. Query Service > uses the Postgres protocol to query data in Platform. We have enabled a > variety of client applications to connect to Query S

Re: [pgAdmin4][Patch] - Issue fixes reported by SonarQube

Thanks, patch applied. On Mon, Jun 15, 2020 at 2:17 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for some of the fixes reported by SonarQube > related to : > >- Properties of variables with "null" or "undefined" values should not >be

pgAdmin 4 commit: Some clumsy coding related fixes reported by SonarQub

Some clumsy coding related fixes reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=641f7bbe9d12068560ebce47bcb82d54723247ed Author: Aditya Toshniwal Modified Files -- .../databases/languages/static/js/language

pgAdmin 4 commit: Fix following issues reported by SonarQube:

Fix following issues reported by SonarQube: 1) Properties of variables with "null" or "undefined" values should not be accessed 2) Variables should not be self-assigned 3) "in" should not be used with primitive types Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmi

pgAdmin 4 commit: Ensure that pgadmin should be able to connect to the

Ensure that pgadmin should be able to connect to the server which has password more than 1000 characters. Fixes #5592 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=38cd3327f354c2c2a850b08086a7602c85a4f48c Author: Mishika Singh Modified Fil

pgAdmin 4 commit: Fix 'expressions evaluated to true/false always' issu

Fix 'expressions evaluated to true/false always' issue reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eb1b17b636cfd6cbf00df98dbbdbadac8976043d Author: Satish V Modified Files -- .../static/js/domain_constra

Re: Patch for SonarQube UI fixes.

Hi, On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> The patch looks good to me. >> > I think the dashboard.js fix is not accurate as when you

Re: Patch for SonarQube UI fixes.

On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The patch looks good to me. > I think the dashboard.js fix is not accurate as when you return something you have to assign that value to any variable. > > On Mon, Jun 15, 2020 at 4:22 PM Nikhil

Re: [pgAdmin][patch] Runtime fixes reported by SonarQube

Thanks - committed with a minor change to sleep for 250ms in the loop whilst we're waiting for the server thread to shut down, during which time we process any Qt events. On Fri, Jun 12, 2020 at 10:21 AM Akshay Joshi wrote: > Hi Hackers, > > Attached is the patch to fix runtime issues reported b

pgAdmin 4 commit: Tidy up some code to keep SonarQube happy.

Tidy up some code to keep SonarQube happy. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a23fad0ba8e16cf0adc8d6d8107b6777956fb71e Author: Akshay Joshi Modified Files -- runtime/ConfigWindow.cpp | 8 ++-- runtime/ConfigWind

Re: Patch for SonarQube UI fixes.

Hi, The patch looks good to me. On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some UI related issues of SonarQube scan. > Mainly fixes are related to removing duplicate properties in css class and > few js standard syntax fixe

Re: Patch to contribute in pgAdmin to increase the maximum length of the server password

Hi Aditya, I am part of Adobe Experience Platform - Query Service team. Query Service uses the Postgres protocol to query data in Platform. We have enabled a variety of client applications to connect to Query Service like Aqua Data Studio, Power BI, Tableau. [ https://docs.adobe.com/content/help/e

Patch for SonarQube UI fixes.

Hi Team, I have fixed some UI related issues of SonarQube scan. Mainly fixes are related to removing duplicate properties in css class and few js standard syntax fixes. PFA patch. sonarqube_ui_fix.patch Description: Binary data

Re: Reg - [sonarqube] Refactor this code so that this expression does not always evaluate to true

Hi, The patch looks good to me. On Mon, Jun 15, 2020 at 11:20 AM Satish V wrote: > Hi Hackers, > > Please find the patch in the attachment which clears the sonarqube error, > related to expressions evaluated to true/false always. Kindly review the > patch and share the changes required > > > Th

Re: Patch to contribute in pgAdmin to increase the maximum length of the server password

Hi Mishika, The patch looks good to me. Just out of curiosity, what is the use case where the password is more than 1000 characters ? :O On Mon, Jun 15, 2020 at 3:41 PM Mishika Singh wrote: > Thanks Aditya for looking into this. I have done the changes noting > your suggestion to pass the maxLe

Re: [pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

Hi Yogesh, this.data.splice is not required as you are adding the entire dataset into collection. Thanks, Khushboo On Mon, Jun 15, 2020 at 3:01 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find attached patch fixing behaviour on checking select-all > c

Re: [pgAdmin][RM5516]: Added support of Row Security Policies

Thanks, patch applied with the following modifications: - js file name should be "row_security_policy.js" instead of "row_security_policies.js". - Node name should be "row_security_policy" instead of "row_level_policies". Node name should not be pluralized and it matches the folder name. - Icon na

pgAdmin 4 commit: Added support of Row Security Policies. Fixes #5516

Added support of Row Security Policies. Fixes #5516 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=18277543b6c702fa84f332c3a74840c376cd43e2 Author: Pradip Parkale Modified Files -- docs/en_US/release_notes_4_23.rst

Re: Patch to contribute in pgAdmin to increase the maximum length of the server password

Thanks Aditya for looking into this. I have done the changes noting your suggestion to pass the maxLength param for the password field. PFA of the patch for the same. On Mon, Jun 8, 2020 at 11:41 AM Aditya Toshniwal wrote: > > Hi Mishika, > > You've changed the defaults directly which will change

[pgAdmin][Patch] RM4226 - Table Properties - select all checkbox only selects the first 50 tables

Hi Hackers, Please find attached patch fixing behaviour on checking select-all checkbox from properties tab for more than 50 entities. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM4226_v1.patch Description: Binary data

[pgAdmin4][Patch] - Issue fixes reported by SonarQube

Hi, Please find the attached patch for some of the fixes reported by SonarQube related to : - Properties of variables with "null" or "undefined" values should not be accessed - Variables should not be self-assigned - "in" should not be used with primitive types Thanks, Khushboo so