Hi, On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote:
> > On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> The patch looks good to me. >> > I think the dashboard.js fix is not accurate as when you return something > you have to assign that value to any variable. > It's the map function which requires the return. Not necessary to assign the return value. > >> On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> I have fixed some UI related issues of SonarQube scan. >>> Mainly fixes are related to removing duplicate properties in css class >>> and few js standard syntax fixes. >>> PFA patch. >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
