Re: [GSoC][New Feature] Editable and Read-only Columns

Makes sense. Thanks a lot for your help :) On Sat, Aug 24, 2019, 8:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > My guess is because selenium is running faster on our machine. Depends on > machine. > > On Sat, Aug 24, 2019, 12:06 Yosry Muhammad wrote: > >> Hi

Re: [GSoC][New Feature] Editable and Read-only Columns

Hi Aditya, Thanks a lot. Do you have any idea why this problem never occurred on my machine by the way? On Sat, Aug 24, 2019, 8:18 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > It's failing for me as well. I debugged and found that, sometimes the grid > render

Re: Query Tool JS Minimal Refactoring

Thanks, committed. On Fri, Aug 23, 2019 at 3:42 PM Yosry Muhammad wrote: > No it isn't. I just needed to update JS tests after the latest > modification and merging with master. Please find an updated patch > attached, sorry for the inconvenience. > > On Fri, Aug 23, 2019 at 3:47 PM Dave Page w

Re: [GSoC][New Feature] Editable and Read-only Columns

Hi I've run it again 4 more times and it fails consistently for me. I'm running on macOS 10.14.5 with Chrome 76.0.3809.100. On Fri, Aug 23, 2019 at 3:17 PM Yosry Muhammad wrote: > Hi Dave, > > The tests pass on my device normally. I am using Python 3.6 on Ubuntu. I > have ran all tests using "m

pgAdmin 4 commit: Some refactoring of sqleditor.js.

Some refactoring of sqleditor.js. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5887fb38153e94307dfc8be47085353b9b9acf81 Author: Yosry Muhammad Modified Files -- web/pgadmin/static/js/sqleditor/execute_query.js | 8 +- .../st

Re: Query Tool JS Minimal Refactoring

No it isn't. I just needed to update JS tests after the latest modification and merging with master. Please find an updated patch attached, sorry for the inconvenience. On Fri, Aug 23, 2019 at 3:47 PM Dave Page wrote: > Thanks - I assume this is dependent on the updatable columns patch, as the >

Re: [GSoC][New Feature] Editable and Read-only Columns

Thanks. Unfortunately this is failing the tests: == ERROR: runTest (pgadmin.feature_tests.query_tool_journey_test.QueryToolJourneyTest) Tests the path through the query tool

Re: [GSoC][New Feature] Editable and Read-only Columns

Hi Dave, The tests pass on my device normally. I am using Python 3.6 on Ubuntu. I have ran all tests using "make check" and they all succeeded. I also ran feature_tests/query_tool_journey_test.py multiple times on its own using "cd web && python regression/runtests.py --pkg feature_tests --modules

Re: Query Tool JS Minimal Refactoring

Thanks - I assume this is dependent on the updatable columns patch, as the JS tests fail if I apply it to the current GIT head? On Fri, Aug 23, 2019 at 1:07 PM Yosry Muhammad wrote: > Please find an updated patch attached. > > On Fri, Aug 23, 2019 at 1:23 PM Dave Page wrote: > >> Hi >> >> On Fr

Re: Query Tool JS Minimal Refactoring

Please find an updated patch attached. On Fri, Aug 23, 2019 at 1:23 PM Dave Page wrote: > Hi > > On Fri, Aug 23, 2019 at 11:28 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Yosry, >> >> The v3 patch has changes like: >> diff --git a/docs/en_US/release_notes_4_13.rst >

Re: [GSoC][New Feature] Editable and Read-only Columns

Except it now doesn't apply as the async connection/rendering patch was in the queue right ahead of it :-(. Can I get a rebased patch please? On Fri, Aug 23, 2019 at 11:57 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Excellent !! Looks good to me. > > On Fri, Aug 23, 2019 at

Re: Query Tool JS Minimal Refactoring

Hi On Fri, Aug 23, 2019 at 11:28 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > The v3 patch has changes like: > diff --git a/docs/en_US/release_notes_4_13.rst > b/docs/en_US/release_notes_4_13.rst > index bc21dfeca..a0a3a38ef 100644 > --- a/docs/en_US/release_not

Re: [pgAdmin][RM4553] Query tool UX improvement

Nice! Patch applied, thanks. On Thu, Aug 22, 2019 at 9:08 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Forgot to mention, this patch also fixes > https://redmine.postgresql.org/issues/4584 - HTML entities aren't escaped > in database names > > On Thu, Aug 22, 2019 at 1:05 PM

pgAdmin 4 commit: Don't wait for the database connection before renderi

Don't wait for the database connection before rendering the Query Tool UI, for improved UX. Fixes #4453 In addition, unescape HTML entities in database names in the Query Tool title bar. Fixes #4584 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdi

Re: [GSoC][New Feature] Editable and Read-only Columns

Excellent !! Looks good to me. On Fri, Aug 23, 2019 at 2:23 PM Yosry Muhammad wrote: > I updated the patch for backwards compatibility anyway. > > On Fri, Aug 23, 2019 at 10:45 AM Dave Page wrote: > >> >> >> On Fri, Aug 23, 2019 at 9:43 AM Yosry Muhammad >> wrote: >> >>> Hi Aditya, >>> >>> On

Re: Query Tool JS Minimal Refactoring

Hi Yosry, The v3 patch has changes like: diff --git a/docs/en_US/release_notes_4_13.rst b/docs/en_US/release_notes_4_13.rst index bc21dfeca..a0a3a38ef 100644 --- a/docs/en_US/release_notes_4_13.rst +++ b/docs/en_US/release_notes_4_13.rst @@ -22,5 +22,4 @@ Bug fixes | `Issue #2706

Re: Query Tool JS Minimal Refactoring

Please find an updated patch attached. On Fri, Aug 23, 2019 at 7:57 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Yosry, > > This breaks the reconnect for query tool. Open a query tool, execute some > query and then restart the python server. Go to the query tool and click

pgAdmin 4 commit: Fix PGADMIN_SERVER_JSON_FILE environment variable sup

Fix PGADMIN_SERVER_JSON_FILE environment variable support in the container. Fixes #4657 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=25f85fe123bc17bfa6141014a32fc55a3861e412 Modified Files -- docs/en_US/release_notes_4_13.rst |

Re: [GSoC][New Feature] Editable and Read-only Columns

I updated the patch for backwards compatibility anyway. On Fri, Aug 23, 2019 at 10:45 AM Dave Page wrote: > > > On Fri, Aug 23, 2019 at 9:43 AM Yosry Muhammad wrote: > >> Hi Aditya, >> >> On Fri, Aug 23, 2019 at 7:33 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi

Re: [pgAdmin][RM4419] Debugger does not work on python 2.7

Thanks, applied. On Thu, Aug 22, 2019 at 9:15 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix an issue where debugger throws error and > doesn't work when using Python 2.7. > Also fixed a small issue where reload warning was thrown on

Re: [GSoC][New Feature] Editable and Read-only Columns

On Fri, Aug 23, 2019 at 9:43 AM Yosry Muhammad wrote: > Hi Aditya, > > On Fri, Aug 23, 2019 at 7:33 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Yosry, >> >> The previously mentioned issues seems to be fixed. Below are few issues: >> 1) On Python 2.7, I get below erro

pgAdmin 4 commit: Fix a debugger error when using Python 2.7. Fixes #44

Fix a debugger error when using Python 2.7. Fixes #4419 Also fixes a minor bug where a reload warning was unnecessarily given when closing the debugger. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3dadb8989b64ecc9277356c3295953abffee0223

Re: RM 4463 - MSQL test cases for domain node

Hi On Wed, Aug 21, 2019 at 8:58 AM Neel Patel wrote: > Hi, > > Please find attached patch that will add more resql test cases and msql > test cases for domain node. > >- Covered test cases for Length, Precision and Collation. >- Also added msql test cases. > > While writing resql test ca