Thanks - I assume this is dependent on the updatable columns patch, as the JS tests fail if I apply it to the current GIT head?
On Fri, Aug 23, 2019 at 1:07 PM Yosry Muhammad <yosry...@gmail.com> wrote: > Please find an updated patch attached. > > On Fri, Aug 23, 2019 at 1:23 PM Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Fri, Aug 23, 2019 at 11:28 AM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Yosry, >>> >>> The v3 patch has changes like: >>> diff --git a/docs/en_US/release_notes_4_13.rst >>> b/docs/en_US/release_notes_4_13.rst >>> index bc21dfeca..a0a3a38ef 100644 >>> --- a/docs/en_US/release_notes_4_13.rst >>> +++ b/docs/en_US/release_notes_4_13.rst >>> @@ -22,5 +22,4 @@ Bug fixes >>> | `Issue #2706 <https://redmine.postgresql.org/issues/2706>`_ - Added >>> ProjectSet icon for explain module. >>> | `Issue #2828 <https://redmine.postgresql.org/issues/2828>`_ - Added >>> Gather Merge, Named Tuple Store Scan and Table Function Scan icon for >>> explain module. >>> | `Issue #4643 <https://redmine.postgresql.org/issues/4643>`_ - Fix >>> Truncate option deselect issue for compound triggers. >>> -| `Issue #4644 <https://redmine.postgresql.org/issues/4644>`_ - Fix >>> length and precision enable/disable issue when changing the data type for >>> Domain node. >>> -| `Issue #4650 <https://redmine.postgresql.org/issues/4650>`_ - Fix >>> SQL tab issue for Views. It's a regression of compound triggers. >>> \ No newline at end of file >>> +| `Issue #4644 <https://redmine.postgresql.org/issues/4644>`_ - Fix >>> length and precision enable/disable issue when changing the data type for >>> Domain node. >>> \ No newline at end of file >>> diff --git >>> a/web/pgadmin/browser/server_groups/servers/databases/schemas/views/__init__.py >>> b/web/pgadmin/browser/server_groups/servers/databases/schemas/views/__init__.py >>> >>> Looks like some other patch got mixed up. >>> Anyway, I've removed these changes and have attached the updated patch >>> (v4) ready for commit. Everything looks good to me. >>> >> >> Like the editable columns patch, this one no longer applies. >> >> Can we have a rebased version please? >> >> Thanks! >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > *Yosry Muhammad Yosry* > > Computer Engineering student, > The Faculty of Engineering, > Cairo University (2021). > Class representative of CMP 2021. > https://www.linkedin.com/in/yosrym93/ > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
