pgAdmin 4 commit: Ensure long queries don't cause errors when downloadi

2019-02-22 Thread Dave Page
Ensure long queries don't cause errors when downloading CSV in the Query Tool. Fixes #4013 This was actually fixed by #3673 it would appear. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c45675e01943b6125bbca558973bb1ed011ed7f5 Modified Fi

pgAdmin 4 commit: Allow editing of values in columns with the oid datat

2019-02-22 Thread Dave Page
Allow editing of values in columns with the oid datatype which are not an actual row OID. Fixes #3418 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=27d3990ba2fb295c3cb2ba7b0742b35c7b3faa62 Modified Files -- docs/en_US/release_no

pgAdmin 4 commit: Update release notes as the fix for #3583 appears to

2019-02-22 Thread Dave Page
Update release notes as the fix for #3583 appears to have resolved other issues. Fixes #4000 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d326ddd21ad3a4845db94b4b27b3ef8a809757c0 Modified Files -- docs/en_US/release_notes_4_3.r

pgAdmin 4 commit: Update doc colours to more closely match the new UI.

2019-02-22 Thread Dave Page
Update doc colours to more closely match the new UI. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3ad606733a6119df0f6b34aa0e72aaae91a12a69 Modified Files -- docs/en_US/conf.py | 15 +-- 1 file changed, 9 insertions(+)

Re: [pgAdmin4][Patch]: Feature #2418 add rollback and commit action buttons on Query Tool

2019-02-22 Thread Dave Page
Thanks - patch applied (I also did more work on the docs - a number of the buttons on the button bar weren't listed). On Fri, Feb 22, 2019 at 11:03 AM Akshay Joshi wrote: > Hi Dave > > On Thu, Feb 21, 2019 at 8:29 PM Dave Page wrote: > >> Hi >> >> On Thu, Feb 21, 2019 at 12:40 PM Akshay Joshi <

pgAdmin 4 commit: Add Commit and Rollback buttons to the Query Tool. Fi

2019-02-22 Thread Dave Page
Add Commit and Rollback buttons to the Query Tool. Fixes #2418 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=38b034ec3c734090156ad97b10d555e752c7c3f7 Author: Akshay Joshi Modified Files -- docs/en_US/query_tool.rst

[pgAdmin4][RM3600] json values changed when printed by pgadmin4

2019-02-22 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix data alterations done in pgAdmin4 for json datatype. pgAdmin4 will not change json data in any way, and will treat json data as text for data type json. Note that, this is not applicable for jsonb. Also added jsonb editing validation. An enhancement which

Re: [pgAdmin4][Patch]: Feature #2418 add rollback and commit action buttons on Query Tool

2019-02-22 Thread Akshay Joshi
Please ignore my last patch. Attached is the updated patch. Please review it. On Fri, Feb 22, 2019 at 4:33 PM Akshay Joshi wrote: > Hi Dave > > On Thu, Feb 21, 2019 at 8:29 PM Dave Page wrote: > >> Hi >> >> On Thu, Feb 21, 2019 at 12:40 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote:

Re: [pgAdmin4][Patch]: Feature #2418 add rollback and commit action buttons on Query Tool

2019-02-22 Thread Akshay Joshi
Hi Dave On Thu, Feb 21, 2019 at 8:29 PM Dave Page wrote: > Hi > > On Thu, Feb 21, 2019 at 12:40 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the implementation of feature #2418 "add rollback and commit >> action buttons on Query Tool". I have added

pgAdmin 4 commit: Enable/disable the Download button with the Execute b

2019-02-22 Thread Dave Page
Enable/disable the Download button with the Execute button. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0766b17726c262b1787d045224799652e23c239a Modified Files -- web/pgadmin/static/js/sqleditor/execute_query.js | 1 + web/pg