Thanks - patch applied (I also did more work on the docs - a number of the buttons on the button bar weren't listed).
On Fri, Feb 22, 2019 at 11:03 AM Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > On Thu, Feb 21, 2019 at 8:29 PM Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Thu, Feb 21, 2019 at 12:40 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the implementation of feature #2418 "add rollback and commit >>> action buttons on Query Tool". I have added jasmine test cases, modified >>> regression test. I have not added feature test as it is not stable and >>> document is also not updated as we are going to update the new screenshots. >>> >>> Please review it. >>> >> >> I found a few quirks: >> >> - The buttons disable themselves after a short delay when a long running >> query is executed. Shouldn't we just disable them in >> disable_tool_buttons()? >> > > Fixed. We should not disable them in disable_tool_buttons() as > behaviour is different and I don't want to add multiple if else in > disable_tool_buttons(). > >> - The buttons are initially disabled, until a command is run. Shouldn't >> they return to that state after a commit or rollback (whether from a button >> press or typed SQL query)? >> > > Not able to reproduce this issue. I have tried with button press and > keyboard shortcut, it disabled the commit or rollback button. > >> - Please update the docs, even if you don't update the screenshot >> (otherwise we'll forget). >> > > Fixed. > Attached is the modified patch. > >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
