Re: [pgAdmin4][Patch] Grid on the dashboard is not getting refresh after killing the session

++ Gentle reminder On Fri, Jan 18, 2019 at 8:02 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the regression issue where a user kills the session > from the dashboard grid, but the grid was not getting refreshed and the > killed session was no

Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working

Hi Aditya Below are my review comments: - You have added new config parameter "*DISABLE_BEFOREUNLOAD_MESSAGE*" to make this request configurable, should it be the part of preferences setting instead of configuration? @Dave can you please comment on this. - Name "*DISABLE_BEFOREUNLOAD_

Re: [pgAdmin4][patch] Few UI improvements and fixes

Thanks patch applied. On Mon, Jan 21, 2019 at 5:05 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch for below minor fixes: > 1. Proper alignment of help message with date time control > 2. Added help-block class for helpMessageClassName > > Kindl

pgAdmin 4 commit: 1. Proper alignment of help message with date time co

1. Proper alignment of help message with date time control. 2. Added help-block class for helpMessageClassName. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0d2c4536111a08dffbe94941b897c33bf239750 Author: Ganesh Jaybhay Modified Files ---

Re: Remove hacky way to open/close the dropdown-submenu

Hi Ashesh, I am getting a syntax error on bundle. After fixing that, please look into this scenario: Using keyboard shortcuts open object menu, for eg on table node. Go to any submenu using keyboard and go to any submenu and press enter. Now open object menu again using keyboard shortcut, the sub

Re: Remove hacky way to open/close the dropdown-submenu

Any update? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi wrote: > Hi Aditya/Khushboo, > > I ca

pgAdmin 4 commit: Updated Japanese translation.

Updated Japanese translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=407f8855596c780b5246b9ed16d2b2e6799315e2 Author: Nozomi Anzai Modified Files -- .../translations/ja/LC_MESSAGES/messages.mo| Bin 161741 -> 16181

pgAdmin 4 commit: Fixed alignment of tree arrow icons for Internet Expl

Fixed alignment of tree arrow icons for Internet Explorer. Fixes #3871 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6fc2e032f3ed1e166d955af1c3fa4e6f834f7c04 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_

Re: [pgAdmin4][RM3871] Alignment issue with IE Browser

Thanks patch applied. On Mon, Jan 21, 2019 at 4:33 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to fix alignment of tree arrow icons for IE. > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | Enterpr

Re: [pgAdmin4][Patch] - RM 3800 - User can not add database with special characters under DB restriction for add server

Thanks patch applied. On Mon, Jan 21, 2019 at 3:13 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM 3800 - User can not add > database with special characters under DB restriction for add server > > Thanks, > Khushboo > -- *Aksh

pgAdmin 4 commit: Ensure that database restriction of server dialog sho

Ensure that database restriction of server dialog should work with special characters. Fixes #3800 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3ffeb4be457beb44ea086956495bb137a8fc7d2c Author: Khushboo Vashi Modified Files --

[pgAdmin4][patch] Few UI improvements and fixes

Hi Hackers, Attached is the patch for below minor fixes: 1. Proper alignment of help message with date time control 2. Added help-block class for helpMessageClassName Kindly review. Regards, Ganesh Jaybhay fix_help_message.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 3664 - Statistic panel hangs when 1000+ tables

Hi Aditya Can you please review it. On Thu, Jan 17, 2019 at 11:36 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM 3664 - Statistic panel hangs > when 1000+ tables > > The statistics tab hangs with more rows. So, now the rows will

Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields

Hi Aditya Can you please review it. On Mon, Jan 14, 2019 at 4:28 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix #3051 - Tables > Properties > > Columns tab is slow on tables with a lot of fields > > The root cause of the issue is boots

Re: [pgAdmin4][RM3908] backgrid navigation fix for Select2Cell and PrivilegeCell

Hi Khushboo Can you please review it. On Thu, Jan 17, 2019 at 7:22 PM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > Please find attached patch to fix backgrid navigation using keyboard > for Select2Cell and PrivilegeCell > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > >

Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation

Hi Khushboo Can you please review it. On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached updated patch. > In this patch I have fixed two issues: > i. Dialog tab navigation should work even if focus is on footer buttons > (Save

[pgAdmin4][RM3871] Alignment issue with IE Browser

Hi Hackers, Attached is a tiny patch to fix alignment of tree arrow icons for IE. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" RM3871.patch Description: Binary data

Re: [pgAdmin4][RM3840] File Dialog: Retain the File Format Combobox status when toggle the "Show hidden files" checkbox

Thanks patch applied. On Mon, Jan 21, 2019 at 3:24 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to fix a bug where file format combo box value is > not retained when hidden files checkbox is toggled. > > Kindly review. > > -- > Thanks

pgAdmin 4 commit: Ensure that file format combo box value should not re

Ensure that file format combo box value should not retained when hidden files checkbox is toggled. Fixes #3840 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9794d8ab45db83f220a6fa95a08a87e03930d3f Author: Aditya Toshniwal Modified Files -

Re: [pgAdmin4][Patch] - RM 3811 - Backup / restore job launch button needs two click

Thanks patch applied On Mon, Jan 21, 2019 at 2:44 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM 3811 - Backup / restore job > launch button needs two click > > Thanks, > Khushboo > -- *Akshay Joshi* *Sr. Software Architect *

pgAdmin 4 commit: Ensure that Backup/Restore button should work on sing

Ensure that Backup/Restore button should work on single click. Fixes #3811 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aedb3997b05fcd85d055b89cb55ae279937b79ee Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_

[pgAdmin4][RM3840] File Dialog: Retain the File Format Combobox status when toggle the "Show hidden files" checkbox

Hi Hackers, Attached is a tiny patch to fix a bug where file format combo box value is not retained when hidden files checkbox is toggled. Kindly review. -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree"

[pgAdmin4][Patch] - RM 3800 - User can not add database with special characters under DB restriction for add server

Hi, Please find the attached patch to fix the RM 3800 - User can not add database with special characters under DB restriction for add server Thanks, Khushboo RM_3800.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

Hi Khushboo Can you please fix the following and send the patch again - PEP8 issue - Test cases is failing with Python 3.5. On Mon, Jan 21, 2019 at 2:06 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #3853 - Incorrect SQ

[pgAdmin4][Patch] - RM 3811 - Backup / restore job launch button needs two click

Hi, Please find the attached patch to fix the RM 3811 - Backup / restore job launch button needs two click Thanks, Khushboo RM_3811.patch Description: Binary data

pgAdmin 4 commit: Data should be updated properly for FTS Configuration

Data should be updated properly for FTS Configurations, FTS Dictionaries, FTS Parsers and FTS Templates. Fixes #3897 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7cbe0ff4a03d2b076b53dcda6e8dc1632fd3c1f Modified Files -- docs/e

[pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

Hi, Please find the attached patch to fix the RM #3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "[" The patch includes the fix as well as the API test case to verify the reverse Engineered SQL. Thanks, Khushboo RM_3853.p