Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Joao On Tue, 15 May 2018, 19:36 Joao De Almeida Pereira, < jdealmeidapere...@pivotal.io> wrote: > Hi Akshay, > > This patch is flaky; it doesn't always pass the tests in our pipeline. > > == > >

Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree

Hello Ashesh, These are our comments to the patch: - Can you explain the reasoning behind the change you did on the canCreate function? Bind creates a new instance of a function, do we really need that? - isValidTreeNodeData 1. If it is not Null or Undefined it really mean

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

On Tue, 15 May 2018, 19:56 Dave Page, wrote: > > > On Tue, May 15, 2018 at 3:24 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, 15 May 2018, 19:40 Dave Page, wrote: >> >>> >>> >>> On Tue, May 15, 2018 at 1:45 PM, Aditya Toshniwal < >>> aditya.toshni...@enterpris

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

On Tue, May 15, 2018 at 3:24 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Tue, 15 May 2018, 19:40 Dave Page, wrote: > >> >> >> On Tue, May 15, 2018 at 1:45 PM, Aditya Toshniwal > enterprisedb.com> wrote: >> >>> >>> On Tue, May 15, 2018 at 6:05 PM, Dave Page wrote: >>> >>

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

On Tue, 15 May 2018, 19:40 Dave Page, wrote: > > > On Tue, May 15, 2018 at 1:45 PM, Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> >> On Tue, May 15, 2018 at 6:05 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, May 15, 2018 at 1:24 PM, Aditya Toshniwal < >>> aditya.toshni...@

pgAdmin 4 commit: Support running feature tests against Firefox. Fixes

Support running feature tests against Firefox. Fixes #3270 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ccf58570b15b6b5bde750a83582bec5febe9fa18 Author: Akshay Joshi Modified Files -- .gitignore

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

On Tue, May 15, 2018 at 1:45 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > > On Tue, May 15, 2018 at 6:05 PM, Dave Page wrote: > >> Hi >> >> On Tue, May 15, 2018 at 1:24 PM, Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> I suggest chec

Re: [pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Akshay, This patch is flaky; it doesn't always pass the tests in our pipeline. == ERROR: runTest (pgadmin.fe

Re: [pgAdmin4][Patch]: Minor JS Fix

Hi, The code looks fine, all tests pass and linter. Once again, not to sound like a broken record, we could have done some much more to improve our code base Why didn't we extract that function into a more testable place? In order for the code to become more clean and modular, we should try t

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

On Tue, May 15, 2018 at 6:05 PM, Dave Page wrote: > Hi > > On Tue, May 15, 2018 at 1:24 PM, Aditya Toshniwal enterprisedb.com> wrote: > >> Hi Dave, >> >> I suggest check which keyboard you are using, US or UK. If UK, try with >> US keyboard.(might work) >> > > How would that make any difference?

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi On Tue, May 15, 2018 at 1:24 PM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > I suggest check which keyboard you are using, US or UK. If UK, try with US > keyboard.(might work) > How would that make any difference? (and yes, I am using a UK keyboard). > > Than

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi On Tue, May 15, 2018 at 7:05 AM, Akshay Joshi wrote: > Hi Dave > > On Mon, May 14, 2018 at 6:33 PM, Dave Page wrote: > >> >> >> On Mon, May 14, 2018 at 2:03 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Dave >>> >>> On which database server you are running this test c

Re: [pgAdmin4][Patch] Feature #3270 Add support for running regression tests against Firefox

Hi Dave, I suggest check which keyboard you are using, US or UK. If UK, try with US keyboard.(might work) Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Tue, May 15, 2018 at 11:35 AM, Akshay Joshi < aks

[pgAdmin4][Patch] Feature #3204 Notify/Listen not working in version 2.1

Hi Hackers, Attached is the patch to capture the notification from psycopg2 and displayed it in "Messages" tab of query tool. Added feature test to cover this scenario. Refer Notification.png file to how it looks in "Messages" tab. Please review it. -- *Akshay Joshi* *Sr. Software Architect *