On Tue, Mar 13, 2018 at 9:39 AM, Dave Page wrote:
>
>
> On 12 Mar 2018, at 23:12, Khushboo Vashi
> wrote:
>
>
>
> On Tue, Mar 13, 2018 at 2:29 AM, Dave Page wrote:
>
>> So I was trying to test this, and every time I try to run a backup, I'm
>> getting the following, with or without your patch:
On Tue, Mar 13, 2018 at 9:45 AM, Ashesh Vashi wrote:
>
> On Tue, Mar 13, 2018 at 9:42 AM, Murtuza Zabuawala enterprisedb.com> wrote:
>
>> Hi Ashesh,
>>
>> I haven't implemented that intentionally because Khushboo is working on
>> the same for SSL and our code will conflict, So once Khushboo's pa
Hi Dave,
We are not joining template path with os.path.join because we are passing
prefix paths in render_template(..) at many places,
we are passing them as below,
Some of examples,
render_template(
"exclusion_constraint/js/exclusion_constraint.js",
_=_
),
recovery_check_sql = render_t
On Tue, Mar 13, 2018 at 9:42 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Ashesh,
>
> I haven't implemented that intentionally because Khushboo is working on
> the same for SSL and our code will conflict, So once Khushboo's patch gets
> committed, I'll make changes for S
Hi Ashesh,
I haven't implemented that intentionally because Khushboo is working on the
same for SSL and our code will conflict, So once Khushboo's patch gets
committed, I'll make changes for Service file as well.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterpr
> On 12 Mar 2018, at 23:12, Khushboo Vashi
> wrote:
>
>
>
>> On Tue, Mar 13, 2018 at 2:29 AM, Dave Page wrote:
>> So I was trying to test this, and every time I try to run a backup, I'm
>> getting the following, with or without your patch:
>>
>> (sqlite3.ProgrammingError) You must not use
Murtuza/Dave,
I have to reviewed/seen the patch yet.
But - I have a question.
Have we used the service file in the external tools for backup, restore,
and import/export functionalities?
If not - we should fix that asap.
We had missed that during SSL support, and now - we're fixing that.
--
Than
On Tue, Mar 13, 2018 at 2:29 AM, Dave Page wrote:
> So I was trying to test this, and every time I try to run a backup, I'm
> getting the following, with or without your patch:
>
> (sqlite3.ProgrammingError) You must not use 8-bit bytestrings unless you
> use a text_factory that can interpret 8-b
Hi
On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hi Dave and Murtuza,
>
> Regarding this patch we refactored the Javascript code so that is lives in
> a different file and added some tests.
>
> Also we found an issue with karma-jasmine that does
Hi
On Mon, Mar 12, 2018 at 10:15 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to correct the template path generation logic incase of Windows
> system.
>
Seems like it would be better to fix it the other way round to me - e.g.
update the template loader
Hi Dave and Murtuza,
Regarding this patch we refactored the Javascript code so that is lives in
a different file and added some tests.
Also we found an issue with karma-jasmine that does not allow us to use
jasmine 3.1 yet. You can find attached a patch that reverts that commit.
Thanks
Victoria
Hello Murtuza,
Yes I think it makes sense
Thanks
Joao
On Mon, Mar 12, 2018 at 10:40 AM Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Joao,
>
> Can we make tests to skip if db is not greenplum?
> Like we are doing for resource group
> "..web/pgadmin/browser/server_groups/ser
So I was trying to test this, and every time I try to run a backup, I'm
getting the following, with or without your patch:
(sqlite3.ProgrammingError) You must not use 8-bit bytestrings unless you
use a text_factory that can interpret 8-bit bytestrings (like text_factory
= str). It is highly recomm
Add support for connecting using pg_service.conf files. Fixes #3140
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=03b772bf642d2364c3c51226da4b33439107e883
Author: Murtuza Zabuawala
Modified Files
--
docs/en_US/images/server_conn
Thanks, patch applied!
On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Dave,
>
> PFA updated patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Fri, Mar 9, 2018
Hi Joao,
Can we make tests to skip if db is not greenplum?
Like we are doing for resource group
"..web/pgadmin/browser/server_groups/servers/resource_groups/tests".
On Mon, Mar 12, 2018 at 7:52 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Dave,
>
> Joao's patch is pen
Hi Dave,
Joao's patch is pending, would you please do the needful?
I also encounter similar issue on Windows while running tests.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Mar 6, 2018 at 8:25 PM, Joao De Almeida Pereira <
j
Hi,
PFA patch to correct the template path generation logic incase of Windows
system.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
RM_3139.diff
Description: Binary data
On Mon, Mar 12, 2018 at 5:15 PM, Dave Page wrote:
> Hi
>
> On Mon, Mar 12, 2018 at 2:00 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>> Hi Dave,
>>
>> On Fri, Mar 9, 2018 at 9:09 PM, Dave Page wrote:
>>
>>> Hi
>>>
>>> On Fri, Mar 9, 2018 at 3:32 PM, Dave Page wrote:
>>>
>
Hi
On Mon, Mar 12, 2018 at 2:00 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
>
> Hi Dave,
>
> On Fri, Mar 9, 2018 at 9:09 PM, Dave Page wrote:
>
>> Hi
>>
>> On Fri, Mar 9, 2018 at 3:32 PM, Dave Page wrote:
>>
>>> Hi
>>>
>>> On Fri, Mar 9, 2018 at 3:54 AM, Khushboo Vashi <
>>> kh
20 matches
Mail list logo
