On Tue, Mar 13, 2018 at 9:45 AM, Ashesh Vashi <ashesh.va...@enterprisedb.com > wrote:
> > On Tue, Mar 13, 2018 at 9:42 AM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi Ashesh, >> >> I haven't implemented that intentionally because Khushboo is working on >> the same for SSL and our code will conflict, So once Khushboo's patch gets >> committed, I'll make changes for Service file as well. >> > No - that's a bad practice. > You need to work on full feature set, not partial. > > If you have intentionally skipped that, you should have informed the list. > I forgot to create sub-task, will keep that in mind next time onwards. https://redmine.postgresql.org/issues/3195 > > -- Thanks, Ashesh > >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Tue, Mar 13, 2018 at 9:01 AM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> Murtuza/Dave, >>> >>> I have to reviewed/seen the patch yet. >>> But - I have a question. >>> Have we used the service file in the external tools for backup, restore, >>> and import/export functionalities? >>> If not - we should fix that asap. >>> >>> We had missed that during SSL support, and now - we're fixing that. >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> <http://www.enterprisedb.com> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> <http://www.linkedin.com/in/asheshvashi> >>> >>> On Tue, Mar 13, 2018 at 6:18 AM, Dave Page <dp...@pgadmin.org> wrote: >>> >>>> Hi >>>> >>>> On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira < >>>> jdealmeidapere...@pivotal.io> wrote: >>>> >>>>> Hi Dave and Murtuza, >>>>> >>>>> Regarding this patch we refactored the Javascript code so that is >>>>> lives in a different file and added some tests. >>>>> >>>>> Also we found an issue with karma-jasmine that does not allow us to >>>>> use jasmine 3.1 yet. You can find attached a patch that reverts that >>>>> commit. >>>>> >>>> >>>> Sounds good, but neither patch will apply (in fact, the Jasmine one >>>> looks entirely backwards). One of the error messages was changed in >>>> Murtuza's patch, and wasn't reflected in your update for example. >>>> >>>> Can you rebase please? >>>> >>>> Thanks. >>>> >>>> >>>>> >>>>> Thanks >>>>> Victoria && Joao >>>>> >>>>> On Mon, Mar 12, 2018 at 4:46 PM Dave Page <dp...@pgadmin.org> wrote: >>>>> >>>>>> Thanks, patch applied! >>>>>> >>>>>> On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala < >>>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> PFA updated patch. >>>>>>> >>>>>>> -- >>>>>>> Regards, >>>>>>> Murtuza Zabuawala >>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>>> >>>>>>> On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala < >>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Dave, >>>>>>>> >>>>>>>> I'll change the name and send you updated patch. >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <dp...@pgadmin.org> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> HI >>>>>>>>> >>>>>>>>> On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala < >>>>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> PFA patch to add service parameter in server dialog. >>>>>>>>>> - Docs updated >>>>>>>>>> - Test case added for Service ID parameter >>>>>>>>>> >>>>>>>>>> Please note, >>>>>>>>>> I have extracted Connection class and Server manager class from >>>>>>>>>> our own custom Psycopg2 driver module. >>>>>>>>>> >>>>>>>>>> Patch also covers RM#3120 >>>>>>>>>> >>>>>>>>> >>>>>>>>> This patch seems a little confused. The "Service" and "Service >>>>>>>>> ID" fields from pgAdmin 3 are very different things. The Redmine >>>>>>>>> ticket >>>>>>>>> seems to be asking for the Service field (the pg_service.conf service >>>>>>>>> name), *not* Service ID (the operating system's service ID, used to >>>>>>>>> start/stop the database server service). >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> >
