[pgAdmin4][Patch]: RM #2964 - [Desktop Runtime] pgAdmin4 crash if user download query as CVS

2017-12-18 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #2964: [Desktop Runtime] pgAdmin4 crash if user download query as CVS. Patch by Neel Patel. Thanks, Khushboo diff --git a/runtime/BrowserWindow.cpp b/runtime/BrowserWindow.cpp index 2dd5b49..38982c7 100644 --- a/runtime/BrowserWindow.cpp +++ b/ru

Re: Enums printout - possible bug

2017-12-18 Thread Dave Page
Awesome - thanks, applied! On Mon, Dec 18, 2017 at 2:24 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Dec 18, 2017 at 3:13 PM, D

pgAdmin 4 commit: Make the query tool datatype test easily configurable

2017-12-18 Thread Dave Page
Make the query tool datatype test easily configurable and extendable and add support for multi-dimensional arrays and enums. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88bcd3b5129db88975421e26c1bf188daf4892f9 Author: Harshal Dhumal Modi

Jenkins build is back to normal : pgadmin4-master-python33 #424

2017-12-18 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python34 #416

2017-12-18 Thread pgAdmin 4 Jenkins
See

Jenkins build is back to normal : pgadmin4-master-python26 #555

2017-12-18 Thread pgAdmin 4 Jenkins
See

pgAdmin v2.1-dev test builds

2017-12-18 Thread Dave Page
Can be found at https://developer.pgadmin.org/~dpage/2.1-dev/ if anyone wants to play. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Build failed in Jenkins: pgadmin4-master-python33 #423

2017-12-18 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Bump version for some dev builds. [Dave Page] Doc updates for server connection dialogue and related info. [Dave Page] Runtime version update -

pgAdmin 4 commit: Fix duplicate link text

2017-12-18 Thread Dave Page
Fix duplicate link text Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6577723a2a385115515749aefbbb2816f9bff27d Modified Files -- docs/en_US/server_dialog.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Build failed in Jenkins: pgadmin4-master-python34 #415

2017-12-18 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Bump version for some dev builds. [Dave Page] Doc updates for server connection dialogue and related info. -- [...truncated 373.38 KB...

pgAdmin 4 commit: Runtime version update

2017-12-18 Thread Dave Page
Runtime version update Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=005abab7c4ca721dd0abde33ca348afd0e6a8dff Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- 2 files changed, 3 insertions(+), 3 deletio

Build failed in Jenkins: pgadmin4-master-python26 #554

2017-12-18 Thread pgAdmin 4 Jenkins
See Changes: [Dave Page] Bump version for some dev builds. [Dave Page] Doc updates for server connection dialogue and related info. -- [...truncated 378.37 KB...

Re: pgAdmin 4 - Update for Server dialog

2017-12-18 Thread Dave Page
Thanks, patch applied. It's probably worth updating your system to make sure you're running an up to date version of git etc. I'm not sure whether that would require an app store update or update to macports or homebrew - that depends on how your machine was originally setup. You might also want

pgAdmin 4 commit: Doc updates for server connection dialogue and relate

2017-12-18 Thread Dave Page
Doc updates for server connection dialogue and related info. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=10d03078342b9f7c0860bbaf14d6a0ad777f20e5 Author: Susan Douglas Modified Files -- docs/en_US/images/server_advanced.png

pgAdmin 4 commit: Bump version for some dev builds.

2017-12-18 Thread Dave Page
Bump version for some dev builds. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d44328664a556dd7dff0b807444a7eb8f60bc014 Modified Files -- web/config.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

pgAdmin 4 commit: Updated Polish translation from Begina. Extract/updat

2017-12-18 Thread Dave Page
Updated Polish translation from Begina. Extract/update/compile as well for completeness. Current status: 1480 of 1857 messages (79%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po 1692 of 1857 messages (91%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po 1827 of 18

Re: Polish translation update

2017-12-18 Thread Dave Page
Thanks, update applied! On Sun, Dec 17, 2017 at 10:37 PM, Begina Felicysym wrote: > Hello, > > Please find the attached file with polish translation of pgAdmin. > Cheers > > Begina > > > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprise

pgAdmin 4 commit: Allow selection of validation error text. Fixes #2954

2017-12-18 Thread Dave Page
Allow selection of validation error text. Fixes #2954 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3fe655e9444cfb19d9a05c43bc50474381992fbd Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/scss/_alert.scss | 5 +++

Re: [pgAdmin4][Patch]: Allow user to select error text

2017-12-18 Thread Dave Page
Thanks, patch applied. On Thu, Dec 14, 2017 at 12:57 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch which will allow user to select the text from error > message. > RM#2954 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.

Re: [pgAdmin4][Patch]: File manager - Allow user to load the file by double clicking on it

2017-12-18 Thread Dave Page
Thanks, patch applied. On Thu, Dec 14, 2017 at 12:41 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch which will allow user to load the file via file manager by > double clicking on the file just like native file manager. > RM#2810 > > -- > Regards, > Murtuza

pgAdmin 4 commit: Allow files to be opened by double clicking on them.

2017-12-18 Thread Dave Page
Allow files to be opened by double clicking on them. Fixes #2810 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eae6f05b7c1b8e23b1cdc15225900ad713d91129 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/file_manager/st

Re: Enums printout - possible bug

2017-12-18 Thread Dave Page
Hi Looks like there's a TZ issue in the datatype test: == FAIL: runTest (pgadmin.feature_tests.pg_datatype_validation_test.PGDataypeFeatureTest) Test checks for PG data-types output ---

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-18 Thread Murtuza Zabuawala
Sure Dave. On Mon, Dec 18, 2017 at 2:55 PM, Dave Page wrote: > Hi > > I've committed this, but a couple of thoughts that should be > considered/implemented: > > 1) The first button should have focus immediately rather than the text > area. In the debugger at least, there is no real reason to hav

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-18 Thread Dave Page
Hi I've committed this, but a couple of thoughts that should be considered/implemented: 1) The first button should have focus immediately rather than the text area. In the debugger at least, there is no real reason to have the text area get focus by default. 2) If a button gets focus and is push

pgAdmin 4 commit: Add tab indexes for debugger controls.

2017-12-18 Thread Dave Page
Add tab indexes for debugger controls. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36d779df5d70b70f40fe1123eb8457a614edd109 Author: Murtuza Zabuawala Modified Files -- .../tools/debugger/static/js/debugger_ui.js| 37 ++

Re: [pgAdmin4][Patch]: Do not render security URL in templates if running in Desktop mode

2017-12-18 Thread Dave Page
Thanks, applied. On Thu, Dec 14, 2017 at 4:00 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Yes Harshal, you are right but due to RM#2922 changes now runtime is > rendering the Login page. > > @Dave, > Please find updated patch, which will also fix the issue of user login o

pgAdmin 4 commit: Don't try to render security URLs in desktop mode. Fi

2017-12-18 Thread Dave Page
Don't try to render security URLs in desktop mode. Fixes #2952. Fixes #2922 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bceb6aef3cdde642acdf39ddd8abed0634ee1733 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/__init__.