Re: [pgadmin-hackers] Autoformatting

2017-09-12 Thread Murtuza Zabuawala
Hello, Just curious to know if we are still working on this feature? -- Regards, Murtuza On Mon, May 29, 2017 at 5:21 AM, Dave Page wrote: > On Sun, May 28, 2017 at 11:54 AM, Robert Eckhardt > wrote: > > > > > > On Tue, May 9, 2017 at 4:26 AM, Dave Page wrote: > >> > >> > >> Anyhoo, The stan

Re: Fonts for pgAdmin

2017-09-12 Thread Surinder Kumar
Sure. I will send a patch. On Tue, Sep 12, 2017 at 8:21 PM, Dave Page wrote: > Thanks. Whoever picks up this task will need to include that info in the > libraries.txt file so we know exactly what 3rd party stuff is in the tree. > > > On Tue, Sep 12, 2017 at 10:50 AM, Shirley Wang wrote: > >> T

Re: Fonts for pgAdmin

2017-09-12 Thread Dave Page
Thanks. Whoever picks up this task will need to include that info in the libraries.txt file so we know exactly what 3rd party stuff is in the tree. On Tue, Sep 12, 2017 at 10:50 AM, Shirley Wang wrote: > They're from the Google fonts directory : https://fonts.google.com/ > selection?category=Mon

[pgAdmin4][Patch]: Fix regression issues

2017-09-12 Thread Murtuza Zabuawala
Hi, PFA patches, 1) To fix the issue where base types are displaying in create/edit dialog, also corrected the condition to show hidden system types. RM#2692 This issue is regression of commit: Link

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-12 Thread Surinder Kumar
Hi Dave, I had discussed this with Ashesh and according to him, running `yarn run bundle` should always build prod bundle. So, I made changes accordingly. Following changes are made in package.json script commands: 1) Running `yarn run bundle` will build prod bundle. 2) Running `yarn run bundle

Re: Fonts for pgAdmin

2017-09-12 Thread Shirley Wang
They're from the Google fonts directory : https://fonts.google.com/selection?category=Monospace&selection.family=Open+Sans:400,400i,600,700|Source+Code+Pro:400,700 On Tue, Sep 12, 2017 at 4:28 PM Dave Page wrote: > Hi > > On Tue, Sep 12, 2017 at 4:13 AM, Shirley Wang wrote: > >> Hi >> >> Follow

Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

2017-09-12 Thread Dave Page
Hi This is over-complicating things. As I said, we never build packages in dev mode - there's just no need. All we need is easy-to-use Makefile targets that allow us to do either a prod or a dev bundle. The packages should always use prod bundles. I assume with the (to-be-updated) version of thi

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-12 Thread Akshay Joshi
On Tue, Sep 12, 2017 at 2:34 PM, Dave Page wrote: > Adding Akshay... > Sure. > > On Tue, Sep 12, 2017 at 10:04 AM, Dave Page wrote: > >> Akshay, can you review/commit this please? >> >> On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> Hi,

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-12 Thread Dave Page
Adding Akshay... On Tue, Sep 12, 2017 at 10:04 AM, Dave Page wrote: > Akshay, can you review/commit this please? > > On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached patch to represent array data in datagrid with curl

Re: Array representation and save array data from datagrid [RM2671][pgAdmin4]

2017-09-12 Thread Dave Page
Akshay, can you review/commit this please? On Mon, Sep 11, 2017 at 3:40 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch to represent array data in datagrid with curly > braces and > also allow user to save array with values like , , ' > *""*' and

pgAdmin 4 commit: Tag REL-2_0-RC1 has been created.

2017-09-12 Thread Dave Page
Tag REL-2_0-RC1 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-2_0-RC1 Log Message --- Tag 2.0-RC1

Re: Fonts for pgAdmin

2017-09-12 Thread Dave Page
Hi On Tue, Sep 12, 2017 at 4:13 AM, Shirley Wang wrote: > Hi > > Following up on Anthony's comment in another thread, here are the open > source fonts that I used in the test builds. > > I don't have the CSS skills to create a patch for submission, could > someone take the lead and help create t