[pgAdmin4][PATCH] To fix pgAgent job step issues

2017-08-16 Thread Murtuza Zabuawala
Hi, Please find attached patch to fix below given issues from pgAgent Jobs Steps module. 1) 'Connection Type' cell was not honouring to 'Kind' option in Subnode control. 2) Kind option was not saved properly 3) User was not be able to update Kind option in edit mode. RM#2633 -- Regards, Murtuza Z

[pgAdmin4][Patch]: RM_ 2582 - Backup : Fix compression value

2017-08-16 Thread Surinder Kumar
Hi *Issue:* In Backup, compression field can only accept values between 0 to 9. But if the field is clicked, an empty value is set into the model, So, added a check to remove the model attribute if the field is an empty string before data is sent to the server. Please find attached patch. Thanks

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

2017-08-16 Thread Khushboo Vashi
Hi, The patch looks good to me. > Thanks, Khushboo On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng wrote: > >> Hi hackers, >> >> We tried to extract and refactor generate_url function in node.js and >> colle

Re: [pgAdmin4][Patch]: RM_2596 - Query tool not working in Desktop Runtime on Mac OS X

2017-08-16 Thread Surinder Kumar
Hi, Updated patch contains changes: - Enable definePlugin for development environment as well. Just adding definePlugin in plugins array. The variable process.env.NODE_ENV is useful to write conditional code in pgAdmin4 JS modules. For example: if (process.env.NODE_ENV !== 'producti