Re: [pgadmin-hackers][patch] History Detail Pane

On Fri, Jun 23, 2017 at 11:24 AM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > Review comments: > > ​1. ​ > Can we set "message"(in message detail) style property scroll to > ​'​ > auto > ​'​ > instead of > ​'​ > scroll > ​'​ > ? > > ​2. ​ > CSS property flex is supported for

[pgAdmin4][Patch] To fix the issue in Debugger module

Hi, PFA patch to fix the issue in Debugger module where it was unable to start debugging if 'plugin_debugger' can not found in shared_preload_libraries. RM#2162 Original patch by: Kit Yam Tse (who reported the issue) I just re-based it against current c

Re: [pgadmin-hackers][patch] History Detail Pane

Hi Review comments: ​1. ​ Can we set "message"(in message detail) style property scroll to ​'​ auto ​'​ instead of ​'​ scroll ​'​ ? ​2. ​ CSS property flex is supported for IE >= 9 as per reference

[pgAdmin4][Patch] To fix the issue in Column module

Hi, PFA patch to fix the issue in Column module where clearing the length of a character(or any other type as well) generates empty SQL. RM#2155 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company diff --git a/web/pgadmin/browser/server_group

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Thanks, applied. On Thu, Jun 22, 2017 at 2:43 PM, Khushboo Vashi wrote: > Hi Dave, > > One more fix for this module. > > Thanks, > Khushboo > > On Thu, Jun 22, 2017 at 4:49 PM, Dave Page wrote: >> >> Thanks, patch applied. >> >> On Thu, Jun 22, 2017 at 11:06 AM, Khushboo Vashi >> wrote: >> > Hi

pgAdmin 4 commit: Additional preference fix.

Additional preference fix. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=25282f3094a3727fd194420cb77bd65a42838995 Author: Khushboo Vashi Modified Files -- web/pgadmin/static/js/check_node_visibility.js | 2 +- 1 file changed, 1 i

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hi Dave, One more fix for this module. Thanks, Khushboo On Thu, Jun 22, 2017 at 4:49 PM, Dave Page wrote: > Thanks, patch applied. > > On Thu, Jun 22, 2017 at 11:06 AM, Khushboo Vashi > wrote: > > Hi, > > > > Please find the attached fix for the same. > > > > Thanks, > > Khushboo > > > > On T

Jenkins build is back to normal : pgadmin4-master-python36 #190

See

Re: [pgAdmin4][Patch] To fix the in Import/Export module

Thanks, patch applied. On Thu, Jun 22, 2017 at 1:26 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in import/export module where, > 1) Command was failing due to incorrect tab delimiter passed to the copy > command. > 2) User was not allowed to pass default delimiter(ie - no de

pgAdmin 4 commit: Fix import/export to work as expected with TSV data.

Fix import/export to work as expected with TSV data. Fixes #1934 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0ab637c7ab9dd7b23692dd2b6eda3b983fa7780f Author: Murtuza Zabuawala Modified Files -- .../tools/import_export/template

[pgAdmin4][Patch] To fix the in Import/Export module

Hi, PFA patch to fix the issue in import/export module where, 1) Command was failing due to incorrect tab delimiter passed to the copy command. 2) User was not allowed to pass default delimiter(ie - no delimiter, let copy command handle it) for csv & text file format user was forced to select deli

Re: [pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

Hi On Thu, Jun 22, 2017 at 11:05 AM, Atul Sharma wrote: > Hi, > > Please find attached patch for RM #2191 : Add support for hostaddr > connection parameter Unfortunately there are a few issues with this patch: - It needs rebasing (blame Ashesh :-p ) - It's missing the documentation update (and

Build failed in Jenkins: pgadmin4-master-python36 #189

See Changes: [Dave Page] Ensure default values are honoured when adding/editing columns. Fixes [Dave Page] Fix preferences handling for utilities. -- [...trunca

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Thanks, patch applied. On Thu, Jun 22, 2017 at 11:06 AM, Khushboo Vashi wrote: > Hi, > > Please find the attached fix for the same. > > Thanks, > Khushboo > > On Thu, Jun 22, 2017 at 2:18 PM, Dave Page wrote: >> >> Hmm, yes - and it's not giving the normal error instructing the user >> to set th

pgAdmin 4 commit: Fix preferences handling for utilities.

Fix preferences handling for utilities. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33e75d24f82828c6925b88fecf0eac35a8480bbd Author: Khushboo Vashi Modified Files -- web/pgadmin/preferences/__init__.py | 2 +- web/pgadmin/utils

Jenkins build is back to normal : pgadmin4-master-python35 #187

See

Re: [pgAdmin4][PATCH] To fix the issue in column module

Thanks, applied. On Thu, Jun 22, 2017 at 8:14 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where in column node we were not displaying > column's default value properly, for example if the default value is zero. > RM#1860 > > I have also fixed similar issue in foreign table m

pgAdmin 4 commit: Ensure default values are honoured when adding/editin

Ensure default values are honoured when adding/editing columns. Fixes #1860 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=137bae1b0494a7c763d302f5f5e652e5201abdea Author: Murtuza Zabuawala Modified Files -- .../foreign_tables/te

Build failed in Jenkins: pgadmin4-master-python36 #188

See Changes: [Ashesh Vashi] Moved the javascripts of the following browser node modules to the -- [...truncated 288.97 KB...] Update materialized view under sche

pgAdmin 4 commit: Moved the javascripts of the following browser node m

Moved the javascripts of the following browser node modules to the 'static' directory from 'templates' in the respective module directory: - Server Group - Server - Database - Schema - Cast - Event trigger - Extension - Foreign data wrapper - Language - Catalog Object - Collation - Domain Constrain

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hi, Please find the attached fix for the same. Thanks, Khushboo On Thu, Jun 22, 2017 at 2:18 PM, Dave Page wrote: > Hmm, yes - and it's not giving the normal error instructing the user > to set the path, but another one: "Failed to load preference > pg_bin_dir of module paths". > > Khushboo, c

[pgAdmin4][Patch][RM_2191] : Add support for the hostaddr connection parameter

Hi, Please find attached patch for RM #2191 : Add support for hostaddr connection parameter Thanks, Atul RM_2191.patch Description: Binary data

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hmm, yes - and it's not giving the normal error instructing the user to set the path, but another one: "Failed to load preference pg_bin_dir of module paths". Khushboo, can you investigate and fix ASAP please? On Thu, Jun 22, 2017 at 9:31 AM, Murtuza Zabuawala wrote: > Hi Khusboo, > > Looks like

Re: [pgAdmin4][Patch]: Fixed #2487: get_preference() uses a synchronous AJAX request

Hi Khusboo, Looks like given change have broken Backup, Restore, Import/Export & Maintenance, even if I have binary path set it is throwing an error. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Jun 21, 2017 at 9:40 PM, Dave Pa

Re: [pgadmin-hackers] [Design update] Style guide for pgAdmin4

Looks nice. On Wed, Jun 21, 2017 at 10:34 PM, Shirley Wang wrote: > Hi all, > > We've updated the borders around alerts so that they are more prominent. > > [image: error alert (1).png] > [image: success alert (2).png] > [image: Neutral alert.png] > Everything else stays the same. Let me know yo

[pgAdmin4][PATCH] To fix the issue in column module

Hi, PFA patch to fix the issue where in column node we were not displaying column's default value properly, for example if the default value is zero. RM#1860 I have also fixed similar issue in foreign table module. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprise