[perl #54992] [CAGE] Add a 'codetest' make target

2008-06-02 Thread James Keenan via RT
No complaints, so I'm resolving the ticket. As a reminder, once you have run Configure.pl, you can now call: make codetest or perl t/harness --code-tests

[perl #54992] [CAGE] Add a 'codetest' make target

2008-06-01 Thread James Keenan via RT
Changed in r28017 to 'make codetest'.

Re: [perl #54992] [CAGE] Add a 'codetest' make target

2008-06-01 Thread Patrick R. Michaud
On Sun, Jun 01, 2008 at 05:41:46AM -0700, James Keenan via RT wrote: > > Since the other tests are specified using "-tests" in the option > > name, perhaps we should have "--code-tests" instead of just "--code"? > > (c.f. --core-tests and --runcore-tests). > > Okay. But to extend the consistency

[perl #54992] [CAGE] Add a 'codetest' make target

2008-06-01 Thread James Keenan via RT
Applied to trunk in r28007. After configuring, you should now be able to say either: make code_tests or perl t/harness --code-tests kid51

[perl #54992] [CAGE] Add a 'codetest' make target

2008-06-01 Thread James Keenan via RT
On Sat May 31 23:52:19 2008, pmichaud wrote: > On Sat, May 31, 2008 at 05:54:31AM -0700, James Keenan via RT wrote: > > Please review the patch attached, which implements your suggestion. > > The patch looks good to me; I just have a couple of questions > and/or observations: > > > Since the ot

Re: [perl #54992] [CAGE] Add a 'codetest' make target

2008-05-31 Thread Patrick R. Michaud
On Sat, May 31, 2008 at 05:54:31AM -0700, James Keenan via RT wrote: > Please review the patch attached, which implements your suggestion. The patch looks good to me; I just have a couple of questions and/or observations: > Index: lib/Parrot/Harness/Options.pm >

[perl #54992] [CAGE] Add a 'codetest' make target

2008-05-31 Thread James Keenan via RT
Please review the patch attached, which implements your suggestion. But note that while I have removed $(PARROT_ARGS) from config/gen/makefiles/root.in, I have left it untouched in these other files where it is found: ./tools/dev/mk_language_shell.pl ./config/gen/makefiles/nqp.in ./languages/perl

Re: [perl #54992] [CAGE] Add a 'codetest' make target

2008-05-30 Thread Patrick R. Michaud
On Fri, May 30, 2008 at 08:51:45AM -0400, Andy Dougherty wrote: > On Fri, 30 May 2008, James Keenan via RT wrote: > > > That will probably be possible. But as I was staring at > > config/gen/makefiles/root.in, I couldn't figure out where $(PARROT_ARGS) > > is originally defined in line such as th

Re: [perl #54992] [CAGE] Add a 'codetest' make target

2008-05-30 Thread Andy Dougherty
On Fri, 30 May 2008, James Keenan via RT wrote: > That will probably be possible. But as I was staring at > config/gen/makefiles/root.in, I couldn't figure out where $(PARROT_ARGS) > is originally defined in line such as this: > > test : test_prep > $(PERL) t/harness $(EXTRA_TEST_ARGS) $(PAR

[perl #54992] [CAGE] Add a 'codetest' make target

2008-05-30 Thread James Keenan via RT
On Thu May 29 19:35:06 2008, pmichaud wrote: > Thanks for working on this ticket, I really appreciate it -- it > should improve things for Rakudo development quite a bit. > > I wonder if it would be possible (or wiser) to implement this > via another option to t/harness instead of adding yet ano

Re: [perl #54992] [CAGE] Add a 'codetest' make target

2008-05-29 Thread Patrick R. Michaud
On Wed, May 28, 2008 at 07:26:29PM -0700, James Keenan via RT wrote: > On Wed May 28 18:57:31 2008, [EMAIL PROTECTED] wrote: > > I will work on this. Attached is *part* of the solution. > > > > > > And here is a more complete solution. (In the course of its > development, I ran it and it identi

[perl #54992] [CAGE] Add a 'codetest' make target

2008-05-28 Thread James Keenan via RT
> And here is a more complete solution. This lists the tests included in this target. $ make codetest /usr/local/bin/perl t/run_code_tests t/distro/file_metadata...# Collecting svn:mime-type attributes... t/distro/file_metadata...1/5 # Collecting svn:keywords attributes... t/di

[perl #54992] [CAGE] Add a 'codetest' make target

2008-05-28 Thread James Keenan via RT
On Wed May 28 18:57:31 2008, [EMAIL PROTECTED] wrote: > I will work on this. Attached is *part* of the solution. > > And here is a more complete solution. (In the course of its development, I ran it and it identified 3 coding standards problems which I then fixed. So it must be doing something

[perl #54992] [CAGE] Add a 'codetest' make target

2008-05-28 Thread James Keenan via RT
I will work on this. Attached is *part* of the solution. kid51 run_code_tests Description: Binary data

[perl #54992] [CAGE] Add a 'codetest' make target

2008-05-28 Thread via RT
# New Ticket Created by Will Coleda # Please include the string: [perl #54992] # in the subject line of all future correspondence about this issue. # http://rt.perl.org/rt3/Ticket/Display.html?id=54992 > For developers working in languages that want to play nice with the repository, it would