[perl #47011] [DEPRECATED] VTABLE entry 'new_from_string'

2008-04-15 Thread Mark Glines via RT
On Fri Apr 04 10:50:53 2008, pmichaud wrote: > On Fri, Apr 04, 2008 at 10:06:39AM -0700, chromatic wrote: > > Using CONST_STRING to build the null STRING will hurt performance > less, but > > the right solution is to excise all traces of new_from_string() > throughout > > the system, and then compl

Re: [perl #47011] [DEPRECATED] VTABLE entry 'new_from_string'

2007-12-04 Thread Allison Randal
Francois PERRAD wrote: 'new_from_string' is widely used by .const, for example : .const .String key_print = "print" That's the one case I consider a valid use of 'new_from_string', actually creating a string constant during initialization. Other hackery has been piled on top of the featu

Re: [perl #47011] [DEPRECATED] VTABLE entry 'new_from_string'

2007-12-04 Thread Allison Randal
Kevin Tew wrote: The logic was present in FIA, before PCC was written. It was reused in an attempt to "don't repeat yourself". Probably would be better as a literal key than a string that has to be parsed. Allison

Re: [perl #47011] [DEPRECATED] VTABLE entry 'new_from_string'

2007-12-03 Thread Francois PERRAD
Will Coleda via RT wrote: On Mon Oct 29 11:11:03 2007, bernhard wrote: In pdd17_pmc.pod it is stated that 'new_from_string' is deprecated. The existing use of 'new_from_string' can probably be achieved with 'init' or 'set_string_native'. TODO: Hunt down existing use of 'new_i_s' and either re

Re: [perl #47011] [DEPRECATED] VTABLE entry 'new_from_string'

2007-12-03 Thread Kevin Tew
The logic was present in FIA, before PCC was written. It was reused in an attempt to "don't repeat yourself". Kevin Allison Randal wrote: jerry gay wrote: careful... one of these PMCs is FixedIntegerArray. FIA is used to set the flags for parrot calling conventions, so it's constructed every

Re: [perl #47011] [DEPRECATED] VTABLE entry 'new_from_string'

2007-12-03 Thread Allison Randal
jerry gay wrote: careful... one of these PMCs is FixedIntegerArray. FIA is used to set the flags for parrot calling conventions, so it's constructed every time a subroutine is entered or exited. i'd prefer to see new_from_string go away, but it seems to me benchmarks are in order due to the amo

Re: [perl #47011] [DEPRECATED] VTABLE entry 'new_from_string'

2007-12-03 Thread jerry gay
On Dec 3, 2007 11:25 AM, Allison Randal <[EMAIL PROTECTED]> wrote: > Creating a hash is expensive, but then new_from_string was also quite > rare (only implemented on 4 PMCs), so isn't a huge target for optimization. > careful... one of these PMCs is FixedIntegerArray. FIA is used to set the flags

Re: [perl #47011] [DEPRECATED] VTABLE entry 'new_from_string'

2007-12-03 Thread Allison Randal
Will Coleda via RT wrote: Hunt down existing use of 'new_i_s' and either replace or remove the functionality. The FixedIntegerArray is an example of where 'new_from_string' is used. 'new_i_s' was experimental and can die. Any PMC's using the behavior can instead pass a hash argument to 'new'.

[perl #47011] [DEPRECATED] VTABLE entry 'new_from_string'

2007-11-28 Thread Will Coleda via RT
On Mon Oct 29 11:11:03 2007, bernhard wrote: > In pdd17_pmc.pod it is stated that 'new_from_string' is deprecated. > The existing use of 'new_from_string' can probably be achieved with > 'init' or > 'set_string_native'. > > TODO: > Hunt down existing use of 'new_i_s' and either replace or remove