The logic was present in FIA, before PCC was written.
It was reused in an attempt to "don't repeat yourself".
Kevin
Allison Randal wrote:
jerry gay wrote:
careful... one of these PMCs is FixedIntegerArray. FIA is used to set
the flags for parrot calling conventions, so it's constructed every
time a subroutine is entered or exited. i'd prefer to see
new_from_string go away, but it seems to me benchmarks are in order
due to the amount of times this code is likely to be called in a
typical program.
Which raises the usual sort of questions:
- Is FIA the best possible implementation solution for PCC flags?
- Does that logic, parsing the signature string, really belong in the
FIA PMC? It is specific to PCC, and would seem more appropriate as a
routine someplace like src/inter_call.c. (That's true even if it
ultimately creates a FIA.)
Allison
