Re: [perl #30395] [PATCH] win32 stat.h

2004-06-22 Thread Dan Sugalski
On Tue, 22 Jun 2004, Leopold Toetsch wrote: > Andy Dougherty <[EMAIL PROTECTED]> wrote: > > > For this case, I don't know if it matters much -- I don't know if there > > are other platforms that don't define those macros -- but the general > > principle of testing for features, not for platforms,

Re: [perl #30395] [PATCH] win32 stat.h

2004-06-22 Thread Leopold Toetsch
Andy Dougherty <[EMAIL PROTECTED]> wrote: > For this case, I don't know if it matters much -- I don't know if there > are other platforms that don't define those macros -- but the general > principle of testing for features, not for platforms, is a good one and I > like to jump up on my soapbox an

Re: [perl #30395] [PATCH] win32 stat.h

2004-06-22 Thread Andy Dougherty
On Tue, 22 Jun 2004, Leopold Toetsch wrote: > Dennis Rieks <[EMAIL PROTECTED]> wrote: > > > add this lines to config/gen/platform/generic/stat.h > > > I think that no win32/stat.[c|h] file is needed, > > I checked it in as config/gen/platform/win32/stat.h, which then gets > included for win32. I'd

Re: [perl #30395] [PATCH] win32 stat.h

2004-06-22 Thread Leopold Toetsch
Dennis Rieks <[EMAIL PROTECTED]> wrote: > add this lines to config/gen/platform/generic/stat.h > I think that no win32/stat.[c|h] file is needed, I checked it in as config/gen/platform/win32/stat.h, which then gets included for win32. I'd like to keep things separate. leo

Re: [perl #30395] [PATCH] win32 stat.h

2004-06-21 Thread Dennis Rieks
Oops, little copy&paste mistake, just ignore the first #ifndef S_IFMT block ;-) Dennis -- Dennis Rieks [EMAIL PROTECTED]

[perl #30395] [PATCH] win32 stat.h

2004-06-21 Thread via RT
# New Ticket Created by Dennis Rieks # Please include the string: [perl #30395] # in the subject line of all future correspondence about this issue. # http://rt.perl.org:80/rt3/Ticket/Display.html?id=30395 > Hi, add this lines to config/gen/platform/generic/stat.h I think that no win32/stat