On Tue, 22 Jun 2004, Leopold Toetsch wrote:
> Dennis Rieks <[EMAIL PROTECTED]> wrote:
>
> > add this lines to config/gen/platform/generic/stat.h
>
> > I think that no win32/stat.[c|h] file is needed,
>
> I checked it in as config/gen/platform/win32/stat.h, which then gets
> included for win32. I'd like to keep things separate.
It's a minor thing, but I wouldn't think of this as separate. Or, more
accurately, I wouldn't think of it as win32-platform-specific. It came
(ultimately) from perl4's perl.h file, where it was written to supply the
S_IS* macros on any system where they weren't already supplied. There
were, at the time, a number of such Unix-ish systems.
Because the fix was put in a generic file that tested for the specific
needed feature, and not for one of the problematic platforms, it also
"just worked" when win32 cam along, and will probably "just work" anywhere
else that doesn't implement the S_IS* macros.
For this case, I don't know if it matters much -- I don't know if there
are other platforms that don't define those macros -- but the general
principle of testing for features, not for platforms, is a good one and I
like to jump up on my soapbox and ramble on about it at every
opportunity :-).
--
Andy Dougherty [EMAIL PROTECTED]
