On Friday 02 November 2007 18:29:23 James Keenan via RT wrote:
> c: Could I ask you to post the error messages you got when this test
> failed? Before submitting/committing patches, I ran this test file many
> times in its original version on both Darwin and Linux and it never
> failed for me.
As part of a patch in RT 47127, Cosimo Streppone caught 2 errors in
auto::gdbm. Patch applied in r22668.
I am immediately accepting and applying your correction to
config/auto/gdbm.pm, which was included in the patch. You managed to
find mistakes made by both myself and the other chief Cage Cleaner!
[li11-226:parrot] 571 $ svn diff config/auto/gdbm.pm
Index: config/auto/gdbm.pm
===
Cosimo Streppone wrote:
# New Ticket Created by Cosimo Streppone
# Please include the string: [perl #47127]
# in the subject line of all future correspondence about this issue.
# http://rt.perl.org/rt3/Ticket/Display.html?id=47127 >
Hi,
I'm trying to get my feet wet with parrot.
Welcome!
Patch attached supplies slight refactoring of configuration step class
auto::alignptrs and 5 test files. Will apply in 2-3 days if there is no
objection. Thank you very much.
kid51
Index: MANIFEST
===
--- MANIFEST(revision 22667
Bug corrected in r22667.
[parrot] 507 $ svn diff config/auto/alignptrs.pm
Index: config/auto/alignptrs.pm
===
--- config/auto/alignptrs.pm (revision 22664)
+++ config/auto/alignptrs.pm (working copy)
@@ -50,7 +50,7 @@
# HP-UX 10.20/32
On Fri Nov 02 19:57:09 2007, [EMAIL PROTECTED] wrote:
> Bug corrected in r22667.
This was applied to the wrong ticket. Sorry!
Bug corrected in r22667.
[parrot] 507 $ svn diff config/auto/alignptrs.pm
Index: config/auto/alignptrs.pm
===
--- config/auto/alignptrs.pm(revision 22664)
+++ config/auto/alignptrs.pm(working copy)
@@ -50,7 +50,7 @@
#
Here's an additional problem I noticed with auto::msvc. During coverage
analysis, there were several lines of code that I was never able to
cover successfully (see:
http://thenceforward.net/parrot/coverage/configure-build/config-auto-msvc-pm.html).
unless ( defined $msvcref->{_MSC_VER} ) {
On Tue Oct 30 19:19:42 2007, [EMAIL PROTECTED] wrote:
> The refactored auto::msvc and associated tests were committed to trunk
> tonight as part of r22629. Resolving ticket.
Am reopening ticket. Subsequent to the above, chromatic patched one of
the 3 test files as follows:
-
From: Allison Randal <[EMAIL PROTECTED]>
Date: Fri, 02 Nov 2007 15:24:40 -0400
Bob Rogers wrote:
>From re-reviewing our earlier correspondence, I get the impression
> that you have a particular implementation in mind, one which doesn't
> seem to work for my use case. Perhap
# New Ticket Created by Cosimo Streppone
# Please include the string: [perl #47127]
# in the subject line of all future correspondence about this issue.
# http://rt.perl.org/rt3/Ticket/Display.html?id=47127 >
Hi,
I'm trying to get my feet wet with parrot.
Just found out this test failure.
Af
Patches applied to trunk Nov 02 2007 in r22665.
François PERRAD wrote:
just few comments about pdd19 :
1) Directive .namespace
.namespace
is currently valid, and I understand its behavior as : back to the default
It's in the docs for IMCC (docs/imcc/calling_conventions.pod), but not
in the calling conventions or namespaces PDDs. It c
Klaas-Jan Stol wrote:
PDD19 states that labels are not allowed for directives, which in
practice means, that the following is not allowed:
foo: .local int i
It would be useful to add some rationale about this in the PDD, if it
is really necessary; why is this limitation?
Labels are convention
Author: allison
Date: Fri Nov 2 13:08:04 2007
New Revision: 22664
Modified:
trunk/docs/pdds/draft/pdd19_pir.pod
Log:
[pdd] Relax restriction on labels in PIR PDD.
Modified: trunk/docs/pdds/draft/pdd19_pir.pod
==
---
Author: allison
Date: Fri Nov 2 12:49:29 2007
New Revision: 22663
Modified:
trunk/docs/pdds/pdd23_exceptions.pod
Log:
[pdd] Change a heading in exceptions PDD.
Modified: trunk/docs/pdds/pdd23_exceptions.pod
==
--- t
Bob Rogers wrote:
From re-reviewing our earlier correspondence, I get the impression
that you have a particular implementation in mind, one which doesn't
seem to work for my use case. Perhaps you should describe the use case
for your implementation, and then we can decide whether to combine
PDD19 states that labels are not allowed for directives, which in
practice means, that the following is not allowed:
foo: .local int i
It would be useful to add some rationale about this in the PDD, if it
is really necessary; why is this limitation?
I assume this limitation would then also go fo
Paul Cochrane wrote:
On 30/10/2007, jerry gay <[EMAIL PROTECTED]> wrote:
it's probably time
to change all the 'foo = (type)-1' to 'foo = MAXTYPE' to reduce the
magic number count in the source, and make the intent of the code more
clear.
I agree with this sentiment most definitely. Clarity is
Author: allison
Date: Fri Nov 2 08:49:36 2007
New Revision: 22658
Modified:
trunk/docs/pdds/draft/pdd19_pir.pod
Log:
[pdd] Applying text clarification patch from Klaas-Jan Stol.
Modified: trunk/docs/pdds/draft/pdd19_pir.pod
===
# New Ticket Created by Jerry Gay
# Please include the string: [perl #47109]
# in the subject line of all future correspondence about this issue.
# http://rt.perl.org/rt3/Ticket/Display.html?id=47109 >
as per PDD07 (r22655,) c macro args *must* be wrapped in parens inside
macro bodies, to all
Author: particle
Date: Fri Nov 2 07:40:27 2007
New Revision: 22655
Modified:
trunk/docs/pdds/pdd07_codingstd.pod
Log:
[PDD07]: protecting expressions in macros by wrapping macro arguments in parens
Modified: trunk/docs/pdds/pdd07_codingstd.pod
Author: allison
Date: Fri Nov 2 07:30:50 2007
New Revision: 22654
Modified:
trunk/docs/pdds/pdd23_exceptions.pod
Log:
[pdd] Pushing the exceptions PDD to be more in line with the PMC PDD.
Modified: trunk/docs/pdds/pdd23_exceptions.pod
24 matches
Mail list logo
