On Tue Oct 30 19:19:42 2007, [EMAIL PROTECTED] wrote:
> The refactored auto::msvc and associated tests were committed to trunk
> tonight as part of r22629. Resolving ticket.
Am reopening ticket. Subsequent to the above, chromatic patched one of
the 3 test files as follows:
------------------------------------------------------------------------
r22632 | chromatic | 2007-10-30 23:46:54 -0400 (Tue, 30 Oct 2007) | 5 lines
[t] Skip the MSVC configuration test on non-Windows platforms (it fails
for me during linking when trying to link against libgdbm, which I don't
have installed). The test probably shouldn't pass anyway, because I'm
not running Windows.
Index: t/configure/113-auto_msvc-01.t
===================================================================
--- t/configure/113-auto_msvc-01.t (revision 22629)
+++ t/configure/113-auto_msvc-01.t (revision 22666)
@@ -5,11 +5,16 @@
use strict;
use warnings;
-use Test::More qw(no_plan); # tests => 11;
+use Test::More;
use Carp;
use lib qw( lib t/configure/testlib );
+
+plan( skip_all => 'MSVC is Windows only' ) unless $^O =~ /Win32/;
+plan('no_plan'); # tests => 11;
+
use_ok('config::init::defaults');
use_ok('config::auto::msvc');
+
c: Could I ask you to post the error messages you got when this test
failed? Before submitting/committing patches, I ran this test file many
times in its original version on both Darwin and Linux and it never
failed for me.
Nor would I have expected it to fail. Since it executes
auto::msvc::runstep(), it does exactly what happens every time you say
'perl Configure.pl'. The fact that runstep() returns true -- which is
what the next-to-last test in the file tests for -- only indicates that
the process of determining "if your C compiler is actually Visual C++"
(as $description reads) completed successfully or not. If you're not on
Windows, the step's 'result' value should be 'undef', as should the
'msvcversion' element in the Parrot::Configure object -- but runstep()
itself should return true and 113-auto_msvc-01.t should pass all its tests.
This leads me to suspect that something else was causing this file to
fail for you, and to believe that we should revert to the original
version of 113-auto_msvc-01.t (perhaps augmented by some tests for
'result' and 'msvcversion'). Hence, the request for the failure report.
Thank you very much.
kid51
