Re: [Pacemaker] patch for rsc_order loops.

2009-12-10 Thread Frank DiMeo
And I see it's in the repo already :) -Frank > -Original Message- > From: Andrew Beekhof [mailto:and...@beekhof.net] > Sent: Thursday, December 10, 2009 6:30 AM > To: Frank DiMeo > Cc: pacemaker@oss.clusterlabs.org > Subject: Re: patch for rsc_order loops. > > I found a simpler fix :-) >

Re: [Pacemaker] patch for rsc_order loops.

2009-12-10 Thread Andrew Beekhof
I found a simpler fix :-) diff -r 4582140c2f1b pengine/constraints.c --- a/pengine/constraints.c Thu Dec 10 10:54:03 2009 +0100 +++ b/pengine/constraints.c Thu Dec 10 12:29:05 2009 +0100 @@ -739,6 +739,7 @@ unpack_order_set(xmlNode *set, int score goto done; } +last = NUL

Re: [Pacemaker] patch for rsc_order loops.

2009-12-10 Thread Andrew Beekhof
On Tue, Dec 8, 2009 at 2:28 PM, Frank DiMeo wrote: > I'm not sure what criteria you usually use for your test cases. The bz2 input files. I'll go extract them from the other mail. > I ran my 2 and 4 resource case through this code and they both worked, and I >generated the flow diagrams using p

Re: [Pacemaker] patch for rsc_order loops.

2009-12-08 Thread Frank DiMeo
I'm not sure what criteria you usually use for your test cases. I ran my 2 and 4 resource case through this code and they both worked, and I generated the flow diagrams using ptest and it shows no loops. -Frank > -Original Message- > From: Andrew Beekhof [mailto:and...@beekhof.net] > S

Re: [Pacemaker] patch for rsc_order loops.

2009-12-08 Thread Andrew Beekhof
On Mon, Dec 7, 2009 at 8:19 PM, Frank DiMeo wrote: > I’ve enclosed at mercurial patch for what I believe is a fix for the > resource ordering loop creation that I’ve been chasing.  Please look it over > and if you approve, I can submit it. Do you have a test case for this? __

Re: [Pacemaker] patch for rsc_order loops.

2009-12-07 Thread Frank DiMeo
nk.di...@bigbandnet.com] Sent: Monday, December 07, 2009 5:03 PM To: pacemaker@oss.clusterlabs.org Subject: Re: [Pacemaker] patch for rsc_order loops. Actually, now that I look at it more closely, that a corosync file. Maybe I need to update my corosync source? -Frank From: Frank DiMeo [mailto:fra

Re: [Pacemaker] patch for rsc_order loops.

2009-12-07 Thread Frank DiMeo
07, 2009 2:19 PM To: Andrew Beekhof Cc: pacemaker@oss.clusterlabs.org Subject: [Pacemaker] patch for rsc_order loops. I've enclosed at mercurial patch for what I believe is a fix for the resource ordering loop creation that I've been chasing. Please look it over and if you approv

Re: [Pacemaker] patch for rsc_order loops.

2009-12-07 Thread Frank DiMeo
o: Andrew Beekhof Cc: pacemaker@oss.clusterlabs.org Subject: [Pacemaker] patch for rsc_order loops. I've enclosed at mercurial patch for what I believe is a fix for the resource ordering loop creation that I've been chasing. Please look it over and if you approv

[Pacemaker] patch for rsc_order loops.

2009-12-07 Thread Frank DiMeo
I've enclosed at mercurial patch for what I believe is a fix for the resource ordering loop creation that I've been chasing. Please look it over and if you approve, I can submit it. -Frank rsc_order_loop_patch Description: rsc_order_loop_patch _