I found a simpler fix :-) diff -r 4582140c2f1b pengine/constraints.c --- a/pengine/constraints.c Thu Dec 10 10:54:03 2009 +0100 +++ b/pengine/constraints.c Thu Dec 10 12:29:05 2009 +0100 @@ -739,6 +739,7 @@ unpack_order_set(xmlNode *set, int score goto done; }
+ last = NULL; local_score *= -1; action = invert_action(action); On Thu, Dec 10, 2009 at 12:19 PM, Andrew Beekhof <and...@beekhof.net> wrote: > On Tue, Dec 8, 2009 at 2:28 PM, Frank DiMeo <frank.di...@bigbandnet.com> > wrote: >> I'm not sure what criteria you usually use for your test cases. > > The bz2 input files. > I'll go extract them from the other mail. > >> I ran my 2 and 4 resource case through this code and they both worked, and I >>generated the flow diagrams using ptest and it shows no loops. >> >> -Frank >> >>> -----Original Message----- >>> From: Andrew Beekhof [mailto:and...@beekhof.net] >>> Sent: Tuesday, December 08, 2009 3:10 AM >>> To: Frank DiMeo >>> Cc: pacemaker@oss.clusterlabs.org >>> Subject: Re: patch for rsc_order loops. >>> >>> On Mon, Dec 7, 2009 at 8:19 PM, Frank DiMeo >>> <frank.di...@bigbandnet.com> wrote: >>> > I've enclosed at mercurial patch for what I believe is a fix for the >>> > resource ordering loop creation that I've been chasing. Please look >>> it over >>> > and if you approve, I can submit it. >>> >>> Do you have a test case for this? >> > _______________________________________________ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker