[PATCH v2 05/10] base-files: upgrade: fwtool.sh: rewording logs

2020-11-09 Thread Yousong Zhou
The intent is to make it sound more like info level message, not some error like "404 not found". x86 target at the moment makes image with only signature but no metadata (ref commit f8141216 "x86: append metadata to combined images"). Signed-off-by: Yousong Zhou --- pack

[PATCH v2 01/10] base-files: upgrade: log with date prefix

2020-11-09 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- package/base-files/files/lib/upgrade/common.sh | 2 +- package/base-files/files/lib/upgrade/stage2| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package/base-files/files/lib/upgrade/common.sh b/package/base-files/files/lib/upgrade

[PATCH v2 03/10] base-files: upgrade: add get_image_dd()

2020-11-09 Thread Yousong Zhou
This is mainly to handle stderr message "Broken pipe", "F+P records in/out" by common pattern "xcat | dd .." Ref: https://bugs.openwrt.org/index.php?do=details&task_id=3140 Reported-by: Philip Prindeville Signed-off-by: Yousong Zhou --- package/base-fil

[PATCH v2 02/10] base-files: upgrade: use stdin redirection to replace cat command

2020-11-09 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- package/base-files/files/lib/upgrade/common.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/base-files/files/lib/upgrade/common.sh b/package/base-files/files/lib/upgrade/common.sh index c4947e4624..e12dfc9678 100644 --- a/package

[PATCH v2 08/10] x86: upgrade: use v function for writting logs

2020-11-09 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- .../linux/x86/base-files/lib/upgrade/platform.sh | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/linux/x86/base-files/lib/upgrade/platform.sh b/target/linux/x86/base-files/lib/upgrade/platform.sh index 1bcd492dd7

[PATCH v2 04/10] base-files: upgrade: fwtool.sh: use v for log lines

2020-11-09 Thread Yousong Zhou
This will have at least the following effects - Log lines will have common prefix - They will be output to stderr instead of stdout Signed-off-by: Yousong Zhou --- .../base-files/files/lib/upgrade/fwtool.sh| 24 +-- 1 file changed, 12 insertions(+), 12 deletions(-) diff

[PATCH v2 07/10] base-files: bump PKG_RELEASE

2020-11-09 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- package/base-files/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/base-files/Makefile b/package/base-files/Makefile index f63c4db533..b546eb7e0b 100644 --- a/package/base-files/Makefile +++ b/package/base-files/Makefile

[PATCH v2 00/10] sysupgrade: reword and organize log lines

2020-11-09 Thread Yousong Zhou
usy umount: can't unmount /tmp: Resource busy [ 38.511806] Unregister pv shared memory for cpu 0 [ 38.519259] reboot: Restarting system [ 38.523725] reboot: machine restart Yousong Zhou (10): base-files: upgrade: log with date prefix base-files: upgrade: use stdin redirection to replace

[PATCH v2 06/10] base-files: upgrade: stage2: rework log lines

2020-11-09 Thread Yousong Zhou
- Use common v function when possible - Write log lines to stderr when using echo Signed-off-by: Yousong Zhou --- package/base-files/files/lib/upgrade/stage2 | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/package/base-files/files/lib/upgrade/stage2 b/package

[PATCH v2 09/10] x86: upgrade: use get_image_dd

2020-11-09 Thread Yousong Zhou
Ref: https://bugs.openwrt.org/index.php?do=details&task_id=3140 Reported-by: Philip Prindeville Signed-off-by: Yousong Zhou --- target/linux/x86/base-files/lib/upgrade/platform.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/linux/x86/base-files

[PATCH v2 10/10] x86: upgrade: make code comment appear as log lines

2020-11-09 Thread Yousong Zhou
table from bootdisk... == upgrade: Extract boot sector from the image 37+26 records in 37+26 records out == upgrade: Reading partition table from image... Signed-off-by: Yousong Zhou --- target/linux/x86/base-files/lib/upgrade/platform.sh | 6 ++ 1 file changed, 2 insertions(+), 4

Re: [PATCH v2 03/10] base-files: upgrade: add get_image_dd()

2020-11-09 Thread Yousong Zhou
On Tue, 10 Nov 2020 at 13:35, Philip Prindeville wrote: > > Comments… > > > > On Nov 9, 2020, at 7:22 PM, Yousong Zhou wrote: > > > > This is mainly to handle stderr message "Broken pipe", "F+P records > > in/out" by common pattern "

Re: [PATCH v2 10/10] x86: upgrade: make code comment appear as log lines

2020-11-10 Thread Yousong Zhou
On Tue, 10 Nov 2020 at 19:56, Adrian Schmutzler wrote: > > Hi, > > > -Original Message- > > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > > On Behalf Of Yousong Zhou > > Sent: Dienstag, 10. November 2020 03:22 > > To:

[PATCH v3 01/11] base-files: upgrade: log with date prefix

2020-11-10 Thread Yousong Zhou
And log to stderr Signed-off-by: Yousong Zhou --- package/base-files/files/lib/upgrade/common.sh | 2 +- package/base-files/files/lib/upgrade/stage2| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package/base-files/files/lib/upgrade/common.sh b/package/base-files

[PATCH v3 04/11] base-files: upgrade: add get_image_dd()

2020-11-10 Thread Yousong Zhou
This is mainly to handle stderr message "Broken pipe", "F+P records in/out" by common pattern "xcat | dd .." Ref: https://bugs.openwrt.org/index.php?do=details&task_id=3140 Reported-by: Philip Prindeville Signed-off-by: Yousong Zhou --- package/base-file

[PATCH v3 03/11] base-files: upgrade: use stdin redirection to replace cat command

2020-11-10 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- package/base-files/files/lib/upgrade/common.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/base-files/files/lib/upgrade/common.sh b/package/base-files/files/lib/upgrade/common.sh index 0f25199365..5eb7b23a83 100644 --- a/package

[PATCH v3 11/11] x86: upgrade: make code comment appear as log lines

2020-11-10 Thread Yousong Zhou
able from image... Signed-off-by: Yousong Zhou --- target/linux/x86/base-files/lib/upgrade/platform.sh | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/target/linux/x86/base-files/lib/upgrade/platform.sh b/target/linux/x86/base-files/lib/upgrade/platform.sh index 0b54cae

[PATCH v3 08/11] base-files: bump PKG_RELEASE

2020-11-10 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- package/base-files/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/base-files/Makefile b/package/base-files/Makefile index f63c4db533..b546eb7e0b 100644 --- a/package/base-files/Makefile +++ b/package/base-files/Makefile

[PATCH v3 06/11] base-files: upgrade: fwtool.sh: rewording logs

2020-11-10 Thread Yousong Zhou
The intent is to make it sound more like info level message, not some error like "404 not found". x86 target at the moment makes image with only signature but no metadata (ref commit f8141216 "x86: append metadata to combined images"). Signed-off-by: Yousong Zhou --- pack

[PATCH v3 00/11] sysupgrade: reword and organize log lines

2020-11-10 Thread Yousong Zhou
unt /dev: Resource busy umount: can't unmount /tmp: Resource busy [ 38.511806] Unregister pv shared memory for cpu 0 [ 38.519259] reboot: Restarting system [ 38.523725] reboot: machine restart Yousong Zhou (11): base-files: upgrade: log with date prefix base-files: upgrade: add vn and va

[PATCH v3 10/11] x86: upgrade: use get_image_dd

2020-11-10 Thread Yousong Zhou
Ref: https://bugs.openwrt.org/index.php?do=details&task_id=3140 Reported-by: Philip Prindeville Signed-off-by: Yousong Zhou --- target/linux/x86/base-files/lib/upgrade/platform.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/linux/x86/base-files

[PATCH v3 05/11] base-files: upgrade: fwtool.sh: use v for log lines

2020-11-10 Thread Yousong Zhou
This will have at least the following effects - Log lines will have common prefix - They will be output to stderr instead of stdout Signed-off-by: Yousong Zhou --- .../base-files/files/lib/upgrade/fwtool.sh| 26 +-- 1 file changed, 13 insertions(+), 13 deletions(-) diff

[PATCH v3 09/11] x86: upgrade: use v function for writting logs

2020-11-10 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- .../linux/x86/base-files/lib/upgrade/platform.sh | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/linux/x86/base-files/lib/upgrade/platform.sh b/target/linux/x86/base-files/lib/upgrade/platform.sh index 1bcd492dd7

[PATCH v3 07/11] base-files: upgrade: stage2: use v for log lines

2020-11-10 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- package/base-files/files/lib/upgrade/stage2 | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/package/base-files/files/lib/upgrade/stage2 b/package/base-files/files/lib/upgrade/stage2 index 211a3f4b33..c7629c383f 100755 --- a

[PATCH v3 02/11] base-files: upgrade: add vn and variants

2020-11-10 Thread Yousong Zhou
To be used with in the following pattern vn "Remaining: " for p in $xx; do _vn "$p" done _v Signed-off-by: Yousong Zhou --- package/base-files/files/lib/upgrade/common.sh | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/package/

Re: [PATCH v3 00/11] sysupgrade: reword and organize log lines

2020-11-11 Thread Yousong Zhou
On Tue, 10 Nov 2020 at 21:46, Yousong Zhou wrote: > > The series mainly aims to make sysupgrade log output more organized and > less disturbing, in the following aspects > > - Hide "write error: Broken pipe" from cat command and its friends > - Hide "F+P reco

Re: [RFC] raise gcc/make versions for 20.x

2020-12-16 Thread Yousong Zhou
On Wed, 16 Dec 2020 at 13:11, Petr Štetiar wrote: > > Paul Spooren [2020-12-15 16:26:14]: > > Hi, > > > I've seen two patches for version raises of build requirements and would > > like to know if we should merge them before or after 20.x. > > > > make: 3.81.x -> 4.1.x > > gcc: 4.8 -> 6.x > > > >

Re: [PATCH] build: replace which with Bash command built-in

2020-12-22 Thread Yousong Zhou
On Tue, 22 Dec 2020 at 17:51, Petr Štetiar wrote: > > `which` utility is not shipped by default for example on recent Arch > Linux and then any steps relying on its presence fails, like for example > following Python3 prereq build check: > > $ python3 --version > Python 3.9.1 > > $ make > /bin

[PATCH] kernel: add module for tcp-hybla congestion control algorithm

2020-12-22 Thread Yousong Zhou
Just the module and no default sysctl conf file is provided Ref: https://forum.openwrt.org/t/20-xx-tcp-hybla/83076 Signed-off-by: Yousong Zhou --- package/kernel/linux/modules/netsupport.mk | 20 1 file changed, 20 insertions(+) diff --git a/package/kernel/linux/modules

Re: [PATCH] kernel: add module for tcp-hybla congestion control algorithm

2020-12-23 Thread Yousong Zhou
On Wed, 23 Dec 2020 at 20:09, Hauke Mehrtens wrote: > > On 12/23/20 8:36 AM, Yousong Zhou wrote: > > Just the module and no default sysctl conf file is provided > > > > Ref: https://forum.openwrt.org/t/20-xx-tcp-hybla/83076 > > Signed-off-by: Yousong Zhou >

[PATCH v2 2/4] kmod-tcp-bbr: leave CONFIG_TCP_CONG_ADVANCED to target config

2020-12-23 Thread Yousong Zhou
Since generic has the option set to y and other targets now inherit that choice, there is no behaviour change Signed-off-by: Yousong Zhou --- package/kernel/linux/modules/netsupport.mk | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/package/kernel/linux/modules

[PATCH v2 0/4] add tcp hybla congestion control algorithm

2020-12-23 Thread Yousong Zhou
kmod-tcp-bbr, it should not affect users of default build and config v2 <- v1 - Use CONFIG_TCP_CONG_ADVANCED=y in generic config - Use AutoProbe instead of AutoLoad with custom prio order - Existing kmod-tcp-bbr was changed to align with above Yousong Zhou (4): kernel: remove target

[PATCH v2 3/4] kmod-tcp-bbr: use AutoProbe

2020-12-23 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- package/kernel/linux/modules/netsupport.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/kernel/linux/modules/netsupport.mk b/package/kernel/linux/modules/netsupport.mk index 958b510015..d287e46270 100644 --- a/package/kernel/linux

[PATCH v2 4/4] kmod-tcp-hybla: new module for hybla congestion control algorithm

2020-12-23 Thread Yousong Zhou
Just the module and no default sysctl conf file is provided Link: https://forum.openwrt.org/t/20-xx-tcp-hybla/83076 Signed-off-by: Yousong Zhou --- package/kernel/linux/modules/netsupport.mk | 18 ++ 1 file changed, 18 insertions(+) diff --git a/package/kernel/linux/modules

[PATCH v2 1/4] kernel: remove target specific setting of CONFIG_TCP_CONG_ADVANCED

2020-12-23 Thread Yousong Zhou
tcp-bbr do not have to set it on every occasion Signed-off-by: Yousong Zhou --- target/linux/layerscape/armv7/config-5.4 | 1 - target/linux/layerscape/armv8_64b/config-5.4 | 1 - target/linux/zynq/config-5.4 | 1 - 3 files changed, 3 deletions(-) diff --git a/target/linux/

[PATCH] pkg_hash: pkg_hash_check_unresolved: fix segfault

2020-12-24 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- libopkg/pkg_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libopkg/pkg_hash.c b/libopkg/pkg_hash.c index 879c0ec..dbed3fe 100644 --- a/libopkg/pkg_hash.c +++ b/libopkg/pkg_hash.c @@ -263,7 +263,7 @@ pkg_hash_check_unresolved(pkg_t

Re: [OpenWrt-Devel] libqrcode

2015-05-16 Thread Yousong Zhou
On 17 May 2015 at 02:39, Jonathan Bennett wrote: > I see libqrencode still exists in the main openwrt repo, instead of being > moved over to the packages feed. There is also no maintainer tag in the > Makefile, and the project is a minor release behind. > (https://dev.openwrt.org/browser/packages/

[OpenWrt-Devel] [PATCH 0/6] netifd: workaround for shell protocols without proto_task.

2015-05-19 Thread Yousong Zhou
working fine. Yousong Zhou (6): Changes for more readability. system: fix typo in returning address length. interface: remove redundant iface_attr_info. interface: minor fix for unnecessary ++ operation. proto-shell: allow running protocols without proto_task. interface: teardown on l3_dev

[OpenWrt-Devel] [PATCH 1/6] Changes for more readability.

2015-05-19 Thread Yousong Zhou
- "ifname" for Linux interface name. - "interface" for netifd defined logical interface names as in /etc/config/network. - A few comments and variable renames for better readability. Signed-off-by: Yousong Zhou --- device.c |4 ++-- device.h |3 +++

[OpenWrt-Devel] [PATCH 3/6] interface: remove redundant iface_attr_info.

2015-05-19 Thread Yousong Zhou
BLOBMSG_TYPE_STRING is the default type for elements of BLOBMSG_TYPE_ARRAY. Array type IFACE_ATTR_DNS_SEARCH was already missing there, so drop the whole part anyway. Signed-off-by: Yousong Zhou --- interface.c |6 -- 1 file changed, 6 deletions(-) diff --git a/interface.c b

[OpenWrt-Devel] [PATCH 2/6] system: fix typo in returning address length.

2015-05-19 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- system.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system.h b/system.h index 94e0dd9..382c907 100644 --- a/system.h +++ b/system.h @@ -91,7 +91,7 @@ static inline int system_get_addr_family(unsigned int flags) static inline int

[OpenWrt-Devel] [PATCH 4/6] interface: minor fix for unnecessary ++ operation.

2015-05-19 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- interface.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interface.c b/interface.c index 9f6d8f0..997a721 100644 --- a/interface.c +++ b/interface.c @@ -139,7 +139,7 @@ void interface_add_error(struct interface *iface, const char

[OpenWrt-Devel] [PATCH 6/6] interface: teardown on l3_dev link lost.

2015-05-19 Thread Yousong Zhou
This is mainly for shell protocols that has no_proto_task so that we can still teardown and setup the interface on l3_dev link lost instead of depending on running state of proto_task. Also rename related callbacks for better clarification. Signed-off-by: Yousong Zhou --- interface.c | 28

[OpenWrt-Devel] [PATCH 5/6] proto-shell: allow running protocols without proto_task.

2015-05-19 Thread Yousong Zhou
uot;. The change is mainly for protocols like xl2tpd in which control commands are sent to another daemon xl2tpd to start L2TP negotiation and pppd process who is not under netifd's control as proto_task as is the case in other ppp related protocols like pppoe, pptp, etc. Signed-off-by: Yousong

Re: [OpenWrt-Devel] [PATCH 0/6] netifd: workaround for shell protocols without proto_task.

2015-05-19 Thread Yousong Zhou
On May 19, 2015 8:49 PM, "Yousong Zhou" wrote: > > The first four patches are minor ones formed while makeing this series. The > last two patches are required for L2TP protocol with xl2tpd to be working and > will also allow netifd to bring up interface on network d

[OpenWrt-Devel] [PATCH v2] [netifd] Changes for more readability.

2015-05-24 Thread Yousong Zhou
- "ifname" for Linux interface name. - "interface" for netifd defined logical interface names as in /etc/config/network. - A few comments and variable renames for better readability. Signed-off-by: Yousong Zhou --- v2 <- v1 - Drop the ev (type cast + pointer

[OpenWrt-Devel] [PATCH 0/4] uci: lift 4096 bytes line length limit.

2015-05-25 Thread Yousong Zhou
This cover letter is mainly for noting that the series is for uci repo. Yousong Zhou (4): cli: suppress printing error messages when -q is specified. delta: catch error when parsing delta line. file.c: lift the 4096 bytes line length limit. tests: add test case for parsing long option

[OpenWrt-Devel] [PATCH 1/4] cli: suppress printing error messages when -q is specified.

2015-05-25 Thread Yousong Zhou
- Introduce cli_error() for printing local errors. - Convert existing fprintf(stderr, ) and perror() to cli_error(). - N.B. error messages will still be printed if they occured before -q flag was parsed. Signed-off-by: Yousong Zhou --- cli.c | 26 -- 1 file

[OpenWrt-Devel] [PATCH 2/4] delta: catch error when parsing delta line.

2015-05-25 Thread Yousong Zhou
Reported by sarumpaet [1] [1] uci fails to handle long values properly, https://github.com/openwrt/packages/issues/1231 Signed-off-by: Yousong Zhou --- delta.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/delta.c b/delta.c index 459d2c7..e9c79ab 100644

[OpenWrt-Devel] [PATCH 3/4] file.c: lift the 4096 bytes line length limit.

2015-05-25 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- file.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/file.c b/file.c index 81047a4..cf0dfaf 100644 --- a/file.c +++ b/file.c @@ -33,7 +33,6 @@ #include "uci_internal.h" #define LINEBUF32 -#define LINEBUF_M

[OpenWrt-Devel] [PATCH 4/4] tests: add test case for parsing long option values.

2015-05-25 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- test/tests.d/070_revert | 19 +++ 1 file changed, 19 insertions(+) diff --git a/test/tests.d/070_revert b/test/tests.d/070_revert index 6035f6f..fc9f5f3 100644 --- a/test/tests.d/070_revert +++ b/test/tests.d/070_revert @@ -26,3 +26,22

Re: [OpenWrt-Devel] uhttpd - bugs vs oficial repo

2015-05-30 Thread Yousong Zhou
Hi, Maciej On 30 May 2015 at 21:00, Maciej Soltysiak wrote: > Hi, > > == A bit of background first == > My TV fetches an XML from samsung.com every 2 seconds or so. > I used to trick the TV to get the file from a local server instead. > > When I tried hosting the file on openwrt (I'm on trunk) th

[OpenWrt-Devel] [PATCH 0/5] libubox: tweak a bit.

2015-06-04 Thread Yousong Zhou
Yousong Zhou (5): ulog: always use stderr for ulog_stdio(). utils: refine calloc_a a bit. ustream: tweak ustream_prepare_buf() a bit. ustream-fd: readability change. ustream-fd: stop trying to read when s->read_blocked is set. ulog.c |3 --- ustream-fd.c |

[OpenWrt-Devel] [PATCH 1/5] ulog: always use stderr for ulog_stdio().

2015-06-04 Thread Yousong Zhou
stdout is for normal program output. Signed-off-by: Yousong Zhou --- ulog.c |3 --- 1 file changed, 3 deletions(-) diff --git a/ulog.c b/ulog.c index 34db0db..38fb1c0 100644 --- a/ulog.c +++ b/ulog.c @@ -105,9 +105,6 @@ static void ulog_stdio(int priority, const char *fmt, va_list ap

[OpenWrt-Devel] [PATCH 2/5] utils: refine calloc_a a bit.

2015-06-04 Thread Yousong Zhou
- Return early on calloc() failure. - Correct comment text for __calloc_a(). Signed-off-by: Yousong Zhou --- utils.c |4 utils.h |6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/utils.c b/utils.c index 8fd19f4..627b0f6 100644 --- a/utils.c +++ b/utils.c

[OpenWrt-Devel] [PATCH 3/5] ustream: tweak ustream_prepare_buf() a bit.

2015-06-04 Thread Yousong Zhou
No functional change. - Reuse existing NULL check on buf. - Add some comments for ease of reading the code. Signed-off-by: Yousong Zhou --- ustream.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/ustream.c b/ustream.c index fc93bc2..e7ee9f0 100644

[OpenWrt-Devel] [PATCH 4/5] ustream-fd: readability change.

2015-06-04 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- ustream-fd.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ustream-fd.c b/ustream-fd.c index bc44d4a..daef499 100644 --- a/ustream-fd.c +++ b/ustream-fd.c @@ -119,7 +119,8 @@ static bool __ustream_fd_poll(struct ustream_fd *sf, unsigned

[OpenWrt-Devel] [PATCH 5/5] ustream-fd: stop trying to read when s->read_blocked is set.

2015-06-04 Thread Yousong Zhou
User's s->notify_read is called in ustream_fill_read(). If s->read_blocked is set there, then stop reading more. Signed-off-by: Yousong Zhou --- ustream-fd.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/ustream-fd.c b/ustream-fd.c index daef499..5ffca53 100644 --- a/u

Re: [OpenWrt-Devel] [PATCH 2/5] utils: refine calloc_a a bit.

2015-06-05 Thread Yousong Zhou
On Jun 5, 2015 3:14 PM, "Felix Fietkau" wrote: > > On 2015-06-04 15:41, Yousong Zhou wrote: > > - Return early on calloc() failure. > > - Correct comment text for __calloc_a(). > > > > Signed-off-by: Yousong Zhou > > --- > > utils.c |4

Re: [OpenWrt-Devel] [PATCH] base-files: add /etc/profile.d support

2015-06-10 Thread Yousong Zhou
On Jun 10, 2015 6:30 PM, "Hendrik Lüth" wrote: > > OpenWrt should support an optinal /etc/profile.d directory like most other Linux > distributions. This allows packages to install their own scripts into > /etc/profile.d/. IMO, OpenWrt is not like most of other Linux distributions. So what are t

Re: [OpenWrt-Devel] can netifd automatically restart a service?

2015-06-10 Thread Yousong Zhou
On 11 June 2015 at 14:32, Nikos Mavrogiannopoulos wrote: > In issue 574 [0] there is a big discussion of the behavior of > transmission in openwrt. To summarize it: > * By default when transmission downloads, it may crash the router due to > high memory consumption and OOB. That crash may lead to

[OpenWrt-Devel] [PATCH 1/3] openvpn: fix handling comp_lzo and auth_retry as the wrong type.

2015-06-13 Thread Yousong Zhou
As reported in #19104. Signed-off-by: Yousong Zhou --- package/network/services/openvpn/files/openvpn.init |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package/network/services/openvpn/files/openvpn.init b/package/network/services/openvpn/files/openvpn.init

[OpenWrt-Devel] [PATCH 2/3] openvpn: let instances drop to nobody in default config.

2015-06-13 Thread Yousong Zhou
This is for security precautions. As persist_tun and persist_key are already there, this should not cause compatibility issue. Signed-off-by: Yousong Zhou --- package/network/services/openvpn/files/openvpn.config |2 ++ 1 file changed, 2 insertions(+) diff --git a/package/network/services

[OpenWrt-Devel] [PATCH 3/3] openvpn: bump PKG_RELEASE.

2015-06-13 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- package/network/services/openvpn/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/services/openvpn/Makefile b/package/network/services/openvpn/Makefile index 3e9be0d..81d8007 100644 --- a/package/network/services

[OpenWrt-Devel] [PATCH] ar71xx: add support for TL-WR720N-v4.

2015-06-13 Thread Yousong Zhou
The hardware should be almost the same as TL-WR720N-v3. WiFi and LAN networks were tested by "Lo Yuk Fai ". Failsafe and slider switch were tested by "Wong min ". Signed-off-by: Yousong Zhou --- Well this patch has been sitting on my local tree for a while. Just refres

[OpenWrt-Devel] [PATCH] procd: correct the order of respawn params in the comments.

2015-06-13 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- package/system/procd/files/procd.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/system/procd/files/procd.sh b/package/system/procd/files/procd.sh index 0e798a0..e83e75c 100644 --- a/package/system/procd/files/procd.sh +++ b

[OpenWrt-Devel] [PATCH] firmware-tools/ptgen: fix endianness conversion for PTE .start, .length field.

2015-06-13 Thread Yousong Zhou
They are of 32-bit little endian integers. Signed-off-by: Yousong Zhou --- tools/firmware-utils/src/ptgen.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/firmware-utils/src/ptgen.c b/tools/firmware-utils/src/ptgen.c index 6379ed7..68bad6f 100644 --- a

[OpenWrt-Devel] [PATCH 0/5] procd: a few cleanup and fixes

2015-06-13 Thread Yousong Zhou
ready free'd previously. [1] https://github.com/yousong/waller/tree/master/ossherd Yousong Zhou (5): service: optimize relaying stdio output of daemons a bit. service: dump respawn params in the same order as when passed in. service: remove unused struct watch_subscribe definition.

[OpenWrt-Devel] [PATCH 1/5] service: optimize relaying stdio output of daemons a bit.

2015-06-13 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- service/instance.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/service/instance.c b/service/instance.c index 3367885..4ace40b 100644 --- a/service/instance.c +++ b/service/instance.c @@ -366,6 +366,10 @@ instance_stdio

[OpenWrt-Devel] [PATCH 2/5] service: dump respawn params in the same order as when passed in.

2015-06-13 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- service/instance.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/service/instance.c b/service/instance.c index 4ace40b..e89cbc6 100644 --- a/service/instance.c +++ b/service/instance.c @@ -917,8 +917,8 @@ void instance_dump(struct

[OpenWrt-Devel] [PATCH 3/5] service: remove unused struct watch_subscribe definition.

2015-06-13 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- service/watch.c |5 - 1 file changed, 5 deletions(-) diff --git a/service/watch.c b/service/watch.c index 65e1fec..349b484 100644 --- a/service/watch.c +++ b/service/watch.c @@ -26,11 +26,6 @@ struct watch_object { char *name; }; -struct

[OpenWrt-Devel] [PATCH 4/5] service: allow get_data of specifc instance.

2015-06-13 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- service/service.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/service/service.c b/service/service.c index c2a242b..2702dc3 100644 --- a/service/service.c +++ b/service/service.c @@ -213,8 +213,17

[OpenWrt-Devel] [PATCH 5/5] service: close instance pipe fd on restart.

2015-06-13 Thread Yousong Zhou
Otherwise we hit max number of fd limit (1024) and instances fail to start with the following errors in syslog Sun Jun 14 01:27:38 2015 daemon.warn procd: pipe() failed: 24 (Too many open files) Signed-off-by: Yousong Zhou --- service/instance.c | 14 -- 1 file changed, 12

Re: [OpenWrt-Devel] [PATCH 1/3] openvpn: fix handling comp_lzo and auth_retry as the wrong type.

2015-06-14 Thread Yousong Zhou
On 14 June 2015 at 21:35, Felix Fietkau wrote: > On 2015-06-14 06:04, Yousong Zhou wrote: >> As reported in #19104. >> >> Signed-off-by: Yousong Zhou > comp-lzo does not seem to fit well in the "bool" category, it takes > "yes", "no", or &

[OpenWrt-Devel] [PATCH v2 1/3] openvpn: fix handling option auth_retry.

2015-06-14 Thread Yousong Zhou
As reported in ticket #19104, auth_retry takes a argument with 3 choices: none, nointeract, interact. Signed-off-by: Yousong Zhou --- v2 <- v1drop the move of comp_lzo from params to bools package/network/services/openvpn/files/openvpn.init |4 ++-- 1 file changed, 2 inserti

[OpenWrt-Devel] [PATCH v2 2/3] openvpn: let instances drop to nobody in default config.

2015-06-14 Thread Yousong Zhou
This is for security precautions. As persist_tun and persist_key are already there, this should not cause compatibility issue. Signed-off-by: Yousong Zhou --- package/network/services/openvpn/files/openvpn.config |2 ++ 1 file changed, 2 insertions(+) diff --git a/package/network/services

[OpenWrt-Devel] [PATCH v2 3/3] openvpn: bump PKG_RELEASE.

2015-06-14 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- package/network/services/openvpn/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/services/openvpn/Makefile b/package/network/services/openvpn/Makefile index 3e9be0d..81d8007 100644 --- a/package/network/services

Re: [OpenWrt-Devel] procd/libubox mangles command-line arguments

2015-06-14 Thread Yousong Zhou
Hi, Ted, On 15 June 2015 at 04:57, Ted Hess wrote: > Somewhere in the processing of "procd_set_param command ..." certain > command-line parameters which have colons (":") get treated as argument > delimiters. Example: > > procd_set_param command "foo -a 200:4:16:0 -o hw:0,0" > The correct usage

[OpenWrt-Devel] [PATCH] openvpn: bump to 2.3.7.

2015-06-14 Thread Yousong Zhou
Two patches are dropped as they were already applied upstream. Signed-off-by: Yousong Zhou --- package/network/services/openvpn/Makefile |4 +- .../patches/001-backport_cipher_none_fix.patch | 57 .../services/openvpn/patches/110-musl_compat.patch | 13

[OpenWrt-Devel] [PATCH] musl: provide wtmp compatibility stub for Linux-PAM.

2015-06-16 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- ...ide-wtmp-compatibility-stub-for-Linux-PAM.patch | 104 1 file changed, 104 insertions(+) create mode 100644 toolchain/musl/patches/200-Provide-wtmp-compatibility-stub-for-Linux-PAM.patch diff --git a/toolchain/musl/patches/200-Provide

[OpenWrt-Devel] [PATCH v2] openvpn: bump to 2.3.7.

2015-06-17 Thread Yousong Zhou
Two patches are dropped as they were already applied upstream. Signed-off-by: Yousong Zhou --- v2 <- v1 - Update PKG_MD5SUM - Refreshed all patches package/network/services/openvpn/Makefile |6 +-- .../patches/001-backport_cipher_none_fix.patch |

Re: [OpenWrt-Devel] [PATCH procd] service: use PTY (instead of a pipe) for reading service output

2015-06-19 Thread Yousong Zhou
On 19 June 2015 at 19:34, Rafał Miłecki wrote: > Using pipe automatically switches service to block buffering which kind > of breaks our logging. We won't get anything from FD until the buffer > gets filled fully or the service exits. This makes log messages appear > with an unwanted delay. > Swit

Re: [OpenWrt-Devel] [PATCH procd] service: use PTY (instead of a pipe) for reading service output

2015-06-19 Thread Yousong Zhou
On Jun 19, 2015 9:16 PM, "Rafał Miłecki" wrote: > > On 19 June 2015 at 14:44, Yousong Zhou wrote: > > On 19 June 2015 at 19:34, Rafał Miłecki wrote: > >> Using pipe automatically switches service to block buffering which kind > >> of breaks our logging.

Re: [OpenWrt-Devel] [PATCH] [generic] ramips: adding support for OY-0001 Wireless Router

2015-07-03 Thread Yousong Zhou
On 3 July 2015 at 14:53, LiWeijian wrote: > > From: Tom Deng <2579131...@qq.com> > > Adding support for OY-0001 Wireless Router. > OY-0001 is a wireless router made by oyewifi.com. Below is the details: > MT7620A, 128MB DDR2, 16MB FLASH, SD Slot, USB 2.0, 4 x LAN + 1 x WAN. Hi, PATCH with HTML em

Re: [OpenWrt-Devel] [PATCH] malta: add harddisk support

2015-07-08 Thread Yousong Zhou
On 8 July 2015 at 14:17, Dirk Neukirchen wrote: > works with: > qemu-system-mipsel -M malta \ > -hda openwrt-malta-le-root.ext4 \ > -kernel openwrt-malta-le-vmlinux.elf \ > -nographic -append "root=/dev/sda console=ttyS0" > Nice. Never get a chance to play with a real malta board, I have been wo

Re: [OpenWrt-Devel] How to download 3rd party package from git in OpenWrt

2015-07-13 Thread Yousong Zhou
On Jul 13, 2015 6:53 PM, "Pratik Prajapati" wrote: > > Hi, > > I want to build radvd-2.11 package in OpenWrt but i am unable to download it using Makefile rules. > > Makefile: > > include $(TOPDIR)/rules.mk > > PKG_NAME:=radvd > PKG_VERSION:=2.11 > PKG_SOURCE_PROTO:=git > > PKG_BUILD_DIR:=$(BUILD_

Re: [OpenWrt-Devel] How to install 3rd party package in OpenWrt

2015-07-13 Thread Yousong Zhou
On Jul 13, 2015 5:12 PM, "Pratik Prajapati" wrote: > > Hi, > > What's the difference between following 2 methods in package makefile: > > 1) PKG_INSTALL:=1 > > logs: > make[2]: Leaving directory `/home/pratik.prajapati/work/openwrt-radvd/openwrt-tip/openwrt/package/libs/toolchain' > make[2]: Enter

Re: [OpenWrt-Devel] How to download 3rd party package from git in OpenWrt

2015-07-14 Thread Yousong Zhou
anch_name > > HEAD is now at e3e2b38... Makefile.am: add --with-check to packages target > > > On Mon, Jul 13, 2015 at 8:05 PM, Yousong Zhou wrote: >> >> >> On Jul 13, 2015 6:53 PM, "Pratik Prajapati" >> wrote: >> > >> > Hi, &g

Re: [OpenWrt-Devel] [PATCH v2] [netifd] Changes for more readability.

2015-07-14 Thread Yousong Zhou
On Jul 14, 2015 10:56 PM, "Felix Fietkau" wrote: > > On 2015-05-24 09:36, Yousong Zhou wrote: > > - "ifname" for Linux interface name. > > - "interface" for netifd defined logical interface names as in > >/etc/config/network. > >

Re: [OpenWrt-Devel] Chaos Calmer 15.05-rc3

2015-07-16 Thread Yousong Zhou
On Jul 16, 2015 10:40 PM, "Steven Barth" wrote: > > The OpenWrt developers are proud to announce the third release candidate of OpenWrt Chaos Calmer. > Thanks, guys. regards yousong >___ __ > | |.-.-.-.| | | |.--

Re: [OpenWrt-Devel] Can't link to ubus / ubox from C++ package

2015-07-22 Thread Yousong Zhou
On 22 July 2015 at 19:34, Tomer Eliyahu wrote: > Hi, > > Sorry if I am repeating this question (I posted it in the developers > forum and stackoverflow), but I am out of luck for 3 days now and come > to think it might be an openwrt bug, forgive me if i'm mistaken.. > > I am writing a GUI for open

Re: [OpenWrt-Devel] Change Uboot default values

2015-07-22 Thread Yousong Zhou
On 22 July 2015 at 19:37, Baptiste Clenet wrote: > Hi, > > I would like to change the default values of Uboot when I choose 2 in the > menu. > In the below example, I would like to change <1>, <2> and <3> by > defaults values that I would have set earlier. > Looks like it's most likely hardcoded

Re: [OpenWrt-Devel] package libcoap for OpenWRT, Makefile

2015-08-05 Thread Yousong Zhou
On 5 August 2015 at 19:43, Baptiste Clenet wrote: >> - You can check for WITH_POSIX (or other CFLAGS etc. in config.log > Check it and it is defined. >> - configure always sets -DWITH_POSIX in CPPFLAGS (see configure.in) > Yes, it is set also. > > Don't know where the problem comes from. It works

Re: [OpenWrt-Devel] package libcoap for OpenWRT, Makefile

2015-08-05 Thread Yousong Zhou
On 5 August 2015 at 16:09, Baptiste Clenet wrote: > > define Build/Compile > $(MAKE) -C $(PKG_BUILD_DIR) \ > $(TARGET_CONFIGURE_OPTS) \ > CFLAGS="$(TARGET_CFLAGS) -I$(PKG_BUILD_DIR)" \ > CPPFLAGS="$(TARGET_CPPFLAGS) -I$(PKG_BUILD_DIR)" \ > LDFLAGS="$(TARGET_LDFLAGS) -L$(PKG_BUILD_DIR) -lcoap" > en

Re: [OpenWrt-Devel] package libcoap for OpenWRT, Makefile

2015-08-05 Thread Yousong Zhou
On 5 August 2015 at 21:03, Baptiste Clenet wrote: > 2015-08-05 14:58 GMT+02:00 Yousong Zhou : >> On 5 August 2015 at 16:09, Baptiste Clenet wrote: >>> >>> define Build/Compile >>> $(MAKE) -C $(PKG_BUILD_DIR) \ >>> $(TARGET_CONFIGURE_OPTS) \ &

Re: [OpenWrt-Devel] [PATCH 1/1] [polarssl] Fix build failures due to PKG_NAME != dir name

2015-08-10 Thread Yousong Zhou
On 2 August 2015 at 19:46, Daniel Dickinson wrote: > Packages that depend on PolarSSL fail to build because polarssl's InstallDev > section never actually gets executed because (prior to this patch) the package > name does not match the subdir the package is in (presumably due to upstream > name c

Re: [OpenWrt-Devel] [PATCH 1/1] [polarssl] Fix build failures due to PKG_NAME != dir name

2015-08-11 Thread Yousong Zhou
On 11 August 2015 at 10:00, Yousong Zhou wrote: > On 2 August 2015 at 19:46, Daniel Dickinson > wrote: >> Packages that depend on PolarSSL fail to build because polarssl's InstallDev >> section never actually gets executed because (prior to this patch) the >> packa

[OpenWrt-Devel] [PATCH 1/2] Changes for more readability.

2015-08-12 Thread Yousong Zhou
Signed-off-by: Yousong Zhou --- device.h|3 +++ interface.c |4 ++-- interface.h |1 + ubus.c |2 +- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/device.h b/device.h index ce135ba..798e19e 100644 --- a/device.h +++ b/device.h @@ -160,8 +160,11 @@ struct

[OpenWrt-Devel] [PATCH 2/2] proto-shell: add checkup timeout to restart interface.

2015-08-12 Thread Yousong Zhou
it by allowing users to configure an timeout value instructing netifd to check if the interface is in up state after its last attempt to setup it and try again if that is not the case. Signed-off-by: Yousong Zhou --- proto-shell.c | 53 + 1

Re: [OpenWrt-Devel] TP-Link v3 header format description

2015-08-13 Thread Yousong Zhou
On 14 August 2015 at 01:49, Mathias Kresin wrote: > Hey Weijie Gao, > > 2015-08-05 20:07 GMT+02:00 Weijie Gao : > >> This patch adds header version 2 option for mktplinkfw. > > As long as we talk about the same, the new header version is v3. The > v2 header is already covered by mktplinkfw2.c. > >

  1   2   3   4   5   6   7   8   >