On Wed, 23 Dec 2020 at 20:09, Hauke Mehrtens <ha...@hauke-m.de> wrote:
>
> On 12/23/20 8:36 AM, Yousong Zhou wrote:
> > Just the module and no default sysctl conf file is provided
> >
> > Ref: https://forum.openwrt.org/t/20-xx-tcp-hybla/83076
> > Signed-off-by: Yousong Zhou <yszhou4t...@gmail.com>
> > ---
> > package/kernel/linux/modules/netsupport.mk | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/package/kernel/linux/modules/netsupport.mk
> > b/package/kernel/linux/modules/netsupport.mk
> > index 0c68b394d1..156892c952 100644
> > --- a/package/kernel/linux/modules/netsupport.mk
> > +++ b/package/kernel/linux/modules/netsupport.mk
> > @@ -949,6 +949,26 @@ endef
> > $(eval $(call KernelPackage,tcp-bbr))
> >
> >
> > +define KernelPackage/tcp-hybla
> > + SUBMENU:=$(NETWORK_SUPPORT_MENU)
> > + TITLE:=TCP-Hybla congestion control algorithm
> > + KCONFIG:= \
> > + CONFIG_TCP_CONG_ADVANCED=y \
>
> This is already set in the generic configuration for most targets:
> -----------------
> :~/openwrt/openwrt/target/linux$ git grep TCP_CONG_ADVANCED
> generic/config-5.4:CONFIG_TCP_CONG_ADVANCED=y
> layerscape/armv7/config-5.4:# CONFIG_TCP_CONG_ADVANCED is not set
> layerscape/armv8_64b/config-5.4:# CONFIG_TCP_CONG_ADVANCED is not set
> zynq/config-5.4:# CONFIG_TCP_CONG_ADVANCED is not set
> ---------------
>
> I would prefer if we set if for all targets, then it is not needed here
> any more.
Will do in v2
>
>
> > + CONFIG_TCP_CONG_HYBLA
> > + FILES:=$(LINUX_DIR)/net/ipv4/tcp_hybla.ko
> > + AUTOLOAD:=$(call AutoLoad,74,tcp_hybla)
>
> Is AutoProbe working here?
Will test and send with modification also for tcp-bbr in v2.
Regards,
yousong
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
