Re: [PATCH 1/2] ubox: fix GCC fanalyzer warnings

2022-07-18 Thread Rosen Penev
On Mon, Jul 18, 2022 at 1:45 AM Jo-Philipp Wich wrote: > > Hi, > > > [...] > > - free(aliases); > > + if (aliases) > > + free(aliases); > > This check is redundant, the free() function is guaranteed to be NULL-safe in > the standard: > >The free() function shall cause the space

[PATCHv2 2/2] ubox: fix GCC fanalyzer warnings

2022-07-18 Thread Rosen Penev
memory leaks and missing NULL checks. Signed-off-by: Rosen Penev --- v2: remove null check for free kmodloader.c | 12 1 file changed, 12 insertions(+) diff --git a/kmodloader.c b/kmodloader.c index 4b2ffa7..b2e7a8b 100644 --- a/kmodloader.c +++ b/kmodloader.c @@ -336,6 +336,11

Re: [PATCH] uqmi: fix compilation with GCC12

2022-09-27 Thread Rosen Penev
On Sun, Aug 21, 2022 at 7:54 AM Hauke Mehrtens wrote: > > On 6/11/22 16:47, Bjørn Mork wrote: > > e9hack writes: > > > >> The 'dangling pointer' issue can be fix without using malloc(). > >> > >> --- a/dev.c 2022-05-04 02:18:17.0 +0200 > >> +++ b/dev.c 2022-06-11 08:48:21.185567953 +020

Re: [PATCH] uqmi: fix compilation with GCC12

2022-09-29 Thread Rosen Penev
On Thu, Sep 29, 2022 at 7:45 AM Hauke Mehrtens wrote: > > On 9/28/22 04:22, Rosen Penev wrote: > > On Sun, Aug 21, 2022 at 7:54 AM Hauke Mehrtens wrote: > >> > >> On 6/11/22 16:47, Bjørn Mork wrote: > >>> e9hack writes: > >>> > >>

Re: gpio-mt7621 offset fix for 5.10 kernel series

2022-10-18 Thread Rosen Penev
On Tue, Oct 18, 2022 at 3:50 PM Peter Naulls wrote: > > On 10/18/22 17:10, Lukas Zeller wrote: > . > > > > Just not any more - the mt7621 had this too. I currently patch it back into > > 22.03's gpio-mt7621.c for my builds and set base in the DTS, see [3] > > > > I can follow the rationale to get

Re: [PATCH] px5g-mbedtls (Was: px5g return value checking)

2022-11-07 Thread Rosen Penev
On Mon, Nov 7, 2022 at 7:19 AM Peter Naulls wrote: > > On 11/3/22 14:49, Peter Naulls wrote: > > > > Another one from our security scan: > > > > File: /usr/sbin/px5g > > Issue: RET NOT ASSIGNED in function 'FUN_000281b0' at address 0x281c0 while > > calling 'mbedtls_rsa_check_pub_priv' > > Issue:

Re: [PATCH RFC] ath79: switch TP-Link Archer C59 v1 to read partitions table

2022-11-15 Thread Rosen Penev
On Thu, Nov 10, 2022 at 3:52 AM Rafał Miłecki wrote: > > From: Rafał Miłecki > > So far DTS file for C59 V1 model was assuming flash partitions were > fixed. It just used a little quirk with a custom "firmware" partition > covering both: "os-image" and "file-system" to avoid hardcoding their > of

Re: [PATCH] archs38: mark as source-only

2022-12-29 Thread Rosen Penev
On Thu, Dec 29, 2022 at 10:52 AM Robert Marko wrote: > > archs38 seems to be pretty much unused, usually only treewide changes or > kernel bumps in order to branch off new stable are done to it. > > Considering that target only support some Synopsis HS38 ARC reference > boards and no consumer hard

Re: mt7621 GPIO mapping mystery

2023-01-20 Thread Rosen Penev
CC: Sergio On Fri, Jan 20, 2023 at 11:29 AM Peter Naulls wrote: > > > > I posted previously on GPIOs, which caused some debate; this may or may not > be relevant, but I'd be remiss to not mention it: > > http://lists.openwrt.org/pipermail/openwrt-devel/2022-October/039593.html > > I've been chasi

Re: [OpenWrt-Devel] [PATCH] ramips: ethernet: turn off flow control

2020-01-25 Thread Rosen Penev
On Thu, Jan 23, 2020 at 12:25 AM Bjørn Mork wrote: > > Rosen Penev writes: > > > Several users have been reporting crashing issues with the ethernet > > driver. > > > > One source says that this is a silicon bug in mt7621: > > https://github.com/openwrt

Re: [OpenWrt-Devel] [PATCH] ramips: ethernet: turn off flow control

2020-01-29 Thread Rosen Penev
Sent from my iPhone > On Jan 29, 2020, at 8:22 AM, Petr Štetiar wrote: > > Rosen Penev [2020-01-25 15:04:03]: > > Hi Bjørn and Rosen, > >>> On Thu, Jan 23, 2020 at 12:25 AM Bjørn Mork wrote: >>>>> >>>>> - i

Re: [OpenWrt-Devel] [PATCH] ramips: ethernet: turn off flow control

2020-01-29 Thread Rosen Penev
On Wed, Jan 29, 2020 at 3:14 PM Rosen Penev wrote: > > > > Sent from my iPhone > > > On Jan 29, 2020, at 8:22 AM, Petr Štetiar wrote: > > > > Rosen Penev [2020-01-25 15:04:03]: > > > > Hi Bjørn and Rosen, > > > >>> On Thu, Jan 2

Re: [OpenWrt-Devel] [PATCH] check: bump 0.14.0

2020-02-05 Thread Rosen Penev
On Wed, Feb 5, 2020 at 11:40 AM Eduardo Abinader wrote: > > From: Eduardo Abinader Wrong place. https://github.com/openwrt/packages/ What uses this? > > Compiled and run in x86_64. > > This release adds support for CMake's FetchContent. > > Changes: > > -Add support for FetchContent in CMake

[OpenWrt-Devel] [PATCH] include/cmake: fix compilation with a host subdir

2020-02-06 Thread Rosen Penev
Some packages such as libcxx do not accept being build in the same directory, which breaks host compilation. This commit adds the same behavior present for target builds. Signed-off-by: Rosen Penev --- include/cmake.mk | 4 +++- include/host-build.mk | 2 +- 2 files changed, 4 insertions

[OpenWrt-Devel] ag71xx: fix return value check in ag71xx_probe()

2020-02-06 Thread Rosen Penev
From: Wei Yongjun In case of error, the function of_get_mac_address() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Signed-off-by: Wei Yongjun Reviewed-by: Oleksij Remp

[OpenWrt-Devel] [PATCH] libnl-tiny: install pkgconfig file

2020-02-09 Thread Rosen Penev
This will allow getting rid of InstallDev in the Makefile. It also allows compilation with CMAKE_BINARY_SUBDIR. Signed-off-by: Rosen Penev --- CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 10bf4e8..581015c 100644 --- a/CMakeLists.txt

Re: [OpenWrt-Devel] SPI 104 MHz on ar7240/Spansion S25FL032P

2020-02-10 Thread Rosen Penev
On Mon, Feb 10, 2020 at 3:25 AM Adrian Schmutzler wrote: > > Hi, > > while reviewing the PR for the TL-WA830REv1 [1], I was wondered about the > unusually high > spi-max-frequency = <10400>; > > The author states it's running stable, the datasheet tells > > Normal READ (Serial): 40-MHz clock r

Re: [OpenWrt-Devel] [PATCH] ramips: gsw_mt7621: disable PORT 5 MAC RX/TX flow control by default

2020-02-11 Thread Rosen Penev
sted, since this code is run only on mt7621 > SoC, so there is no need to check for the silicon revisions. Sounds good. > > Ref: > https://lists.openwrt.org/pipermail/openwrt-devel/2017-November/009882.html > Ref: > https://forum.openwrt.org/t/mtk-soc-eth-watchdog-timeout-after-r1

Re: [OpenWrt-Devel] [PATCHv2 1/2] ramips: ethernet: Fix NAPI weight for non mt7621 devices

2020-02-11 Thread Rosen Penev
On Tue, Feb 11, 2020 at 10:48 AM Petr Štetiar wrote: > > Rosen Penev [2019-10-29 10:23:27]: > > > My original fix was to make the code do 16 * 4 as 64 is the limit for NAPI > > weight. However this also reduces the weight for non mt7621 devices. > > > > Ch

Re: [OpenWrt-Devel] Tor is broken

2020-02-15 Thread Rosen Penev
Sent from my iPhone > On Feb 14, 2020, at 11:24 PM, e9hack wrote: > > Hi, > > tor doesn't start since commit ca6528f002d74445e3d0a336aeb9074fc337307a: > > tor: update init script It’s the pidfile profs parameter that’s breaking things. > > Changes: > -add uci config > -create pid file by p

[OpenWrt-Devel] [PATCH] libbsd: update to 0.10.0

2020-02-19 Thread Rosen Penev
Removed all upstream patches. Added PKG_BUILD_PARALLEL for faster compilation. Small Makefile rearrangements for consistency between packages. Signed-off-by: Rosen Penev --- package/libs/libbsd/Makefile | 11 +- ...1-handle-systems-missing-sys_cdefs.h.patch | 195

[OpenWrt-Devel] [PATCH] netifd: install binary from ipkg-install

2020-02-19 Thread Rosen Penev
This works with CMAKE_BINARY_SUBDIR. Signed-off-by: Rosen Penev --- package/network/config/netifd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/config/netifd/Makefile b/package/network/config/netifd/Makefile index 8a1bab8c44..29fd517e93 100644

[OpenWrt-Devel] [PATCH] uci: install from ipkg-install

2020-02-19 Thread Rosen Penev
Signed-off-by: Rosen Penev --- package/system/uci/Makefile | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/package/system/uci/Makefile b/package/system/uci/Makefile index 5c2b68f00a..d0a94ee57b 100644 --- a/package/system/uci/Makefile +++ b/package/system/uci

Re: [OpenWrt-Devel] Next maintenance releases

2020-02-21 Thread Rosen Penev
On Fri, Feb 21, 2020 at 2:08 AM Jo-Philipp Wich wrote: > > Hi, > > I'd like to release 19.07.2 and 18.06.8 sometime between Sun 23rd and > Tue 25th. If you have pending important fixes you like to see backported > to the respective branches please do so ASAP or mention the commits in a > reply to

Re: [OpenWrt-Devel] [PATCH] target: bump minimum CPU type to pentium-mmx

2020-02-22 Thread Rosen Penev
Sent from my iPhone > On Feb 22, 2020, at 6:13 AM, Hauke Mehrtens wrote: > > On 1/12/20 5:44 AM, Rosen Penev wrote: >> f4f8f4a180366ee90fd8e153213db2cb746ca361 broke ffmpeg compilation with x86 >> >> The reason is that ffmpeg's x86 assembly requires at

Re: [OpenWrt-Devel] Next maintenance releases

2020-02-22 Thread Rosen Penev
Sent from my iPhone > On Feb 22, 2020, at 5:31 AM, Petr Štetiar wrote: > > Rosen Penev [2020-02-21 14:55:55]: > > Hi, > >> I would like https://patchwork.ozlabs.org/patch/1221697/ to be applied. >> It makes no sense to have broken functionality in the tree.

[OpenWrt-Devel] [PATCH] libcxx: fix compilation with platforms needing lssp

2020-02-24 Thread Rosen Penev
Currently this is an issue with powerpc and i386 platforms. Added extra cxxabi header It's used by cxxabi.h. Issue discovered when trying to build i2pd. Signed-off-by: Rosen Penev --- package/libs/libcxx/Makefile | 2 +- package/libs/libcxx/patches/030-cxxabi.patch

Re: [OpenWrt-Devel] Tor is broken

2020-02-25 Thread Rosen Penev
On Tue, Feb 25, 2020 at 12:28 PM e9hack wrote: > > Am 15.02.2020 um 11:18 schrieb Rosen Penev: > > It’s the pidfile profs parameter that’s breaking things. > > Your fix doesn't solve the issue. > > commit acabb2cf50726ccafc3cb44aab4307440b2035a4 > tor: fix in

Re: [OpenWrt-Devel] Stubby is broken

2020-02-25 Thread Rosen Penev
On Tue, Feb 25, 2020 at 12:35 PM e9hack wrote: > > Hi, > > stubby is broken since this commit: > > commit eaf522532324f9155d2d038e27006e5caaf9874a > stubby: makefile and init script cleanup > > The necessary config file will be not create: > > /etc/rc.common: line 21: can't create : nonexistent d

Re: [OpenWrt-Devel] [PATCHv2 1/3] tools/pkg-config: Replace with pkgconf

2020-02-28 Thread Rosen Penev
On Fri, Feb 28, 2020 at 2:03 AM Petr Štetiar wrote: > > Rosen Penev [2019-12-25 12:51:33]: > > > On Wed, Dec 25, 2019 at 3:17 AM Petr Štetiar wrote: > > > > > > Rosen Penev [2019-11-28 11:19:31]: > > > > > > > pkgconf is a newer, actively m

Re: [OpenWrt-Devel] [PATCH] exfat-nofuse: fix kernel 5.4 compilation issue

2020-03-05 Thread Rosen Penev
On Thu, Mar 5, 2020 at 1:17 PM Paul Blazejowski wrote: > > Patch taken from > https://github.com/barrybingo/exfat-nofuse/commit/8b59e1f338fdd87f1d5a9db2a119a3745bb467d5 > > Signed-off-by: Paul Blazejowski This is the wrong place to submit. Nevertheless, I'd rather restrict this driver to 4.19 an

Re: [OpenWrt-Devel] [PATCH] exfat-nofuse: fix kernel 5.4 compilation issue

2020-03-06 Thread Rosen Penev
_DIR)/exfat.ko > AUTOLOAD:=$(call AutoLoad,30,exfat,1) > - DEPENDS:=+kmod-nls-base > + DEPENDS:=+kmod-nls-base @(LINUX_4_14||LINUX_4_19) I prefer @!LINUX_5_4 I also want an exfat package for 5.4. As it stands even though it is in the staging directory, I don't think a packag

Re: [OpenWrt-Devel] [PATCH] exfat-nofuse: fix kernel 5.4 compilation issue

2020-03-06 Thread Rosen Penev
On Fri, Mar 6, 2020 at 4:31 PM Stefan Lippers-Hollmann wrote: > > Hi > > On 2020-03-06, Rosen Penev wrote: > > On Fri, Mar 6, 2020 at 11:38 AM Paul Blazejowski > > wrote: > [...] > > > - DEPENDS:=+kmod-nls-base > > > + DEPENDS:=+kmod-nl

Re: [OpenWrt-Devel] pkgconf issue with kmods and libelf [Was: Re: tools/pkg-config: Replace with pkgconf]

2020-03-13 Thread Rosen Penev
On Fri, Mar 13, 2020 at 7:33 AM Petr Štetiar wrote: > > Rosen Penev [2020-02-28 20:12:45]: > > Hi, > > > It's more portable and smaller. And as stated, it is still fairly active. > > Jo has today brought following issue to my attention: > > ## pkgconf >

Re: [OpenWrt-Devel] [PATCH] pkgconf: always retain -I and -L flags

2020-03-13 Thread Rosen Penev
On Fri, Mar 13, 2020 at 7:55 AM Jo-Philipp Wich wrote: > > The pkgconf fork filters -I and -L flag values from .pc files which match > pkgconf's builtin system directory value. > > During configure, pkgconf derives the default system include and library > search path values from exec_prefix, which

[OpenWrt-Devel] [PATCH] procd/rcS: cast format string to int64_t

2020-03-20 Thread Rosen Penev
musl 1.2.0 turns time_t into a 64-bit value, even on 32-bit. This makes it compatible. Signed-off-by: Rosen Penev --- rcS.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rcS.c b/rcS.c index c2e1abb..aaf7314 100644 --- a/rcS.c +++ b/rcS.c @@ -118,7 +118,7 @@ static void

[OpenWrt-Devel] [PATCH] netifd: use the 64-bit version of clock_gettime

2020-03-20 Thread Rosen Penev
Fixes compilation with musl 1.2.0 which removes this syscall. Signed-off-by: Rosen Penev --- system-linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system-linux.c b/system-linux.c index d533be8..902ab50 100644 --- a/system-linux.c +++ b/system-linux.c @@ -2421,7

[OpenWrt-Devel] [PATCH] busybox: fix build with musl 1.2.0

2020-03-20 Thread Rosen Penev
-null. Signed-off-by: Rosen Penev --- interestingly enough, musl returns clock_settime in the settimeofday function. There's a clock_settime64 syscall. package/utils/busybox/Makefile | 2 +- package/utils/busybox/patches/250-date-k-flag.patch | 4 ++-- 2 files changed, 3

Re: [OpenWrt-Devel] [PATCH] samba36: log error if getting device info failed

2020-03-21 Thread Rosen Penev
On Sat, Mar 21, 2020 at 2:37 PM Rafał Miłecki wrote: > > On Mon, 30 Dec 2019 at 16:10, wrote: > > > -Original Message- > > > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > > > On Behalf Of Rafal Milecki > > > Sent: Montag, 30. Dezember 2019 07:55 > > > To: openwrt-

[OpenWrt-Devel] [RFT][PATCH] toolchain/musl: update to 1.2.0

2020-03-21 Thread Rosen Penev
Remove PKG_SOURCE and PKG_SOURCE_SUBDIR since the defaults are used. Remove GLOB_ONLYDIR patch. Does not seem to be needed. Remove woresize.h file. It does not seem to be needed. Update features.h file from upstream. Needed for compilation of this version. Signed-off-by: Rosen Penev --- The

Re: [OpenWrt-Devel] [RFT][PATCH] toolchain/musl: update to 1.2.0

2020-03-22 Thread Rosen Penev
On Sun, Mar 22, 2020 at 2:25 AM Hannu Nyman wrote: > > Rosen Penev wrote at Sat Mar 21 20:36:15 PDT 2020: > > > Remove GLOB_ONLYDIR patch. Does not seem to be needed. > > ... > > The GLOB_ONLYDIR macro is only needed for fstools, which should be fixed > there. &g

Re: [OpenWrt-Devel] [PATCH] netifd: use the 64-bit version of clock_gettime

2020-03-22 Thread Rosen Penev
On Sun, Mar 22, 2020 at 1:39 AM Hans Dedecker wrote: > > hi, > > On Fri, Mar 20, 2020 at 10:59 PM Rosen Penev wrote: > > > > Fixes compilation with musl 1.2.0 which removes this syscall. > > > > Signed-off-by: Rosen Penev > > --- > > system-linux

Re: [OpenWrt-Devel] [PATCH] netifd: use the 64-bit version of clock_gettime

2020-03-22 Thread Rosen Penev
On Sun, Mar 22, 2020 at 7:35 AM Petr Štetiar wrote: > > Hans Dedecker [2020-03-22 09:39:33]: > > > > - if (syscall(__NR_clock_gettime, CLOCK_MONOTONIC, &ts) == 0) > > > + if (syscall(__NR_clock_gettime64, CLOCK_MONOTONIC, &ts) == 0) > > > return ts.tv_sec; > > This bre

Re: [OpenWrt-Devel] [PATCH] busybox: fix build with musl 1.2.0

2020-03-22 Thread Rosen Penev
On Sun, Mar 22, 2020 at 7:45 AM Petr Štetiar wrote: > > Rosen Penev [2020-03-20 16:45:06]: > > > The SYS_settimeofday is no longer present. That is, it's replaced with the > > time32 variant. There is no time64 variant. > > FYI upstream email "busybox 1.31.1

[OpenWrt-Devel] [PATCH] toolchain/gcc: remove uclibc hack

2020-03-24 Thread Rosen Penev
. Signed-off-by: Rosen Penev --- toolchain/gcc/common.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/toolchain/gcc/common.mk b/toolchain/gcc/common.mk index 5f237e4520..090aa2447d 100644 --- a/toolchain/gcc/common.mk +++ b/toolchain/gcc/common.mk @@ -74,9 +74,6 @@ TAR_OPTIONS

Re: [OpenWrt-Devel] [PATCH] busybox: fix build with musl 1.2.0

2020-03-24 Thread Rosen Penev
On Sun, Mar 22, 2020 at 2:25 PM Rosen Penev wrote: > > On Sun, Mar 22, 2020 at 7:45 AM Petr Štetiar wrote: > > > > Rosen Penev [2020-03-20 16:45:06]: > > > > > The SYS_settimeofday is no longer present. That is, it's replaced with the > >

[OpenWrt-Devel] [PATCHv2] busybox: fix build with musl 1.2.0

2020-03-24 Thread Rosen Penev
r anything. Signed-off-by: Rosen Penev --- v2: Switched to a define for uc/glibc compatibility. Reworded commit message slightly. package/utils/busybox/Makefile | 2 +- .../busybox/patches/250-date-k-flag.patch | 18 ++ 2 files changed, 11 insertions(+), 9

[OpenWrt-Devel] [PATCH] netifd: fix compilation with musl 1.2.0

2020-03-24 Thread Rosen Penev
The normal syscall is removed. Use the 64 bit version as musl 1.2.0 defaults to a 64-bit time_t. Signed-off-by: Rosen Penev --- system-linux.c | 4 1 file changed, 4 insertions(+) diff --git a/system-linux.c b/system-linux.c index d533be8..ff4e1fe 100644 --- a/system-linux.c +++ b/system

[OpenWrt-Devel] [PATCH] ugps: fix 64-bit time_t

2020-03-24 Thread Rosen Penev
The abs function takes a 32-bit int, which can cause truncation. Fixes compilation error: error: absolute value function 'abs' given an argu> if ((sec < 0) || (abs(cur.tv_sec - tv.tv_sec) > MAX_TIME_OFFSET)) { Signed-off-by: Rosen Penev --- nmea.c | 2 +- 1 file changed

[OpenWrt-Devel] [PATCH] odhcp6c: fix compilation with musl 1.2.0

2020-03-24 Thread Rosen Penev
SYS_clock_gettime is gone with musl 1.2.0. Define it to the 64 bit version as musl 1.2.0 uses a 64-bit time_t. Signed-off-by: Rosen Penev --- src/odhcp6c.c | 4 1 file changed, 4 insertions(+) diff --git a/src/odhcp6c.c b/src/odhcp6c.c index 19a86f2..6077850 100644 --- a/src/odhcp6c.c

[OpenWrt-Devel] [PATCH] odhcpd: fix compilation with musl 1.2.0

2020-03-24 Thread Rosen Penev
SYS_clock_gettime is gone with musl 1.2.0, leaving only the 64-bit variant Also fixed two format strings that fail as time_t is 64-bit with 1.2.0. Signed-off-by: Rosen Penev --- src/odhcpd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/odhcpd.c b/src/odhcpd.c

Re: [OpenWrt-Devel] [PATCH] netifd: fix compilation with musl 1.2.0

2020-03-25 Thread Rosen Penev
Sent from my iPhone > On Mar 25, 2020, at 1:27 AM, Petr Štetiar wrote: > > Rosen Penev [2020-03-24 22:56:19]: > > Hi, > >> --- a/system-linux.c >> +++ b/system-linux.c >> @@ -59,6 +59,10 @@ >> #define IFA_FLAGS (IFA_MULTICAST + 1) >> #endi

[OpenWrt-Devel] [PATCH] odhcp6c: fix compilation with musl 1.2.0

2020-03-25 Thread Rosen Penev
SYS_clock_gettime is gone with musl 1.2.0. Switch to using the normal function. This was done back in the day when uClibc was used when librt was separate. Since only glibc is impacted now, this should be fine. Added a link to rt just to be sure. Signed-off-by: Rosen Penev --- v2: Switched to

[OpenWrt-Devel] [PATCH] odhcpd: fix compilation with musl 1.2.0

2020-03-25 Thread Rosen Penev
SYS_clock_gettime is gone with musl 1.2.0. Switched to the function. Also fixed two format strings that fail as time_t is 64-bit with 1.2.0. Added a link to librt as that is needed for glibc. Signed-off-by: Rosen Penev --- v2: switched to function CMakeLists.txt | 2 +- src/odhcpd.c | 2

[OpenWrt-Devel] [PATCH] netifd: fix compilation with musl 1.2.0

2020-03-25 Thread Rosen Penev
Switched to the plain function instead of the now gone syscall. Added an rt link flag to fix compilation with glibc. Signed-off-by: Rosen Penev --- v2: switch to function CMakeLists.txt | 2 +- system-linux.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[OpenWrt-Devel] [PATCHv3] netifd: fix compilation with musl 1.2.0

2020-03-25 Thread Rosen Penev
Switched to the plain function instead of the now gone syscall. Signed-off-by: Rosen Penev --- v3: no need for linking to librt v2: switched to function system-linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/system-linux.c b/system-linux.c index d533be8..d36d287

[OpenWrt-Devel] [PATCHv3] odhcpd: fix compilation with musl 1.2.0

2020-03-25 Thread Rosen Penev
SYS_clock_gettime is gone with musl 1.2.0. Switched to the function. Also fixed two format strings that fail as time_t is 64-bit with 1.2.0. Signed-off-by: Rosen Penev --- v3: no need for linking to librt v2: switch to function src/dhcpv6-ia.c | 8 src/odhcpd.c| 2 +- 2 files

[OpenWrt-Devel] [PATCHv3] odhcp6c: fix compilation with musl 1.2.0

2020-03-25 Thread Rosen Penev
SYS_clock_gettime is gone with musl 1.2.0. Switch to using the normal function. This was done back in the day when uClibc was used when librt was separate. Removed struct initialization since it gets written to right after. Signed-off-by: Rosen Penev --- v3: remove librt linking v2: switch

[OpenWrt-Devel] [PATCH] fstoools: add define for GLOB_ONLYDIR

2020-03-25 Thread Rosen Penev
This was originally a patch for musl. It is not present in musl as it is a GNU extension. Place it here where it belongs. Signed-off-by: Rosen Penev --- libfstools/overlay.c | 4 1 file changed, 4 insertions(+) diff --git a/libfstools/overlay.c b/libfstools/overlay.c index 14214a3

Re: [OpenWrt-Devel] [PATCH] fstoools: add define for GLOB_ONLYDIR

2020-03-25 Thread Rosen Penev
On Wed, Mar 25, 2020 at 4:27 PM Rosen Penev wrote: > > This was originally a patch for musl. It is not present in musl as it is a > GNU extension. > > Place it here where it belongs. > > Signed-off-by: Rosen Penev Funny. openembedded has the same patch: https://github.com/k

[OpenWrt-Devel] [PATCH] umdns: fix 64-bit time format string

2020-03-25 Thread Rosen Penev
Fixes compilation under musl 1.2.0 Signed-off-by: Rosen Penev --- service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/service.c b/service.c index 97b6f91..f9d3b48 100644 --- a/service.c +++ b/service.c @@ -122,7 +122,7 @@ service_timeout(struct service *s

[OpenWrt-Devel] [PATCH] busybox: remove date -k patch

2020-03-25 Thread Rosen Penev
f this functionality. Signed-off-by: Rosen Penev --- package/base-files/Makefile | 2 +- package/base-files/files/etc/init.d/system| 3 - package/utils/busybox/Makefile| 2 +- .../busybox/patches/250-date-k-flag.patch | 92 --- 4 files changed,

Re: [OpenWrt-Devel] [PATCH] busybox: remove date -k patch

2020-03-26 Thread Rosen Penev
On Thu, Mar 26, 2020 at 1:04 AM Jo-Philipp Wich wrote: > > Hi, > > > The kernel generally only cares about the timezone in a few places: > > last time I checked, iptables xt_time was affected. Without a properly set > timezone, rules will kick in at unexpected times and --utc / --localtz / > --ker

[OpenWrt-Devel] [PATCH] umdns: fix 64-bit time format string

2020-03-26 Thread Rosen Penev
Fixes compilation under musl 1.2.0 Signed-off-by: Rosen Penev --- service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/service.c b/service.c index 97b6f91..2a7c28f 100644 --- a/service.c +++ b/service.c @@ -122,7 +122,7 @@ service_timeout(struct service *s

[OpenWrt-Devel] [PATCH] odhcpd: fix compilation with musl 1.2.0

2020-03-26 Thread Rosen Penev
SYS_clock_gettime is gone with musl 1.2.0. Switched to the function. Also fixed two format strings that fail as time_t is 64-bit with 1.2.0. Signed-off-by: Rosen Penev --- src/dhcpv6-ia.c | 8 src/odhcpd.c| 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src

Re: [OpenWrt-Devel] [PATCH] generic: mips: exclude more dsemul code when fpu-emu is not enabled

2020-03-29 Thread Rosen Penev
0096000 00:02 272/lib/libc.so > > 77e21000-77e23000 rwxp 00:00 0 > > 7fe23000-7fe44000 rw-p 00:00 0 [stack] > > 7ff63000-7ff64000 r--p 00:00 0 [vvar] > > 7ff64000-7ff65000 r-xp 00:00 0

[OpenWrt-Devel] [PATCH] prereq-build: test for perl's Data::Dumper

2020-03-29 Thread Rosen Penev
ndor_perl /usr/lib64/perl5 /usr/share/perl5 .) at ../lib/Autom4te/C4che.pm line 33. BEGIN failed--compilation aborted at ../lib/Autom4te/C4che.pm line 33. Compilation failed in require at ../bin/autom4te line 40. BEGIN failed--compilation aborted at ../bin/autom4te line 40. make[6]: *** [autoconf.in]

[OpenWrt-Devel] [PATCH] ppd: add missing header

2020-03-29 Thread Rosen Penev
sys/cdefs.h is needed for __P macro definition. Signed-off-by: Rosen Penev --- package/network/services/ppp/Makefile| 2 +- package/network/services/ppp/patches/800-cdefs.patch | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 package/network

[OpenWrt-Devel] [PATCHv2] toolchain/musl: update to 1.2.0

2020-03-29 Thread Rosen Penev
header. In the future, this default may change to warning, or even to erroring out. Tested with all packages in the base tree. They all compile. Tested with most packages in the other feeds. Signed-off-by: Rosen Penev --- v2: removed more glibc headers. toolchain/musl/common.mk

[OpenWrt-Devel] [PATCH] tools/cmake: update to 3.17.0

2020-04-05 Thread Rosen Penev
Remove libressl patches. They are no longer needed. Replace qt tests patch with one that disables all of them. Refresh remaining one. Signed-off-by: Rosen Penev --- tools/cmake/Makefile | 6 ++-- .../cmake/patches/100-disable_qt_tests.patch | 34

[OpenWrt-Devel] [PATCH] odhcpd: fix compilation with musl 1.2.0

2020-04-05 Thread Rosen Penev
SYS_clock_gettime is gone with musl 1.2.0. Switched to the function. Also fixed two format strings that fail as time_t is 64-bit with 1.2.0. Signed-off-by: Rosen Penev --- src/dhcpv6-ia.c | 8 src/odhcpd.c| 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src

Re: [OpenWrt-Devel] [PATCH] odhcpd: fix compilation with musl 1.2.0

2020-04-05 Thread Rosen Penev
On Sun, Apr 5, 2020 at 4:48 PM Rosen Penev wrote: > > SYS_clock_gettime is gone with musl 1.2.0. Switched to the function. > > Also fixed two format strings that fail as time_t is 64-bit with 1.2.0. > > Signed-off-by: Rosen Penev Whoops. accidentally sent this. Changed s

[OpenWrt-Devel] [PATCH] umdns: fix 64-bit time format string

2020-04-05 Thread Rosen Penev
Fixes compilation under musl 1.2.0 Signed-off-by: Rosen Penev --- service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/service.c b/service.c index 97b6f91..2ffc63f 100644 --- a/service.c +++ b/service.c @@ -122,7 +122,7 @@ service_timeout(struct service *s

[OpenWrt-Devel] [PATCHv2] procd/rcS: cast format string to int64_t

2020-04-05 Thread Rosen Penev
musl 1.2.0 turns time_t into a 64-bit value, even on 32-bit. This makes it compatible. Signed-off-by: Rosen Penev --- v2: Changed to PRId64 rcS.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rcS.c b/rcS.c index c2e1abb..f6d210c 100644 --- a/rcS.c +++ b/rcS.c @@ -118,7

[OpenWrt-Devel] [PATCHv3] procd/rcS: cast format string to int64_t

2020-04-05 Thread Rosen Penev
musl 1.2.0 turns time_t into a 64-bit value, even on 32-bit. This makes it compatible. Signed-off-by: Rosen Penev --- v3: Added missing header v2: Changed to PRId64 rcS.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rcS.c b/rcS.c index c2e1abb..2851fae 100644 --- a

[OpenWrt-Devel] [PATCH] xfsprogs: update to 5.5

2020-04-05 Thread Rosen Penev
Signed-off-by: Rosen Penev --- package/utils/xfsprogs/Makefile | 57 +-- .../xfsprogs/patches/100-no-selftest.patch| 14 - .../utils/xfsprogs/patches/110-subdirs.patch | 12 ++-- .../xfsprogs/patches/120-disable_assert.patch | 8 +-- ...six_memalign

[OpenWrt-Devel] [PATCH] elfutils: update to 0.179

2020-04-05 Thread Rosen Penev
o use strerror under non-glibc. It is used under glibc as strerror is not thread safe. It is under musl and uClibc-ng. strerror_l is not available under uClibc-ng. Signed-off-by: Rosen Penev --- package/libs/elfutils/Makefile| 7 +- .../patches/003-libintl-compatibility.patch

Re: [OpenWrt-Devel] [PATCH] tools/cmake: update to 3.17.0

2020-04-05 Thread Rosen Penev
On Sun, Apr 5, 2020 at 11:06 PM Hans Dedecker wrote: > > Hi, > > On Mon, Apr 6, 2020 at 12:38 AM Rosen Penev wrote: >> >> Remove libressl patches. They are no longer needed. > > Can you add why they're not needed anymore ? LibreSSL added support. > > T

Re: [OpenWrt-Devel] [PATCH] elfutils: update to 0.179

2020-04-05 Thread Rosen Penev
On Sun, Apr 5, 2020 at 11:01 PM Oldřich Jedlička wrote: > > po 6. 4. 2020 v 4:02 odesílatel Rosen Penev napsal: >> >> Removed sys/cdefs usage. The header is deprecated. >> >> Removed canonicalize_file_name define. It's already fixed upstream. >> >>

[OpenWrt-Devel] [PATCH 1/2] kmod: add netlink-diag package

2020-04-06 Thread Rosen Penev
This is used by the ss utility from iproute2. Signed-off-by: Rosen Penev --- package/kernel/linux/modules/netsupport.mk | 15 +++ 1 file changed, 15 insertions(+) diff --git a/package/kernel/linux/modules/netsupport.mk b/package/kernel/linux/modules/netsupport.mk index ca25138571

[OpenWrt-Devel] [PATCH 2/2] iproute2: add kmod-netlink-diag for ss

2020-04-06 Thread Rosen Penev
Cannot open netlink socket: Protocol not supported Cannot open netlink socket: Protocol not supported Cannot open netlink socket: Protocol not supported Originally reported here: https://github.com/openwrt/packages/issues/8232 Signed-off-by: Rosen Penev --- package/network/utils/iproute2/Makefile | 4

[OpenWrt-Devel] [PATCH] hostapd: backport usleep patch

2020-04-06 Thread Rosen Penev
Optionally fixes compilation with uClibc-ng. Signed-off-by: Rosen Penev --- package/network/services/hostapd/Makefile | 2 +- .../services/hostapd/patches/800-usleep.patch | 58 +++ 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 package/network

[OpenWrt-Devel] [19.07][PATCH 1/2] wireguard: bump to 20191226

2020-04-09 Thread Rosen Penev
From: "Jason A. Donenfeld" As announced on the mailing list, WireGuard will be in Linux 5.6. As a result, the wg(8) tool, used by OpenWRT in the same manner as ip(8), is moving to its own wireguard-tools repo. Meanwhile, the out-of-tree kernel module for kernels 3.10 - 5.5 moved to its own wiregu

[OpenWrt-Devel] [19.07][PATCH 2/2] wireguard: bump to 1.0.20200401

2020-04-09 Thread Rosen Penev
From: "Jason A. Donenfeld" Recent backports to 5.5 and 5.4 broke our compat layer. This release is to keep things running with the latest upstream stable kernels. Signed-off-by: Jason A. Donenfeld --- package/network/services/wireguard/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[OpenWrt-Devel] [PATCH 1/2] wireguard: bump to 20191226

2020-04-09 Thread Rosen Penev
From: "Jason A. Donenfeld" As announced on the mailing list, WireGuard will be in Linux 5.6. As a result, the wg(8) tool, used by OpenWRT in the same manner as ip(8), is moving to its own wireguard-tools repo. Meanwhile, the out-of-tree kernel module for kernels 3.10 - 5.5 moved to its own wiregu

[OpenWrt-Devel] [18.06][PATCH 2/2] wireguard: bump to 1.0.20200401

2020-04-09 Thread Rosen Penev
From: "Jason A. Donenfeld" Recent backports to 5.5 and 5.4 broke our compat layer. This release is to keep things running with the latest upstream stable kernels. Signed-off-by: Jason A. Donenfeld (cherry picked from commit e32eaf5896276825e81c2250d9c58e4952c3a563) --- package/network/services

[OpenWrt-Devel] [18.06][PATCH 1/2] wireguard: bump to 20191226

2020-04-09 Thread Rosen Penev
From: "Jason A. Donenfeld" As announced on the mailing list, WireGuard will be in Linux 5.6. As a result, the wg(8) tool, used by OpenWRT in the same manner as ip(8), is moving to its own wireguard-tools repo. Meanwhile, the out-of-tree kernel module for kernels 3.10 - 5.5 moved to its own wiregu

[OpenWrt-Devel] [PATCHv3] ubox: run init script through shellcheck

2020-04-14 Thread Rosen Penev
ubstrings and arrays, which are not used here. Signed-off-by: Rosen Penev --- v3: Added quoting fixes. v2: Fixed mistake with executing PIDCOUNT. package/system/ubox/Makefile | 2 +- package/system/ubox/files/log.init | 32 +++--- 2 files changed, 17 insertions(+),

Re: [OpenWrt-Devel] [PATCHv3] ubox: run init script through shellcheck

2020-04-16 Thread Rosen Penev
Sent from my iPhone > On Apr 16, 2020, at 9:01 PM, Alexander 'lynxis' Couzens > wrote: > > Hi Rosen, > > do you plan to do a v4? Otherwise I would merge it. V4 for what? > Best, > lynxis > -- > Alexander Couzens > > mail: lyn...@fe80.eu > jabber: lyn...@fe80.eu > gpg: 390D CF78 8BF9 AA50

Re: [OpenWrt-Devel] [PATCHv3] ubox: run init script through shellcheck

2020-04-17 Thread Rosen Penev
On Fri, Apr 17, 2020 at 1:50 AM wrote: > > Hi, > > > -Original Message- > > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > > On Behalf Of Rosen Penev > > Sent: Mittwoch, 15. April 2020 01:37 > > To: openwrt-devel@lists.

Re: [OpenWrt-Devel] [PATCH] prereq-build: test for perl's Data::Dumper

2020-04-17 Thread Rosen Penev
On Sun, Mar 29, 2020 at 6:13 PM Rosen Penev wrote: > > Required for installation of autoconf: > > make[5]: Entering directory `/openwrt/build_dir/host/autoconf-2.69' > Making all in bin > make[6]: Entering directory `/openwrt/build_dir/host/autoconf-2.69/bin' &g

[OpenWrt-Devel] [PATCH] mt7621: add two extra pcie patches

2020-04-17 Thread Rosen Penev
These fix behavior with several devices where pcie0 is not connected. Funny enough, these commits actually revert behavior to the original driver. Signed-off-by: Rosen Penev --- target/linux/ramips/dts/mt7621.dtsi | 9 +- ...perly-power-off-dual-ported-pcie-phy.patch | 70

[OpenWrt-Devel] [PATCH] toolchain/gcc: eliminate uClibc atexit hack

2020-04-18 Thread Rosen Penev
This seems to be over 10 years old. It doesn't seem to be needed anymore. Tested on malta with uClibc (selected BROKEN). Signed-off-by: Rosen Penev --- toolchain/gcc/common.mk | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/toolchain/gcc/common.mk b/tool

Re: [OpenWrt-Devel] [PATCHv3] ubox: run init script through shellcheck

2020-04-18 Thread Rosen Penev
On Sat, Apr 18, 2020 at 2:22 AM Kevin 'ldir' Darbyshire-Bryant wrote: > > > > > On 18 Apr 2020, at 01:56, Rosen Penev wrote: > > > > On Fri, Apr 17, 2020 at 1:50 AM wrote: > >> > >>> > >>> - [ $log_buf

Re: [OpenWrt-Devel] Upgrading LEDE to 19.07

2020-04-25 Thread Rosen Penev
> On Apr 25, 2020, at 10:47 AM, Luca Bertoncello wrote: > > Hi list! > > I'm not sure, I'm asking to right list, but I didn't found any other > list about OpenWRT I can ask... > > So, I have a "TP-Link TL-WR1043ND v1" running OpenWRT 17.01.4. > I'd like to update it to 19.07, but I read on >

Re: [OpenWrt-Devel] Upgrading LEDE to 19.07

2020-04-25 Thread Rosen Penev
> On Apr 25, 2020, at 11:16 AM, Luca Bertoncello wrote: > > Am 25.04.2020 um 20:12 schrieb Alberto Bursi: > > Hi > >> The only "discontinued" is the "Availability", and that just means if >> you can still find or buy this device new from somewhere. >> It does not mean anything about OpenWrt

Re: [OpenWrt-Devel] Upgrading LEDE to 19.07

2020-04-25 Thread Rosen Penev
> On Apr 25, 2020, at 11:30 AM, Luca Bertoncello wrote: > > Am 25.04.2020 um 20:27 schrieb Alberto Bursi: > > Hi > >> that's weird, that's 64MB. Maybe a V2 in an older box? >> What is the CPU? >> check cat /proc/cpuinfo >> The V1 has Atheros AR9103. > > root@OpenWrt:~# cat /proc/cpuinfo > s

Re: [OpenWrt-Devel] Upgrading LEDE to 19.07

2020-04-25 Thread Rosen Penev
> On Apr 25, 2020, at 11:46 AM, Luca Bertoncello wrote: > > Am 25.04.2020 um 20:44 schrieb Rosen Penev: > >> This is indeed a v1. Strange that it has 64MB of flash. Maybe someone modded >> it... > > With 64MB could I upgrade to 19.07? > This is the only in

[OpenWrt-Devel] [PATCH 1/2] exfat-utils: rename to exfatprogs as upstream has done

2020-04-26 Thread Rosen Penev
Based on kernel.org feedback, this has been renamed for consistency between the other filesystem progs. Signed-off-by: Rosen Penev --- package/utils/{exfat-utils => exfatprogs}/Makefile | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename package/utils/{exfat-utils => exfa

[OpenWrt-Devel] [PATCH 2/2] exfatprogs: update to 1.0.2

2020-04-26 Thread Rosen Penev
This release removes iconv dependency which needed nls.mk before. Switch from old name to new name in Makefile. Added missing header patch. Upstream backport. Fixed license information. Several other cleanups for consistency between packages. Signed-off-by: Rosen Penev --- package/utils

<    3   4   5   6   7   8   9   10   >