[OpenWrt-Devel] [PATCH 5/5] scripts/env: use read -r instead of read

2019-12-31 Thread Rosen Penev
read mangles backslashes. Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/env b/scripts/env index 848850a778..c81fbf8ddc 100755 --- a/scripts/env +++ b/scripts/env @@ -42,7 +42,7 @@ ask_bool

[OpenWrt-Devel] [PATCH] scripts/env: use command -v instead of which

2019-12-31 Thread Rosen Penev
Simpler and built in to the shell. Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/env b/scripts/env index 84166ae5fe..69b63895b4 100755 --- a/scripts/env +++ b/scripts/env @@ -57,7 +57,7 @@ env_init

[OpenWrt-Devel] [PATCH 1/2] scripts/gen-dependencies.sh: replace backticks with $()

2019-12-31 Thread Rosen Penev
Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/gen-dependencies.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/gen-dependencies.sh b/scripts/gen-dependencies.sh index 0aa01b78ec..01bb5ac037 100755 --- a/scripts/gen-dependencies.sh +++ b/scripts

[OpenWrt-Devel] [PATCH 2/2] scripts/gen-dependencies.sh: use /bin/sh

2019-12-31 Thread Rosen Penev
This uses no special bash stuff. Signed-off-by: Rosen Penev --- scripts/gen-dependencies.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen-dependencies.sh b/scripts/gen-dependencies.sh index 01bb5ac037..4beff74bb0 100755 --- a/scripts/gen-dependencies.sh +++ b

[OpenWrt-Devel] [PATCH] scripts/arm-magic.sh: Switch to /bin/sh

2019-12-31 Thread Rosen Penev
This does not use any special bash stuff. Signed-off-by: Rosen Penev --- scripts/arm-magic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/arm-magic.sh b/scripts/arm-magic.sh index 29ec88ab2f..b4b0fa94f5 100755 --- a/scripts/arm-magic.sh +++ b/scripts/arm-magic.sh

[OpenWrt-Devel] [PATCH 2/2] wireguard.sh: Run through shellcheck

2019-12-31 Thread Rosen Penev
Missing local variables and quoting fixes. Signed-off-by: Rosen Penev --- .../network/utils/wireguard-tools/files/wireguard.sh | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/package/network/utils/wireguard-tools/files/wireguard.sh b/package/network/utils

[OpenWrt-Devel] [PATCH 1/2] wireguard.sh: Batch file writes

2019-12-31 Thread Rosen Penev
Speeds up config generation. Signed-off-by: Rosen Penev --- .../utils/wireguard-tools/files/wireguard.sh | 32 --- 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/package/network/utils/wireguard-tools/files/wireguard.sh b/package/network/utils/wireguard-tools

Re: [OpenWrt-Devel] [PATCHv2 1/4] scripts/gen_image_generic.sh: Replace -o with ||

2019-12-31 Thread Rosen Penev
On Tue, Dec 31, 2019 at 1:22 PM Hartmut Knaack wrote: > > Rosen Penev schrieb am 30.12.2019 um 06:07: > > -o is not well defined. > > > > Found with shellcheck. > > > > Signed-off-by: Rosen Penev > > --- > > scripts/gen_image_generic.sh | 4 ++-- &

[OpenWrt-Devel] [PATCH] scripts/gen_image_generic.sh: Replace -o with ||

2019-12-31 Thread Rosen Penev
-o is not well defined. Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 2c57d56f07..81feeaa7d7 100755 --- a/scripts

[OpenWrt-Devel] [PATCH 1/2] libcxx: Build with the libsupc++ ABI

2019-12-31 Thread Rosen Penev
Allows proper exception handling. This includes removing unimplemented warnings. File size increased as a result: Before: 182874 After: 211006 On mipsel_24kc. Note that this requires libsupc++ anyway. It's specified in g++-libcxx. Signed-off-by: Rosen Penev --- package/libs/l

[OpenWrt-Devel] [PATCH 2/2] libcxx: Add size optimizations

2019-12-31 Thread Rosen Penev
warnings. No real change in behavior. Signed-off-by: Rosen Penev --- package/libs/libcxx/Makefile| 2 +- package/libs/libcxx/patches/010-cxx17.patch | 14 package/libs/libcxx/patches/020-fixes.patch | 24 + 3 files changed, 39 insertions(+), 1

Re: [OpenWrt-Devel] [PATCH 1/2] wireguard.sh: Batch file writes

2020-01-01 Thread Rosen Penev
On Wed, Jan 1, 2020 at 3:31 AM Hartmut Knaack wrote: > > Rosen Penev schrieb am 01.01.2020 um 03:08: > > Speeds up config generation. > > > > Signed-off-by: Rosen Penev > > --- > > .../utils/wireguard-tools/files/wireguard.sh | 32 --- >

[OpenWrt-Devel] [PATCHv2 2/2] wireguard.sh: Run through shellcheck

2020-01-01 Thread Rosen Penev
Missing local variables and quoting fixes. Signed-off-by: Rosen Penev --- v2: Added PKG_RELEASE bump. package/network/utils/wireguard-tools/Makefile | 2 +- .../network/utils/wireguard-tools/files/wireguard.sh | 10 +++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff

[OpenWrt-Devel] [PATCHv2 1/2] wireguard.sh: Batch file writes

2020-01-01 Thread Rosen Penev
Speeds up config generation. Signed-off-by: Rosen Penev --- v2: Indented first section .../utils/wireguard-tools/files/wireguard.sh | 64 +-- 1 file changed, 30 insertions(+), 34 deletions(-) diff --git a/package/network/utils/wireguard-tools/files/wireguard.sh b/package

[OpenWrt-Devel] [PATCHv2 1/2] scripts/gen_image_generic.sh: Replace -o with ||

2020-01-01 Thread Rosen Penev
-o is not well defined. Found with shellcheck. Signed-off-by: Rosen Penev --- v2: Switched to -ne instead of ! -eq scripts/gen_image_generic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 2c57d56f07

[OpenWrt-Devel] [PATCHv2 2/2] scripts/gen_image_generic.sh: use /bin/sh

2020-01-01 Thread Rosen Penev
This has nothing bash specific. Signed-off-by: Rosen Penev --- v2: Properly set /bin/sh scripts/gen_image_generic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 814d81d014..230a9ae7d8 100755 --- a/scripts

Re: [OpenWrt-Devel] [PATCH 1/2] scripts/flashing: Switch from echo -en to printf

2020-01-01 Thread Rosen Penev
On Wed, Jan 1, 2020 at 8:07 AM Jo-Philipp Wich wrote: > > Hi. > > $ patch -p1 < 1216552.patch > patching file scripts/flashing/flash.sh > Hunk #1 FAILED at 51. > 1 out of 1 hunk FAILED -- saving rejects to file > scripts/flashing/flash.sh.rej will resend. > > ~ Jo > > _

openwrt-devel@lists.openwrt.org

2020-01-01 Thread Rosen Penev
On Wed, Jan 1, 2020 at 5:47 AM Paul Oranje wrote: > > Happy new year ! > > A minor question/nitpick, see below. > Regards > > > Op 1 jan. 2020, om 03:01 heeft Rosen Penev het volgende > > geschreven: > > > > The former are not well defin

[OpenWrt-Devel] [PATCH] libcxx: Remove -flto from LDFLAGS

2020-01-03 Thread Rosen Penev
s has no change in compiled size, and most likely no change in behavior. Bumped the PKG_RELEASE anyway. Signed-off-by: Rosen Penev --- package/libs/libcxx/Makefile| 6 -- package/libs/libcxx/patches/020-fixes.patch | 11 +++ 2 files changed, 15 insertions(+), 2 del

openwrt-devel@lists.openwrt.org

2020-01-03 Thread Rosen Penev
-o is not well defined. Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 2c57d56f07..527ca5bacc 100755 --- a/scripts

[OpenWrt-Devel] [PATCH 2/2] scripts/gen_image_generic.sh: use /bin/sh

2020-01-03 Thread Rosen Penev
This has nothing bash specific. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 527ca5bacc..10a8495c4f 100755 --- a/scripts/gen_image_generic.sh

openwrt-devel@lists.openwrt.org

2020-01-05 Thread Rosen Penev
-o is not well defined. Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 2c57d56f07..527ca5bacc 100755 --- a/scripts

[OpenWrt-Devel] [PATCH 2/2] scripts/gen_image_generic.sh: use /bin/sh

2020-01-05 Thread Rosen Penev
This has nothing bash specific. Signed-off-by: Rosen Penev --- scripts/gen_image_generic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh index 527ca5bacc..5162be11dd 100755 --- a/scripts/gen_image_generic.sh

[OpenWrt-Devel] [PATCH 2/3] scripts/flashing/flash.sh: switch from echo -en to printf

2020-01-05 Thread Rosen Penev
echo flags are an extension and not available with sh. printf does the same as -en. Signed-off-by: Rosen Penev --- scripts/flashing/flash.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/flashing/flash.sh b/scripts/flashing/flash.sh index 7f2cdf5db9

[OpenWrt-Devel] [PATCH 3/3] scripts/flashing/flash.sh: Switch to /bin/sh

2020-01-05 Thread Rosen Penev
The script no longer uses any features that necessitate bash. Also removed trailing whitespace. Signed-off-by: Rosen Penev --- scripts/flashing/flash.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/flashing/flash.sh b/scripts/flashing/flash.sh index

[OpenWrt-Devel] [PATCH 1/3] scripts/flashing/flash.sh: Add missing quotes

2020-01-05 Thread Rosen Penev
These are in if statements (where they should be), and echo output that is not piped to anything. These should be safe. Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/flashing/flash.sh | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts

[OpenWrt-Devel] [PATCH 1/4] scripts/mkits.sh: replace echo -e with printf

2020-01-05 Thread Rosen Penev
echo flags are not POSIX. printf does the same with added \n. Signed-off-by: Rosen Penev --- scripts/mkits.sh | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/scripts/mkits.sh b/scripts/mkits.sh index 32a978e18d..def3d3c7c2 100755 --- a/scripts

[OpenWrt-Devel] [PATCH 4/4] scripts/mkits.sh: switch from bash to sh

2020-01-05 Thread Rosen Penev
This no longer needs bash. Signed-off-by: Rosen Penev --- scripts/mkits.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mkits.sh b/scripts/mkits.sh index c09e537dbd..62cfc21c6b 100755 --- a/scripts/mkits.sh +++ b/scripts/mkits.sh @@ -1,4 +1,4 @@ -#!/usr/bin/env

[OpenWrt-Devel] [PATCH 2/4] scripts/mkits.sh: add missing quotes

2020-01-05 Thread Rosen Penev
Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/mkits.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/mkits.sh b/scripts/mkits.sh index def3d3c7c2..53b9ec5f20 100755 --- a/scripts/mkits.sh +++ b/scripts/mkits.sh @@ -55,7 +55,7 @@ if [ -z "$

[OpenWrt-Devel] [PATCH 3/4] scripts/mkits.sh: fix improper string and array concatenation

2020-01-05 Thread Rosen Penev
Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/mkits.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mkits.sh b/scripts/mkits.sh index 53b9ec5f20..c09e537dbd 100755 --- a/scripts/mkits.sh +++ b/scripts/mkits.sh @@ -43,7 +43,7 @@ do k

[OpenWrt-Devel] [PATCH 2/4] scripts/env: replace \! with !

2020-01-05 Thread Rosen Penev
The latter is more standard. The former throws an error under shellcheck. Signed-off-by: Rosen Penev --- scripts/env | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/env b/scripts/env index 563f39c1cf..19cfa13841 100755 --- a/scripts/env +++ b/scripts/env @@ -73,7

[OpenWrt-Devel] [PATCH 3/4] scripts/env: exit in case of failure to cd

2020-01-05 Thread Rosen Penev
Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/env b/scripts/env index 19cfa13841..848850a778 100755 --- a/scripts/env +++ b/scripts/env @@ -147,7 +147,7 @@ env_clear() { else

[OpenWrt-Devel] [PATCH 1/4] scripts/env: use command -v instead of which

2020-01-05 Thread Rosen Penev
Simpler and built in to the shell. Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/env b/scripts/env index 7bfca58c5d..563f39c1cf 100755 --- a/scripts/env +++ b/scripts/env @@ -57,7 +57,7 @@ env_init

[OpenWrt-Devel] [PATCH 4/4] scripts/env: use read -r instead of read

2020-01-05 Thread Rosen Penev
read mangles backslashes. Found with shellcheck. Signed-off-by: Rosen Penev --- scripts/env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/env b/scripts/env index 848850a778..c81fbf8ddc 100755 --- a/scripts/env +++ b/scripts/env @@ -42,7 +42,7 @@ ask_bool

[OpenWrt-Devel] [PATCH 1/2] wireguard.sh: batch file writes

2020-01-05 Thread Rosen Penev
Speeds up config generation. Signed-off-by: Rosen Penev --- v3: Fix title v2: Added PKG_RELEASE bump. .../utils/wireguard-tools/files/wireguard.sh | 64 +-- 1 file changed, 30 insertions(+), 34 deletions(-) diff --git a/package/network/utils/wireguard-tools/files

[OpenWrt-Devel] [PATCH 2/2] wireguard.sh: run through shellcheck

2020-01-05 Thread Rosen Penev
Missing local variables and quoting fixes. Signed-off-by: Rosen Penev --- package/network/utils/wireguard-tools/Makefile | 2 +- .../network/utils/wireguard-tools/files/wireguard.sh | 10 +++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/package/network/utils

[OpenWrt-Devel] [PATCH] ath79: ag71xx: use netif_receive_skb_list on 4.19

2020-01-06 Thread Rosen Penev
From: Chuanhong Guo This new function make batch processing of network packets possible, which slightly improves performance. Signed-off-by: Chuanhong Guo Tested-by: Rosen Penev --- around a 20mbps improvement is measured on a TP-LINK Archer C7v2 .../net/ethernet/atheros/ag71xx

Re: [OpenWrt-Devel] [PATCH 0/6] buildsystem: Activate PIE ASLR for some packages

2020-01-07 Thread Rosen Penev
On Tue, Jan 7, 2020 at 2:21 PM Hauke Mehrtens wrote: > > On 10/27/19 6:44 PM, Hauke Mehrtens wrote: > > This is a follow up patch on this discussion on the mailing list: > > https://patchwork.ozlabs.org/patch/1041647/ > > > > This allows to activate PIE only for some packages where we thing it is

[OpenWrt-Devel] [PATCH] tools/pkg-config: run wrapper script though shellcheck

2020-01-07 Thread Rosen Penev
Added \ and newlines for readability Fixed SC2068 and SC2086, both are quoting issues. Signed-off-by: Rosen Penev --- tools/pkg-config/files/pkg-config | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/pkg-config/files/pkg-config b/tools/pkg-config/files/pkg

[OpenWrt-Devel] [PATCH] ath79: ag71xx: use netif_receive_skb_list on 4.19

2020-01-08 Thread Rosen Penev
From: Chuanhong Guo This new function make batch processing of network packets possible, which slightly improves performance. Signed-off-by: Chuanhong Guo Tested-by: Rosen Penev --- around a 20mbps improvement is measured on a TP-LINK Archer C7v2 .../net/ethernet/atheros/ag71xx

[OpenWrt-Devel] [PATCH] toolchain/nasm: Do not build for pentium targets

2020-01-08 Thread Rosen Penev
NASM builds completely broken files with pentium targets. This causes ffmpeg to fail compilation. Instead of working around the problem in the ffmpeg Makefile, it's easier to just not build for broken platforms. Not even objdump can figure out what the generated files are. Signed-off-by:

Re: [OpenWrt-Devel] [PATCH] toolchain/nasm: Do not build for pentium targets

2020-01-08 Thread Rosen Penev
On Wed, Jan 8, 2020 at 2:35 PM Rosen Penev wrote: > > NASM builds completely broken files with pentium targets. This causes > ffmpeg to fail compilation. Instead of working around the problem in the > ffmpeg Makefile, it's easier to just not build for broken platforms. > &g

Re: [OpenWrt-Devel] [PATCH] ath79: ag71xx: use netif_receive_skb_list on 4.19

2020-01-08 Thread Rosen Penev
Sent from my iPhone > On Jan 8, 2020, at 2:50 PM, Tom Psyborg wrote: > > On 08/01/2020, Rosen Penev wrote: >> From: Chuanhong Guo >> >> This new function make batch processing of network packets possible, >> which slightly improves performance. &g

Re: [OpenWrt-Devel] [PATCH 0/6] buildsystem: Activate PIE ASLR for some packages

2020-01-08 Thread Rosen Penev
> On Jan 8, 2020, at 3:10 PM, Hauke Mehrtens wrote: > > On 1/8/20 7:24 AM, Petr Štetiar wrote: >> Hauke Mehrtens [2020-01-07 23:21:19]: >> >> Hi, >> >> thanks for your work. >> Hauke Mehrtens (6): buildsystem: Make PIE ASLR option tristate dnsmasq: Activate PIE by default >

[OpenWrt-Devel] [PATCH] target: bump minimum CPU type to pentium-mmx

2020-01-11 Thread Rosen Penev
f4f8f4a180366ee90fd8e153213db2cb746ca361 broke ffmpeg compilation with x86 The reason is that ffmpeg's x86 assembly requires at least MMX, which the pentium CPU_TYPE was preventing. Fixes ffmpeg compilation on x86_legacy and x86_geode. Signed-off-by: Rosen Penev --- include/target.m

[OpenWrt-Devel] [PATCH-19.07] toolchain/nasm: Do not build for pentium targets

2020-01-11 Thread Rosen Penev
NASM builds completely broken files with pentium targets. This causes ffmpeg to fail compilation. Instead of working around the problem in the ffmpeg Makefile, it's easier to just not build for broken platforms. Not even objdump can figure out what the generated files are. Signed-off-by:

[OpenWrt-Devel] [PATCH 1/7] base-files/functions.sh: don't use $var in $(())

2020-01-16 Thread Rosen Penev
It's not needed. It can also lead to subtle bugs. https://github.com/koalaman/shellcheck/wiki/Sc2004 Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/base-files/files/lib/functions.

[OpenWrt-Devel] [PATCH 3/7] base-files/functions.sh: use command -v instead of $(which)

2020-01-16 Thread Rosen Penev
$(which) must be executed. command -v is a shell builtin. https://github.com/koalaman/shellcheck/wiki/SC2230 Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/base-files/files/lib

[OpenWrt-Devel] [PATCH 5/7] base-files/functions.sh: use && instead of -a

2020-01-16 Thread Rosen Penev
-a is not well defined. https://github.com/koalaman/shellcheck/wiki/SC2166 Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/base-files/files/lib/functions.sh b/package/base-files/files/lib

[OpenWrt-Devel] [PATCH 2/7] base-files/functions.sh: use grep -q instead of []

2020-01-16 Thread Rosen Penev
It's cleaner and faster as it does not need to do extra work. Also removed $() to avoid executing the output. The shell can handle it. https://github.com/koalaman/shellcheck/wiki/SC2143 Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions.sh | 8 1 file chang

[OpenWrt-Devel] [PATCH 6/7] base-files/functions.sh: do not iterate over ls

2020-01-16 Thread Rosen Penev
It does word splitting and glob expansion, which is undesirable. https://github.com/koalaman/shellcheck/wiki/SC2045 Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/base-files/files/lib

[OpenWrt-Devel] [PATCH 4/7] base-files/functions.sh: remove useless cat

2020-01-16 Thread Rosen Penev
The cut command can take a file as an input. https://github.com/koalaman/shellcheck/wiki/SC2002 Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/base-files/files/lib/functions.sh b/package

[OpenWrt-Devel] [PATCH 7/7] base-files/system.sh: remove $ in $(())

2020-01-16 Thread Rosen Penev
Not needed. https://github.com/koalaman/shellcheck/wiki/Sc2004 Signed-off-by: Rosen Penev --- package/base-files/files/lib/functions/system.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/base-files/files/lib/functions/system.sh b/package/base-files/files/lib

[OpenWrt-Devel] [PATCHv2] base-files/functions.sh: use grep -q instead of []

2020-01-17 Thread Rosen Penev
It's cleaner and faster as it does not need to do extra work. Also removed $() to avoid executing the output. The shell can handle it. https://github.com/koalaman/shellcheck/wiki/SC2143 Signed-off-by: Rosen Penev --- v2: Fixed &&/|| typo. package/base-files/files/lib/fun

[OpenWrt-Devel] [PATCHv2] base-files/functions.sh: use command -v instead of which

2020-01-17 Thread Rosen Penev
which must be executed. command -v is a shell builtin. https://github.com/koalaman/shellcheck/wiki/SC2230 Signed-off-by: Rosen Penev --- v2: enclose command -v in $(). package/base-files/files/lib/functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package

[OpenWrt-Devel] [PATCH] ramips: ethernet: turn off flow control

2020-01-22 Thread Rosen Penev
with this change: https://forum.openwrt.org/t/mtk-soc-eth-watchdog-timeout-after-r11573/5/12 Signed-off-by: Rosen Penev --- .../files-4.14/drivers/net/ethernet/mediatek/gsw_mt7621.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/linux/ramips/files-4.14

[OpenWrt-Devel] [PATCHv3] mdadm: revised mdadm config & init logic

2020-01-22 Thread Rosen Penev
ration file. Incremented PKG_RELEASE from 1 to 2 Signed-off-by: Joseph Tingiris (rebased and ran through shellcheck) Signed-off-by: Rosen Penev --- v3: Simplified several sections v2: Rebased after sysmacro patches package/utils/mdadm/Makefile | 2 +- package/utils/mdadm/files/mdadm.confi

Re: [PATCH] Revert "dbus: update to 1.13.18"

2021-04-21 Thread Rosen Penev
On Apr 21, 2021, at 10:46, Ansuel Smith wrote: >> >> This reverts commit 0fb5d3ed2cb31a0a6076d36fb7a668cfe5328c92. >> >> root@finn:/# /etc/init.d/dbus start >> dbus[2537]: Failed to start message bus: Failed to open >> "/dbus-1/system.conf": No such file or directory >> > > The avahi packa

Re: [PATCH] base-files: fix zoneinfo support

2021-06-23 Thread Rosen Penev
an openwrt hack that is used when there are no zoneinfo files. After this patch, it gets created only if they are missing. > > Please send a v2 removing the /tmp/TZ file again iff $zonename exists. There's no point in removing that which is not present. > > On 4/9/21 2:22 PM, Rosen Penev

[PATCH] tools/libressl: update to 3.4.0

2021-09-22 Thread Rosen Penev
Signed-off-by: Rosen Penev --- tools/libressl/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libressl/Makefile b/tools/libressl/Makefile index 29fae1dfb6..7d5f87d041 100644 --- a/tools/libressl/Makefile +++ b/tools/libressl/Makefile @@ -8,8 +8,8

[PATCH] linux: backport GPIO LED patch for MT7350

2021-09-22 Thread Rosen Penev
. Renumbered some patches to keep the date of backports. Refreshed all patches. Signed-off-by: Rosen Penev --- ...-mt7530-MT7530-optional-GPIO-support.patch | 181 ++ ...mt7530-Add-support-for-EEE-features.patch} | 6 +- ...he-dst-buffer-to-of_get_mac_address.patch} | 0

Re: [PATCH] ath79/ag71xx: rearrange ag71xx structs to remove holes

2021-09-26 Thread Rosen Penev
On Sun, Sep 26, 2021 at 11:31 AM Rui Salvaterra wrote: > > Hi, David, > > On Sun, 26 Sept 2021 at 12:37, David Bauer wrote: > > > > Does this mean parts of this patch are already applied upstream? > > Yes, the ag71xx_ring section. > > > Also are there already performance numbers available? > > Ro

Re: Release goals for 22.XX

2021-09-30 Thread Rosen Penev
On Thu, Sep 30, 2021 at 1:05 PM Nick wrote: > > > On 9/30/21 21:43, Daniel Golle wrote: > > On Thu, Sep 30, 2021 at 09:18:06PM +0300, Stijn Tintel wrote: > >> On 30/09/2021 01:19, Nick wrote: > >>> On 9/29/21 22:28, Hauke Mehrtens wrote: > >>> > kernel 5.10: > We should get all targets t

Re: Release goals for 22.XX

2021-10-01 Thread Rosen Penev
On Fri, Oct 1, 2021 at 3:05 PM Hauke Mehrtens wrote: > > On 9/30/21 10:40 PM, Paul Spooren wrote: > > > > On 9/30/21 10:01, Nick wrote: > >> > >> On 9/30/21 21:43, Daniel Golle wrote: > >>> On Thu, Sep 30, 2021 at 09:18:06PM +0300, Stijn Tintel wrote: > On 30/09/2021 01:19, Nick wrote: >

[PATCH] tools/firmware-utils: remove all std= settings

2021-10-02 Thread Rosen Penev
: Rosen Penev --- tools/firmware-utils/Makefile | 16 tools/firmware-utils/src/mktplinkfw-lib.h | 8 tools/firmware-utils/src/mktplinkfw.c | 1 + 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/tools/firmware-utils/Makefile b/tools/firmware

Re: mediatek: fix NETDEV WATCHDOG: eth0 (mtk_SOC_eth): Transmit queue 0 timed out

2021-10-03 Thread Rosen Penev
On Sun, Oct 3, 2021 at 5:18 AM Adrian Schmutzler wrote: > > Hi, > > > -Original Message- > > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > > On Behalf Of daxiong > > Sent: Sonntag, 3. Oktober 2021 13:35 > > To: openwrt-devel@lists.openwrt.org > > Subject: mediatek:

Re: RFC: toolchain for building eBPF modules within the OpenWrt build system

2021-10-03 Thread Rosen Penev
On Sun, Oct 3, 2021 at 5:47 AM Felix Fietkau wrote: > > > Hi, > > I recently spent some time digging into what's needed for proper eBPF > build support in OpenWrt. Here's what I found so far: > > Most out-of-tree eBPF based projects fork some of the BPF related kernel > headers from various differ

Re: Release goals for 22.XX

2021-10-06 Thread Rosen Penev
On Wed, Oct 6, 2021 at 10:46 AM Rui Salvaterra wrote: > > Hi, Rich, > > On Wed, 6 Oct 2021 at 17:54, Rich Brown wrote: > > > > Paul, Rafał, > > > > I think our emails passed in the ether... > > (http://lists.openwrt.org/pipermail/openwrt-devel/2021-October/036637.html) > > > > As I said in that

Re: [PATCH] libubox: remove support for jsoncpp

2021-10-20 Thread Rosen Penev
ping On Thu, Dec 24, 2020 at 5:12 PM Rosen Penev wrote: > > jsoncpp requires a C++ compiler instead of a C one. Fixes the following > build error: > > fatal error: cstddef: No such file or directory > '#include > > Issue was discovered on the buildbots where an SDK

Re: Marvell EBU 32-bit performance benchmarks (VFPv3-D16 vs NEON builds, Turris Omnia).

2021-10-21 Thread Rosen Penev
On Thu, Oct 21, 2021 at 12:19 PM Kabuli Chana wrote: > > For me the argument was not about whether there should 2, but whether > the change to vfpv3-d16 was the right choice as the 1. openssl is of > course preordained to run NEON SIMD code so no change would be expected, > but a benefit is seen o

Re: [PATCH] config: Activate SECCOMP also on MIPS 64

2021-11-01 Thread Rosen Penev
On Mon, Nov 1, 2021 at 10:05 AM Hauke Mehrtens wrote: > > This activates SECCOMP also on mips64 and mips64el. > > This was working fine in a basic test in qemu. > > Signed-off-by: Hauke Mehrtens > --- > > I only did very basic testing, why was this not activated in the beginning? > > > config/Co

Re: warning about which deprecated

2021-11-07 Thread Rosen Penev
On Sun, Nov 7, 2021 at 12:32 PM Ansuel Smith wrote: > > Il giorno dom 7 nov 2021 alle ore 19:18 Bjørn Mork ha scritto: > > > > Ansuel Smith writes: > > > > > Updating to latest ubuntu devel this now comes up > > > /home/ansuel/openwrt/staging_dir/host/bin/which: this version of > > > `which' is

Re: warning about which deprecated

2021-11-07 Thread Rosen Penev
On Sun, Nov 7, 2021 at 10:14 PM Rosen Penev wrote: > > On Sun, Nov 7, 2021 at 12:32 PM Ansuel Smith wrote: > > > > Il giorno dom 7 nov 2021 alle ore 19:18 Bjørn Mork ha > > scritto: > > > > > > Ansuel Smith writes: > > > > > > >

Re: [PATCH] ramips: add support for Zbtlink ZBT-WG1602

2021-11-29 Thread Rosen Penev
On Tue, Nov 16, 2021 at 2:14 AM Sergey Ryazanov wrote: > > Zbtlink ZBT-WG1602 is a Wi-Fi router intendent to use with WWAN > (UMTS/LTE/3G/4G) modems. The router board offsers a couple of miniPCIe > slots with USB and SIM only and another one pure miniPCIe slot as well > as five Gigabit Ethernet po

Re: Switch issues and CI to GitHub

2022-01-07 Thread Rosen Penev
On Fri, Jan 7, 2022 at 1:38 AM Paul Spooren wrote: > > Hi all, > > Back at the Hamburg meeting in 2019 and a succeeding vote we decided to > migrate over to a self-hosted GitLab instance. Some years passed and nothing > really happened so I’d like to give this another go. > > None of the OpenWrt

Re: [PATCH] toolchain/gcc: set dialects for each version

2022-01-25 Thread Rosen Penev
On Tue, Jan 25, 2022 at 9:06 AM Stijn Tintel wrote: > > GCC has an option "-std=" to set the language standard for C and C++. > Newer GCC versions sometimes switch to newer standards by default. This > has the potential to break the OpenWrt toolchain build whenever a distro > introduces a new GCC

Re: [PATCH 1/5] ath79: mikrotik: change to qca8k DSA driver

2022-01-26 Thread Rosen Penev
On Tue, Jan 25, 2022 at 10:44 PM Oskari Lemmela wrote: > > Current mikrotik ath79 devices do not use switch drivers. > Enable the QCA8K driver and disable the old AR8126 phy. > > Signed-off-by: Oskari Lemmela > --- > target/linux/ath79/mikrotik/config-default | 4 > 1 file changed, 4 insert

Re: [PATCH 0/6] backport fixes and improvements for MT7530

2022-02-05 Thread Rosen Penev
On Sat, Feb 5, 2022 at 10:12 AM Hauke Mehrtens wrote: > > On 2/3/22 13:06, DENG Qingfang wrote: > > Hi, > > > > This series backports some patches from upstream to address the current > > MT7530 DSA driver's problems. > > > > Thanks. > > > > DENG Qingfang (6): > >kernel: backport MediaTek jumb

Re: [PATCH 0/6] backport fixes and improvements for MT7530

2022-02-05 Thread Rosen Penev
On Sat, Feb 5, 2022 at 10:23 AM Hauke Mehrtens wrote: > > On 2/5/22 19:21, Rosen Penev wrote: > > On Sat, Feb 5, 2022 at 10:12 AM Hauke Mehrtens wrote: > >> > >> On 2/3/22 13:06, DENG Qingfang wrote: > >>> Hi, > >>> > >>> This

Re: [PATCH 3/3] ramips: mt7621-dts: add pinctrl properties for ethernet

2022-02-08 Thread Rosen Penev
On Tue, Feb 8, 2022 at 1:02 PM Arınç ÜNAL wrote: > > > > On 08/02/2022 18:02, Arınç ÜNAL wrote: > > Hey Chuanhong, > > > > On 08/02/2022 17:20, Chuanhong Guo wrote: > >> Hi! > >> > >> On Tue, Feb 8, 2022 at 3:38 AM Arınç ÜNAL wrote: > >>> diff --git a/target/linux/ramips/dts/mt7621.dtsi > >>> b/t

Re: [PATCH v2 3/3] ramips: mt7621-dts: add pinctrl properties for ethernet

2022-02-11 Thread Rosen Penev
On Fri, Feb 11, 2022 at 4:46 AM Arınç ÜNAL wrote: > > Add the missing pinctrl properties on the ethernet node. > GMAC1 will start working with this change. > > Link: > https://lore.kernel.org/netdev/83a35aa3-6cb8-2bc4-2ff4-64278bbcd...@arinc9.com/ > > Overwrite pinctrl-0 property without rgmii2_p

Re: [PATCH v2 3/3] ramips: mt7621-dts: add pinctrl properties for ethernet

2022-02-11 Thread Rosen Penev
On Fri, Feb 11, 2022 at 2:27 PM Arınç ÜNAL wrote: > > On 12/02/2022 00:53, Rosen Penev wrote: > > On Fri, Feb 11, 2022 at 4:46 AM Arınç ÜNAL wrote: > >> > >> Add the missing pinctrl properties on the ethernet node. > >> GMAC1 will start working with t

Re: OpenWrt 21.02 and 19.07 minor release

2022-02-14 Thread Rosen Penev
On Mon, Feb 14, 2022 at 12:00 PM Hauke Mehrtens wrote: > > On 2/13/22 01:26, Hauke Mehrtens wrote: > > On 2/10/22 16:12, Seo Suchan wrote: > >> looks like those dnsmasq exploits aren't real > >> > >> bugs never looked by human (no commit related by it), but bots > >> confirmed that thoses look fix

[PATCH] firmware-utils: fix compilation with macOS

2022-02-27 Thread Rosen Penev
__bswap_32 is a GNU extension. Signed-off-by: Rosen Penev --- src/avm-wasp-checksum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/avm-wasp-checksum.c b/src/avm-wasp-checksum.c index 8c112f3..41a425e 100644 --- a/src/avm-wasp-checksum.c +++ b/src/avm-wasp-checksum.c

[PATCH] firmware-utils: fix Wparentheses parnings

2022-02-27 Thread Rosen Penev
() is normally used for comparison and (()) for assignment and comparison. Normalize both situations. Signed-off-by: Rosen Penev --- src/mkcasfw.c | 2 +- src/mkcsysimg.c | 2 +- src/mkmylofw.c | 2 +- src/mkzynfw.c | 2 +- src/srec2bin.c | 2 +- 5 files changed, 5 insertions(+), 5

Re: [PATCH] firmware-utils: fix Wparentheses parnings

2022-02-27 Thread Rosen Penev
On Sun, Feb 27, 2022 at 11:42 PM Rosen Penev wrote: > > () is normally used for comparison and (()) for assignment and > comparison. Normalize both situations. > > Signed-off-by: Rosen Penev > --- > src/mkcasfw.c | 2 +- > src/mkcsysimg.c | 2 +- > src/mkmylofw

Re: [PATCH] firmware-utils: fix compilation with macOS

2022-02-28 Thread Rosen Penev
On Mon, Feb 28, 2022 at 12:43 AM Paul Spooren wrote: > > > > > On 28. Feb 2022, at 08:34, Rosen Penev wrote: > > > > __bswap_32 is a GNU extension. > > > > Signed-off-by: Rosen Penev > > — > > Seems to fix the compile issue on my Mac. > &g

Re: [PATCH 2/6] tools/dwarves: add host package

2022-02-28 Thread Rosen Penev
On Mon, Feb 28, 2022 at 8:17 AM Stijn Tintel wrote: > > On 28/02/2022 16:16, Ansuel Smith wrote: > >> On 27/02/2022 17:20, Ansuel Smith wrote: > >>> > > From: Tony Ambardar > > dwarves is a set of tools that use the debugging information inserted in > ELF binaries by compiler

Re: [PATCH] packages: pagekitec: fix crashing due to musl time64

2022-06-03 Thread Rosen Penev
On Fri, Jun 3, 2022 at 10:24 AM wrote: > > From: Lukas Zeller > > [Please note: this is my first attempt at submitting a patch, > please apologize/advise if something is not as it should be. I tried to > follow the guideline in the wiki] https://github.com/openwrt/packages <-- PR there > > upstre

Re: [PATCH] nls.mk: clean up INTL flags

2022-06-05 Thread Rosen Penev
LS=n case. > > [1] e6f569406ffe1d9e35b9b9ea36f38cdd5837728d > > Signed-off-by: Sebastian Kemper Reviewed-by: Rosen Penev > --- > include/nls.mk | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/include/nls.mk b/include/nls.mk > index 163e480932..665ccb565d 10064

[PATCH] uqmi: fix compilation with GCC12

2022-06-08 Thread Rosen Penev
GCC12 doesn't seem to see that the completed member gets nulled. Use malloc to work around this. Signed-off-by: Rosen Penev --- commands-nas.c | 2 +- dev.c | 9 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/commands-nas.c b/commands-nas.c index 47

Re: [PATCH] bcm53xx: disable GRO support at kernel level

2022-06-20 Thread Rosen Penev
On Mon, Jun 20, 2022 at 2:33 AM Rafał Miłecki wrote: > > On 10.06.2022 15:16, Rafał Miłecki wrote: > > This improves NAT masquarade network performance. > > > > An alternative to kernel change would be runtime setup but that requires > > ethtool and identifying relevant network interface and all r

[PATCH] libubox: add missing NULL check

2022-06-22 Thread Rosen Penev
strlen takes non NULL parameters. Found with GCC's -fanalyzer. Signed-off-by: Rosen Penev --- blobmsg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/blobmsg.c b/blobmsg.c index d87d607..bb6c469 100644 --- a/blobmsg.c +++ b/blobmsg.c @@ -364,6 +364,8 @@ blobmsg_add_string_buffer(s

Re: [PATCH] bcm53xx: disable GRO support at kernel level

2022-06-22 Thread Rosen Penev
On Wed, Jun 22, 2022 at 8:49 PM Rafał Miłecki wrote: > > On 21.06.2022 01:13, Rosen Penev wrote: > > On Mon, Jun 20, 2022 at 2:33 AM Rafał Miłecki wrote: > >> > >> On 10.06.2022 15:16, Rafał Miłecki wrote: > >>> This improves NAT masquarade network

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-16 Thread Rosen Penev
On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > Hi, > some background about this. > > I'm trying to improve our CI system more and more by finally adding > support for real > EXTERNAL_TOOLCHAIN_SUPPORT... I'm running (and abusing) the github CI > to make sure everything works and all compi

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-17 Thread Rosen Penev
On Sun, Jul 17, 2022 at 2:29 AM Christian Marangi wrote: > > On Sat, Jul 16, 2022 at 10:17:28PM -0700, Rosen Penev wrote: > > On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > > > > > Hi, > > > some background about this. > > > > >

Re: Question about ancient TARGET_CFLAGS in rules.mk?

2022-07-17 Thread Rosen Penev
On Sun, Jul 17, 2022 at 2:29 AM Christian Marangi wrote: > > On Sat, Jul 16, 2022 at 10:17:28PM -0700, Rosen Penev wrote: > > On Sat, Jul 16, 2022 at 4:52 PM Ansuel Smith wrote: > > > > > > Hi, > > > some background about this. > > > > >

[PATCH 2/2] ubox: fix bad realloc usage

2022-07-17 Thread Rosen Penev
Both cppcheck and gcc's -fanalyzer complain here that realloc is being used improperly. Signed-off-by: Rosen Penev --- kmodloader.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kmodloader.c b/kmodloader.c index bc5f20c..5f8c9c1 100644 --- a/kmodloader.c

[PATCH 1/2] ubox: fix GCC fanalyzer warnings

2022-07-17 Thread Rosen Penev
memory leaks and missing NULL checks. Signed-off-by: Rosen Penev --- kmodloader.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/kmodloader.c b/kmodloader.c index 63bae5e..bc5f20c 100644 --- a/kmodloader.c +++ b/kmodloader.c @@ -336,6 +336,11 @@ static int

[PATCHv2 1/2] ubox: fix bad realloc usage

2022-07-18 Thread Rosen Penev
Both cppcheck and gcc's -fanalyzer complain here that realloc is being used improperly. Signed-off-by: Rosen Penev --- kmodloader.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kmodloader.c b/kmodloader.c index 63bae5e..4b2ffa7 100644 --- a/kmodloader.c

<    2   3   4   5   6   7   8   9   10   >