GDB got support for ARC with version 8.2. No need for this fork.
Signed-off-by: Rosen Penev
---
toolchain/gdb/Makefile | 11 ---
1 file changed, 11 deletions(-)
diff --git a/toolchain/gdb/Makefile b/toolchain/gdb/Makefile
index 41ba9853fd..c25d181990 100644
--- a/toolchain/gdb/Makefile
Enables proper checking. Matches printf behavior in C.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
target/linux/mvebu/image/gen_mvebu_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mvebu/image/gen_mvebu_sdcard_img.sh
b/target/linux
let is a bashism.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
target/linux/mvebu/image/gen_mvebu_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mvebu/image/gen_mvebu_sdcard_img.sh
b/target/linux/mvebu/image/gen_mvebu_sdcard_img.sh
There is nothing that needs bash anymore.
Signed-off-by: Rosen Penev
---
target/linux/mvebu/image/gen_mvebu_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mvebu/image/gen_mvebu_sdcard_img.sh
b/target/linux/mvebu/image/gen_mvebu_sdcard_img.sh
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/rb532/image/gen_image.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/rb532/image/gen_image.sh
b/target/linux/rb532/image/gen_image.sh
index a9d48d86ca..e46539fd85 100755
--- a/target/linux
This has nothing that needs bash.
Signed-off-by: Rosen Penev
---
target/linux/sunxi/image/gen_sunxi_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/sunxi/image/gen_sunxi_sdcard_img.sh
b/target/linux/sunxi/image/gen_sunxi_sdcard_img.sh
index
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/omap/image/gen_omap_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/omap/image/gen_omap_sdcard_img.sh
b/target/linux/omap/image/gen_omap_sdcard_img.sh
index 881df9a05d
This has nothing that needs bash.
Signed-off-by: Rosen Penev
---
target/linux/zynq/image/gen_zynq_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/zynq/image/gen_zynq_sdcard_img.sh
b/target/linux/zynq/image/gen_zynq_sdcard_img.sh
index 460a336e69
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/mxs/image/gen_sdcard_vfat_ext4.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mxs/image/gen_sdcard_vfat_ext4.sh
b/target/linux/mxs/image/gen_sdcard_vfat_ext4.sh
index bca664c780
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/gemini/image/dns313_gen_hdd_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/gemini/image/dns313_gen_hdd_img.sh
b/target/linux/gemini/image/dns313_gen_hdd_img.sh
index 6e899ec840
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/mxs/image/gen_sdcard_ext4_ext4.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mxs/image/gen_sdcard_ext4_ext4.sh
b/target/linux/mxs/image/gen_sdcard_ext4_ext4.sh
index 99bd3bf573
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/brcm2708/image/gen_rpi_sdcard_img.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/linux/brcm2708/image/gen_rpi_sdcard_img.sh
b/target/linux/brcm2708/image/gen_rpi_sdcard_img.sh
index
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/mediatek/image/gen_mt7623_emmc_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mediatek/image/gen_mt7623_emmc_img.sh
b/target/linux/mediatek/image/gen_mt7623_emmc_img.sh
index
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/arc770/image/gen_axs10x_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/arc770/image/gen_axs10x_sdcard_img.sh
b/target/linux/arc770/image/gen_axs10x_sdcard_img.sh
index
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/apm821xx/image/mbl_gen_hdd_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/apm821xx/image/mbl_gen_hdd_img.sh
b/target/linux/apm821xx/image/mbl_gen_hdd_img.sh
index 1fb868b5b3
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/layerscape/image/gen_sdcard_head_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/layerscape/image/gen_sdcard_head_img.sh
b/target/linux/layerscape/image/gen_sdcard_head_img.sh
index
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/at91/image/gen_at91_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/at91/image/gen_at91_sdcard_img.sh
b/target/linux/at91/image/gen_at91_sdcard_img.sh
index 4eb30fa790
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/archs38/image/gen_axs10x_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/archs38/image/gen_axs10x_sdcard_img.sh
b/target/linux/archs38/image/gen_axs10x_sdcard_img.sh
index
On Mon, Nov 25, 2019 at 11:16 AM Bjørn Mork wrote:
>
> Rosen Penev writes:
>
> > +#!/bash/sh
>
> Eh, that's not /bin/sh
Whoops. Will resend.
>
>
> Bjørn
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.or
apper with meson as passing
--version with other options fails.
Signed-off-by: Rosen Penev
---
v3: Added meson patch
v2: Rebased against master
tools/Makefile| 6 ++--
tools/pkg-config/files/pkg-config | 3 --
tools/{pkg-config => pkgconf}/Makefil
There is nothing that needs bash anymore.
Signed-off-by: Rosen Penev
---
target/linux/mvebu/image/gen_mvebu_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mvebu/image/gen_mvebu_sdcard_img.sh
b/target/linux/mvebu/image/gen_mvebu_sdcard_img.sh
Enables proper checking. Matches printf behavior in C.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
target/linux/mvebu/image/gen_mvebu_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mvebu/image/gen_mvebu_sdcard_img.sh
b/target/linux
let is a bashism.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
target/linux/mvebu/image/gen_mvebu_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mvebu/image/gen_mvebu_sdcard_img.sh
b/target/linux/mvebu/image/gen_mvebu_sdcard_img.sh
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/rb532/image/gen_image.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/rb532/image/gen_image.sh
b/target/linux/rb532/image/gen_image.sh
index a9d48d86ca..e46539fd85 100755
--- a/target/linux
This has nothing that needs bash.
Signed-off-by: Rosen Penev
---
target/linux/zynq/image/gen_zynq_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/zynq/image/gen_zynq_sdcard_img.sh
b/target/linux/zynq/image/gen_zynq_sdcard_img.sh
index 460a336e69
This has nothing that needs bash.
Signed-off-by: Rosen Penev
---
target/linux/sunxi/image/gen_sunxi_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/sunxi/image/gen_sunxi_sdcard_img.sh
b/target/linux/sunxi/image/gen_sunxi_sdcard_img.sh
index
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/omap/image/gen_omap_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/omap/image/gen_omap_sdcard_img.sh
b/target/linux/omap/image/gen_omap_sdcard_img.sh
index 881df9a05d
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/mxs/image/gen_sdcard_vfat_ext4.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mxs/image/gen_sdcard_vfat_ext4.sh
b/target/linux/mxs/image/gen_sdcard_vfat_ext4.sh
index bca664c780
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/mxs/image/gen_sdcard_ext4_ext4.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mxs/image/gen_sdcard_ext4_ext4.sh
b/target/linux/mxs/image/gen_sdcard_ext4_ext4.sh
index 99bd3bf573
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/gemini/image/dns313_gen_hdd_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/gemini/image/dns313_gen_hdd_img.sh
b/target/linux/gemini/image/dns313_gen_hdd_img.sh
index 6e899ec840
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/mediatek/image/gen_mt7623_emmc_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/mediatek/image/gen_mt7623_emmc_img.sh
b/target/linux/mediatek/image/gen_mt7623_emmc_img.sh
index
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/layerscape/image/gen_sdcard_head_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/layerscape/image/gen_sdcard_head_img.sh
b/target/linux/layerscape/image/gen_sdcard_head_img.sh
index
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/brcm2708/image/gen_rpi_sdcard_img.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/linux/brcm2708/image/gen_rpi_sdcard_img.sh
b/target/linux/brcm2708/image/gen_rpi_sdcard_img.sh
index
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/at91/image/gen_at91_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/at91/image/gen_at91_sdcard_img.sh
b/target/linux/at91/image/gen_at91_sdcard_img.sh
index 4eb30fa790
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/apm821xx/image/mbl_gen_hdd_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/apm821xx/image/mbl_gen_hdd_img.sh
b/target/linux/apm821xx/image/mbl_gen_hdd_img.sh
index 1fb868b5b3
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/archs38/image/gen_axs10x_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/archs38/image/gen_axs10x_sdcard_img.sh
b/target/linux/archs38/image/gen_axs10x_sdcard_img.sh
index
Nothing here needs bash.
Signed-off-by: Rosen Penev
---
target/linux/arc770/image/gen_axs10x_sdcard_img.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/arc770/image/gen_axs10x_sdcard_img.sh
b/target/linux/arc770/image/gen_axs10x_sdcard_img.sh
index
On Wed, Nov 27, 2019 at 2:49 AM Petr Štetiar wrote:
>
> Rosen Penev [2019-11-25 14:44:18]:
>
> Hi,
>
> you're trying to do a lot of things in one patch, making it hard to review,
> please split it up.
>
> 1. switch to pkgconf
> 2. shell check fix
> 3. me
The wrapper calls pkgconf with multiple arguments. meson wants to call
it with a single --version argument. To keep compatibility with
pkg-config, revert the upstream version change.
This fixes projects that use meson and pkg-config to find packages.
Signed-off-by: Rosen Penev
---
...me
pkg-config. For simplicity here,
it is renamed to pkg-config.real, as in the original package.
Initial results have been positive. As before, pkgconf works as long as
the pkg-config files point to the proper paths.
Signed-off-by: Rosen Penev
---
tools/Makefile
Mainly quoting fixes.
Separated parameters by \ for easier readability.
Switched to calling by dirname so that it can be called from any
directory.
Signed-off-by: Rosen Penev
---
tools/pkgconf/files/pkg-config | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools
On Wed, Nov 27, 2019 at 6:35 AM Andre Heider wrote:
>
> On 27/11/2019 13:19, Petr Štetiar wrote:
> > Andre Heider [2019-11-27 12:26:39]:
> >
> >> I didn't pursue upstreaming it because it looks like merge request at
> >> github
> >> are ignored and I didn't feel like signing up at upstreams own
On Wed, Nov 27, 2019 at 2:30 PM Rosen Penev wrote:
>
> Mainly quoting fixes.
>
> Separated parameters by \ for easier readability.
>
> Switched to calling by dirname so that it can be called from any
> directory.
>
> Signed-off-by: Rosen Penev
> ---
> t
Fixes warnings:
warning: passing argument 2 of 'execv' from incompatible pointer type
[-Wincompatible-pointer-types]
254 | execv(usign_argv[0], usign_argv)
Signed-off-by: Rosen Penev
---
usign-exec.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --g
Mainly quoting fixes.
Separated parameters by \ for easier readability.
Signed-off-by: Rosen Penev
---
v2: Removed calling by dirname.
tools/pkgconf/files/pkg-config | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/pkgconf/files/pkg-config b/tools/pkgconf/files
pkg-config. For simplicity here,
it is renamed to pkg-config.real, as in the original package.
Initial results have been positive. As before, pkgconf works as long as
the pkg-config files point to the proper paths.
Signed-off-by: Rosen Penev
---
tools/Makefile
The wrapper calls pkgconf with multiple arguments. meson wants to call
it with a single --version argument. To keep compatibility with
pkg-config, revert the upstream version change.
This fixes projects that use meson and pkg-config to find packages.
Signed-off-by: Rosen Penev
---
...me
Allows GCC to check the formats by switching to a define, which is a
constant expression.
Fixes:
warning: format not a string literal, argument types not checked
[-Wformat-nonliteral]
207 | snprintf(buf, sizeof(buf), tmpl, include->path);
Signed-off-by: Rosen Penev
---
includes.c |
]
176 |error_info);
|^~
error: format not a string literal, argument types not checked
[-Werror=format-nonliteral]
185 |error_info);
Signed-off-by: Rosen Penev
---
libuci.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libuci.c b
t;name, msgstr);
| ^~~
Signed-off-by: Rosen Penev
---
examples/server.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/server.c b/examples/server.c
index e0cde0b..e218efa 100644
--- a/examples/server.c
+++ b/examples/server.c
@@ -84,7 +84,7 @@ static int test
ote: in expansion of macro 'opkg_msg'
45 | opkg_msg(l, fmt": %s.\n", ##args, strerror(errno))
| ^~~~
note: in expansion of macro 'opkg_perror'
247 | opkg_perror(ERROR, "Failed to create temporary directory '%s'",
Signed-off-b
>
>
>> Wouldn't it make sense to enable following hardening flags (maybe consider
>> others as well?):
>>
>> -Werror=format-security
>> -Werror=format-nonliteral
Actually the flag I used was -Werror=format=2. It includes all of them.
The nonliteral warning is not applicable everywhere. In so
On Sat, Nov 30, 2019 at 7:41 AM Petr Štetiar wrote:
>
> Petr Štetiar [2019-11-30 15:04:40]:
>
> > Wouldn't it make sense to enable following hardening flags (maybe consider
> > others as well?):
> >
> > -Werror=format-security
> > -Werror=format-nonliteral
>
> FYI, following uci patch:
>
> d
-nonliteral]
vfprintf(stderr, fmt, ap);
Signed-off-by: Rosen Penev
---
v2: Fixed extra warning from clang 10.
cli.c| 1 +
libuci.c | 10 +-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/cli.c b/cli.c
index 8970f4f..6ba97ea 100644
--- a/cli.c
+++ b/cli.c
tatement has no effect; remove unnecessary ';' to
silence this warning [-Werror,-Wextra-semi-stmt]
UCI_TRAP_SAVE(ctx, ignore);
error: empty expression statement has no effect; remove unnecessary ';' to
silence this warning [-Werror,-Wextra-semi-stmt]
};
Signe
> On Dec 1, 2019, at 5:55 AM, Jonas Gorski wrote:
>
> Hi,
>
>> On Fri, 29 Nov 2019 at 22:06, Rosen Penev wrote:
>>
>> Allows GCC to check the formats by switching to a define, which is a
>> constant expression.
>>
>> Fixes:
>>
>&
-nonliteral]
vfprintf(stderr, fmt, ap);
Signed-off-by: Rosen Penev
---
v3: Moved define to top of file.
v2: Fixed extra warning from clang 10.
cli.c| 1 +
libuci.c | 15 ---
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/cli.c b/cli.c
index 8970f4f
-nonliteral]
vfprintf(stderr, fmt, ap);
Signed-off-by: Rosen Penev
---
v4: Use a proper named define
v3: Moved define to top of file.
v2: Fixed extra warning from clang 10.
cli.c| 1 +
libuci.c | 15 ---
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a
On Wed, Dec 11, 2019 at 11:32 AM Alberto Bursi
wrote:
>
>
>
> On 11/12/19 18:54, Daniel Golle wrote:
> > On Wed, Dec 11, 2019 at 05:37:26PM +0100, WRT Burner wrote:
> >> On 11/12/2019 15:22, Daniel Golle wrote:
> >>> And it's even needless to say that
> >>> replying to a spam email in which ever w
On Thu, Dec 12, 2019 at 2:01 AM Daniel Golle wrote:
>
> Hi Alberto,
>
> On Wed, Dec 11, 2019 at 08:32:41PM +0100, Alberto Bursi wrote:
> >
> >
> > On 11/12/19 18:54, Daniel Golle wrote:
> > > On Wed, Dec 11, 2019 at 05:37:26PM +0100, WRT Burner wrote:
> > > > On 11/12/2019 15:22, Daniel Golle wrot
package needs to be
cleaned up and updated.
Runtime tested with gddrescue, gdisk, dcwapd, bonnie++, and aircrack-ng
on a TP-Link Archer C7v2.
Signed-off-by: Rosen Penev
---
config/Config-build.in | 3 ++
include/uclibc++.mk | 12 +-
package/libs/libcxx/Makefile
Avoids redefining bool.
Signed-off-by: Rosen Penev
---
package/network/utils/iperf/Makefile | 2 +-
package/network/utils/iperf/patches/010-libcxx.patch | 12
2 files changed, 13 insertions(+), 1 deletion(-)
create mode 100644 package/network/utils/iperf/patches
The depends are totally wrong. libunwind does not work with powerpc and
i386 as it needs glibc.
Instead of duplicating the platforms, just change the dependency.
Signed-off-by: Rosen Penev
---
package/devel/perf/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
Don't build with uClibc-ng. It's totally unsupported as several functions
are missing.
Make the musl libc support conditional.
Fix hash with make check FIXUP=1. Apparently I based the Makefile off of
libedit and forgot to fix the hash.
Signed-off-by: Rosen Penev
---
config/Confi
On Wed, Dec 25, 2019 at 3:17 AM Petr Štetiar wrote:
>
> Rosen Penev [2019-11-28 11:19:31]:
>
> > pkgconf is a newer, actively maintained implementation of pkg-config
>
> I'm wondering if that `actively maintained` part still holds true.
It does. The team has managemen
On Thu, Dec 26, 2019 at 2:32 PM Khem Raj wrote:
>
> On Thu, Dec 26, 2019 at 4:50 AM Hauke Mehrtens wrote:
> >
> > On 12/24/19 10:50 PM, Petr Štetiar wrote:
> > > Khem Raj [2019-12-24 10:02:13]:
> > >
> > > Hi,
> > >
> > > use "PATCH libubox" subject prefix, because there is no blobmsg.c file in
It's broken for ARMv5, which is the only armeb target in OpenWrt.
Signed-off-by: Rosen Penev
---
package/libs/nettle/Makefile | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/package/libs/nettle/Makefile b/package/libs/nettle/Makefile
index 62c39702ed..b9324e4793 1
Without -r, backslashes would get mangled.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
target/toolchain/files/wrapper.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/toolchain/files/wrapper.sh
b/target/toolchain/files/wrapper.sh
index bd4996cac2
No bash features are actually used here.
Signed-off-by: Rosen Penev
---
target/toolchain/files/wrapper.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/toolchain/files/wrapper.sh
b/target/toolchain/files/wrapper.sh
index ba2b34778f..d42c6a14d5 100755
--- a/target
Found with shellcheck.
Signed-off-by: Rosen Penev
---
target/toolchain/files/wrapper.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/toolchain/files/wrapper.sh
b/target/toolchain/files/wrapper.sh
index 4452128382..bd4996cac2 100755
--- a/target/toolchain
Fixes shellcheck warning:
SC2004: $/${} is unnecessary on arithmetic variables.
Signed-off-by: Rosen Penev
---
scripts/gen_image_generic.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh
index 1e35b1b349
This has nothing bash specific.
Signed-off-by: Rosen Penev
---
scripts/gen_image_generic.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh
index 0832bf91de..6a8065e15a 100755
--- a/scripts/gen_image_generic.sh
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/gen_image_generic.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh
index 9f3e4d024c..0832bf91de 100755
--- a/scripts/gen_image_generic.sh
+++ b/scripts
-o is not well defined.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/gen_image_generic.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh
index 2d2fb120ce..1e35b1b349 100755
--- a/scripts
read will mangle backslashes.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/clean-package.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh
index 987e6685a8..e849c41afa 100755
--- a/scripts/clean
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/clean-package.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh
index e849c41afa..b64d7ad21a 100755
--- a/scripts/clean-package.sh
+++ b/scripts/clean
-a is not well defined.
Signed-off-by: Rosen Penev
---
scripts/clean-package.sh | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh
index b64d7ad21a..2c9d4169ba 100755
--- a/scripts/clean-package.sh
+++ b/scripts/clean
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/clean-package.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh
index 6dd9bf7306..987e6685a8 100755
--- a/scripts/clean-package.sh
+++ b/scripts/clean
On Sun, Dec 29, 2019 at 8:19 PM Stefan Lippers-Hollmann wrote:
>
> Hi
>
> On 2019-12-29, Rosen Penev wrote:
> > This has nothing bash specific.
> [...]
> > +++ b/scripts/gen_image_generic.sh
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env bash
> > +#!/bin/
Fixes shellcheck warning:
SC2004: $/${} is unnecessary on arithmetic variables.
Signed-off-by: Rosen Penev
---
scripts/gen_image_generic.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh
index 1e35b1b349
-o is not well defined.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/gen_image_generic.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh
index 2d2fb120ce..1e35b1b349 100755
--- a/scripts
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/gen_image_generic.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh
index 9f3e4d024c..0832bf91de 100755
--- a/scripts/gen_image_generic.sh
+++ b/scripts
This has nothing bash specific.
Signed-off-by: Rosen Penev
---
scripts/gen_image_generic.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh
index 0832bf91de..6a8065e15a 100755
--- a/scripts/gen_image_generic.sh
The script no longer uses any features that necessitate bash.
Also removed trailing whitespace.
Signed-off-by: Rosen Penev
---
scripts/flashing/flash.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/flashing/flash.sh b/scripts/flashing/flash.sh
index
echo flags are an extension and not available with sh. printf does the
same as -en.
Signed-off-by: Rosen Penev
---
scripts/flashing/flash.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/flashing/flash.sh b/scripts/flashing/flash.sh
index 7f2cdf5db9
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/strip-kmod.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/strip-kmod.sh b/scripts/strip-kmod.sh
index 313015b909..7886cd907f 100755
--- a/scripts/strip-kmod.sh
+++ b/scripts/strip-kmod.sh
@@ -50,6
There's nothing bash specific here.
Signed-off-by: Rosen Penev
---
scripts/strip-kmod.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/strip-kmod.sh b/scripts/strip-kmod.sh
index 7886cd907f..28be35ea7c 100755
--- a/scripts/strip-kmod.sh
+++ b/scripts/strip-km
This uses nothing bash specific.
Signed-off-by: Rosen Penev
---
scripts/symlink-tree.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/symlink-tree.sh b/scripts/symlink-tree.sh
index aa169e2455..6ed91dfb5a 100755
--- a/scripts/symlink-tree.sh
+++ b/scripts/symlink
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/strip-kmod.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/strip-kmod.sh b/scripts/strip-kmod.sh
index 313015b909..7886cd907f 100755
--- a/scripts/strip-kmod.sh
+++ b/scripts/strip-kmod.sh
@@ -50,6
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/mkits.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/mkits.sh b/scripts/mkits.sh
index 93c8cedaed..32a978e18d 100755
--- a/scripts/mkits.sh
+++ b/scripts/mkits.sh
@@ -15,7 +15,7 @@
#
usage
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/mkits.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/mkits.sh b/scripts/mkits.sh
index 53b9ec5f20..c09e537dbd 100755
--- a/scripts/mkits.sh
+++ b/scripts/mkits.sh
@@ -43,7 +43,7 @@ do
k
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/mkits.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/mkits.sh b/scripts/mkits.sh
index def3d3c7c2..53b9ec5f20 100755
--- a/scripts/mkits.sh
+++ b/scripts/mkits.sh
@@ -55,7 +55,7 @@ if [ -z "$
echo flags are not POSIX. printf does the same with added \n.
Signed-off-by: Rosen Penev
---
scripts/mkits.sh | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/scripts/mkits.sh b/scripts/mkits.sh
index 32a978e18d..def3d3c7c2 100755
--- a/scripts
This no longer needs bash.
Signed-off-by: Rosen Penev
---
scripts/mkits.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/mkits.sh b/scripts/mkits.sh
index c09e537dbd..62cfc21c6b 100755
--- a/scripts/mkits.sh
+++ b/scripts/mkits.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env
Upstream backport.
Signed-off-by: Rosen Penev
---
package/devel/trace-cmd/Makefile | 2 +-
.../devel/trace-cmd/patches/120-limits.patch | 26 +++
2 files changed, 27 insertions(+), 1 deletion(-)
create mode 100644 package/devel/trace-cmd/patches/120-limits.patch
Upstream backport.
Signed-off-by: Rosen Penev
---
package/network/services/lldpd/Makefile | 2 +-
.../services/lldpd/patches/010-limits.patch | 21 +++
2 files changed, 22 insertions(+), 1 deletion(-)
create mode 100644 package/network/services/lldpd/patches/010
Some find binaries do not imply the current directory.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/env | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/env b/scripts/env
index 69b63895b4..fd49e1c817 100755
--- a/scripts/env
+++ b/scripts/env
The latter is more standard. The former throws an error under
shellcheck.
Signed-off-by: Rosen Penev
---
scripts/env | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/env b/scripts/env
index 563f39c1cf..19cfa13841 100755
--- a/scripts/env
+++ b/scripts/env
@@ -73,7
The former are not well defined.
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/env | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/env b/scripts/env
index fd49e1c817..563f39c1cf 100755
--- a/scripts/env
+++ b/scripts/env
@@ -73,7 +73,7
Found with shellcheck.
Signed-off-by: Rosen Penev
---
scripts/env | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/env b/scripts/env
index 19cfa13841..848850a778 100755
--- a/scripts/env
+++ b/scripts/env
@@ -147,7 +147,7 @@ env_clear() {
else
501 - 600 of 972 matches
Mail list logo
