[OpenWrt-Devel] [RFC] x86: use multiple profiles

2020-04-14 Thread Paul Spooren
Hi all, the x86 been recently reworked (cb007a7bf6) and now it is easily possible to define multiple profiles. Currently only a `generic` profile is offered which builds mbr and efi grub images with a standard selection of packages (common device drivers). I'd suggest to have multiple profiles fo

Re: [OpenWrt-Devel] [PATCH] x86: fix unusable squashfs images by adding missing padding

2020-04-25 Thread Paul Spooren
ystem could mount root, tried: > ext3 > ext2 > ext4 > squashfs > iso9660 > f2fs > > Kernel panic - not syncing: VFS: Unable to mount root fs on > unknown-block(202,0) > > So lets fix this by adding back padding which was introduced in commit > a17d9482f5e2 ("

Re: [OpenWrt-Devel] [PATCH] x86: fix unusable squashfs images by adding missing padding

2020-04-25 Thread Paul Spooren
ystem could mount root, tried: > ext3 > ext2 > ext4 > squashfs > iso9660 > f2fs > > Kernel panic - not syncing: VFS: Unable to mount root fs on > unknown-block(202,0) > > So lets fix this by adding back padding which was introduced in commit > a17d9482f5e2 ("

Re: [OpenWrt-Devel] Uncompress image: trailing garbage ignored

2020-04-26 Thread Paul Spooren
Hi, On Thu, 2020-04-23 at 23:29 +0300, Hannu Nyman wrote: > W. Michael Petullo kirjoitti 23.4.2020 klo 19.50: > > I have started to notice a gunzip warning when decompressing the > > OpenWrt images I build. This is with master df27e949: > > > > gunzip openwrt/bin/targets/x86/64/openwrt-x86-64-ge

[OpenWrt-Devel] Applying to Season of Docs

2020-05-01 Thread Paul Spooren
Hi all, Google offers a program[0] to stipend people writing technical documentation for open source projects. The stipend is possible for anyone 18+ and not living in a US embargoed country, so unlike the Google Summer of Code project not only for students. Successful writers get a stipend of abo

Re: [OpenWrt-Devel] Applying to Season of Docs

2020-05-03 Thread Paul Spooren
On Sun, 2020-05-03 at 17:37 +0200, Hauke Mehrtens wrote: > On 5/1/20 11:07 PM, Paul Spooren wrote: > > Hi all, > > > > Google offers a program[0] to stipend people writing technical documentation > > for > > open source projects. The stipend is possible for a

Re: [OpenWrt-Devel] [PATCH 2/2] build: compress kernel debuginfo using zstd

2020-05-15 Thread Paul Spooren
Could we use that for the SDK/ImageBuilder as well? Best, Paul -- May 13, 2020 9:20:39 AM Matthias Schiffer : zstd with its default settings (compression level -3) compresses better than bzip2 -9 (which is the default setting), and is an order of magnitude faster. I made the following mea

Re: [OpenWrt-Devel] [PATCH] build, imagebuilder: Do not require libncurses-dev

2020-06-09 Thread Paul Spooren
20 5:53 PM, Sven Roederer wrote: Am Dienstag, 14. April 2020, 23:14:47 CEST schrieb Paul Spooren: The buildroot and SDK both require `libncurses-dev` to be installed on the system, however the ImageBuilder uses precompiled binaries. This patch changes the prerequirements checks to skip the `libn

Re: [OpenWrt-Devel] [PATCH] build, imagebuilder: Do not require libncurses-dev

2020-06-10 Thread Paul Spooren
Hi, Hi Paul, I gave this today a test on my spare computer, but it still complained about the missing libncurses. I tested with snapshot imagebuilder (r13519-8a858363b0) with just calling "make image" Any ideas? It's just a PR and not yet merged. Once merged give it another 24 hours. Best,

[OpenWrt-Devel] [PATCH][RFC] build: disable target name in image filename

2020-06-14 Thread Paul Spooren
openwrt-linksys_wrt3200acm.manifest * openwrt-linksys_wrt3200acm-squashfs-factory.img * openwrt-linksys_wrt3200acm-squashfs-sysupgrade.bin Signed-off-by: Paul Spooren --- It's been a while since I made a controversial patch[0] so it feels about time. [0]: https://github.com/openwrt/openwrt/pull/2

Re: [OpenWrt-Devel] [PATCH][RFC] build: disable target name in image filename

2020-06-14 Thread Paul Spooren
Hi, On 6/14/20 10:00 AM, m...@adrianschmutzler.de wrote: -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of Paul Spooren Sent: Sonntag, 14. Juni 2020 11:34 To: openwrt-devel@lists.openwrt.org Subject: [OpenWrt-Devel] [PATCH][RFC] build

Re: [OpenWrt-Devel] [PATCH][RFC] build: disable target name in image filename

2020-06-15 Thread Paul Spooren
On 6/15/20 7:32 AM, Matthias Schiffer wrote: I just think of ar71xx and ath79, where we have the same device but different targets. Of course, the name won't be exactly equal, as ath79 will have e.g. tplink_ prefix and ar71xx won't. Isn't ar71xx removed from master builds? It's neither at snap

[PATCH buildbot] phase1: add JSON merge step

2020-06-30 Thread Paul Spooren
as well. Signed-off-by: Paul Spooren --- phase1/master.cfg | 8 1 file changed, 8 insertions(+) diff --git a/phase1/master.cfg b/phase1/master.cfg index 792f9b3..1a96982 100644 --- a/phase1/master.cfg +++ b/phase1/master.cfg @@ -925,6 +925,14 @@ for target in targets

[PATCH] build,json: store arch_packages in profiles.json

2020-06-30 Thread Paul Spooren
The `arch_packages` contains the supported package architecture. Previously it was necessary to parse the `Packages` index for the line `Architecture:`, requiring both an additional parser and file download. Signed-off-by: Paul Spooren --- scripts/json_overview_image_info.py | 7 +-- 1

Re: [PATCH] busybox: disable SUSv2 compatibility by default

2020-07-08 Thread Paul Spooren
What is the storage gain archived by changing this? On 08.07.20 01:27, Rui Salvaterra wrote: The Single UNIX Specification, Version 3, came out on the 30th January 2002 [1]. There's nothing in the OpenWrt userspace which needs support for legacy SUSv2 compatibility. [1] http://www.unix.org/vers

Re: [PATCH] build: put DT "compatible" value as "board_name" in profiles.json

2020-07-08 Thread Paul Spooren
TL;DR: I think the issue is solved for devices using DT, the problem are the other targets with custom solutions. I think there is a policy for new DT devices to use the compatible string as profile. Multiple targets contain the following line in the target Makefile, which automatically adds

Re: [PATCHv2 3/4] scripts/clean-package.sh: remove useless cat

2020-07-11 Thread Paul Spooren
Hi, On 11.07.20 08:45, Rosen Penev wrote: Found with shellcheck. Signed-off-by: Rosen Penev --- v2: rebased scripts/clean-package.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh index 4b536c8a48..03e49df3e7 100

[PATCH] scripts: Add Buildbot dumpinfo.pl script

2020-07-12 Thread Paul Spooren
cript could be removed from the buildbot repository and maintained only here. [0]: https://git.openwrt.org/?p=buildbot.git;a=blob;f=scripts/dumpinfo.pl;h=aa97f8d60379076a41b968402e9337cea824ece5;hb=HEAD Signed-off-by: Paul Spooren --- scripts/dumpinfo.pl

Re: [PATCH] scripts: Add Buildbot dumpinfo.pl script

2020-07-13 Thread Paul Spooren
On 12.07.20 17:16, Paul Spooren wrote: The dumpinfo.pl script comes from buildbot.git[0] and is used to print available targets and architectures, which are then build. As the buildbot clones openwrt.git anyway, the script might as well live here as it can be used for other cases as well, e.g

Re: [PATCH] build: put DT "compatible" value as "board_name" in profiles.json

2020-07-13 Thread Paul Spooren
Štetiar ; Moritz Warning ; Paul Spooren Subject: [PATCH] build: put DT "compatible" value as "board_name" in profiles.json From: Rafał Miłecki The purpose of "board_name" in JSON is matchine OpenWrt running device with JSON profile entry. Right now it gets filled for d

[RFC] CI testing of device-tree .dts files

2020-07-15 Thread Paul Spooren
Hi all, I played today a bit with dt-schema[0] which allows to validate device-tree schema files via something called json-schema[1], a schema description written in, *drums*, yaml. Ideally vendors specify their hardware in the Kernel[2] and dt-schema validates each .dts file added to OpenWrt

[PATCH] dropbear: Enable Ed25519 for normal devices

2020-07-15 Thread Paul Spooren
splitting `dropbear` into two packages like `dropbear` and `dropbear-ed25519`. Signed-off-by: Paul Spooren --- package/network/services/dropbear/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/services/dropbear/Config.in b/package/network/services

[PATCH] build: store buildsystem revision in packages

2020-07-15 Thread Paul Spooren
on ath79/generic. Signed-off-by: Paul Spooren --- include/package-ipkg.mk | 1 + package/Makefile| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/package-ipkg.mk b/include/package-ipkg.mk index 622cbf3223..1dc8dc8f56 100644 --- a/include/package-ipkg.mk +++ b

[RFC] usage of mkhash, sha256sum and md5sum

2020-07-15 Thread Paul Spooren
Hi, the OpenWrt system requires the calculation of both md5 and sha256 sums at various places, this is partly done via a small C file in ./scripts/mkhash.c and partly by using a sha256sum binary. A ancient wrapper ./scripts/md5sum is added for Mac OS X compatibility. * Should we create our o

Re: [PATCH v2 3/6] base-files: fwtool: implement compatibility check for images

2020-07-15 Thread Paul Spooren
On 14.07.20 04:28, Adrian Schmutzler wrote: We regularly encounter the situation that devices are subject to changes that will make them incompatible to previous versions. Removing SUPPORTED_DEVICES will not really be helpful in most of these cases, as this only helps after a rename. To solve

Re: [PATCH v2 4/6] base-files: fwtool: make compat_version backward compatible

2020-07-15 Thread Paul Spooren
On 14.07.20 04:28, Adrian Schmutzler wrote: So far, the compatibility mechanism only works if both device and image are already updated to the new routines. This patch extends the sysupgrade metadata and fwtool_check_image() to account for "older" images as well: The basic mechanism for older d

Re: [PATCH v2 5/6] mvebu: implement compatibility version for DSA migration

2020-07-15 Thread Paul Spooren
On 14.07.20 04:28, Adrian Schmutzler wrote: This implements the newly introduced compat-version to prevent upgrade between swconfig and DSA for mvebu. Just define a compat version with minor increment and an appropriate message for both image (in Makefile) and device (in base-files). Having t

Re: [RFC] usage of mkhash, sha256sum and md5sum

2020-07-16 Thread Paul Spooren
Hi, On 15.07.20 22:54, Felix Fietkau wrote: On 2020-07-16 04:06, Paul Spooren wrote: Hi, the OpenWrt system requires the calculation of both md5 and sha256 sums at various places, this is partly done via a small C file in ./scripts/mkhash.c and partly by using a sha256sum binary. A ancient

Re: [RFC] usage of mkhash, sha256sum and md5sum

2020-07-16 Thread Paul Spooren
On 16.07.20 09:36, Felix Fietkau wrote: On 2020-07-16 21:18, Paul Spooren wrote: Hi, On 15.07.20 22:54, Felix Fietkau wrote: On 2020-07-16 04:06, Paul Spooren wrote: Hi, the OpenWrt system requires the calculation of both md5 and sha256 sums at various places, this is partly done via a

[PATCH] build: use mkhash for IPK metadata checksums

2020-07-16 Thread Paul Spooren
this replaces it with `mkhash sha256` and adapts the `sed` pipe command to fit spacing. CC: Xu Wang CC: Michal Hrusecky Signed-off-by: Paul Spooren --- include/package-ipkg.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/package-ipkg.mk b/include/package-ipk

[PATCH 3/3] scripts: mkhash fail on hashing a folder

2020-07-16 Thread Paul Spooren
: d41d8cd98f00b204e9800998ecf8427e sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 Signed-off-by: Paul Spooren --- scripts/mkhash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mkhash.c b/scripts/mkhash.c index 96f92e42b5..4d1ff1c166 100644 --- a

[PATCH 1/3] scripts: mkhash show -n option in usage

2020-07-16 Thread Paul Spooren
The -n option prints the filename of hashed files next to the calculated checksum. Reflect that in the usage message. user@dawn:~/src/openwrt/openwrt$ ./a.out md5 -n .config eb06db36e7b6751cb18801945e46bf5d .config Signed-off-by: Paul Spooren --- scripts/mkhash.c | 5 - 1 file changed, 4

[PATCH 2/3] scripts: mkhash fix return code handling

2020-07-16 Thread Paul Spooren
If hashing a file fails mkhash shouldn't just silently fail. Now check after each call of `hash_file()` the return and exit early in case of errors. The return value which was previously ignored and would always return 0. Signed-off-by: Paul Spooren --- scripts/mkhash.c | 5 +++-- 1

[PATCH v2 1/2] scripts: mkhash fix return code handling

2020-07-17 Thread Paul Spooren
If hashing a file fails mkhash shouldn't just silently fail. Now check after each call of `hash_file()` the return and exit early in case of errors. The return value which was previously ignored and would always return 0. Signed-off-by: Paul Spooren --- scripts/mkhash.c | 7 +-- 1

[PATCH v2 2/2] scripts: mkhash fail on hashing a folder

2020-07-17 Thread Paul Spooren
: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 Signed-off-by: Paul Spooren --- scripts/mkhash.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/scripts/mkhash.c b/scripts/mkhash.c index ea3bd60ce1..13d50176c8 100644 --- a/scripts/mkhash.c +++ b/scripts/mkhash.c @@ -85,6 +85,7 @@ #include #include

Re: [PATCH 3/3] scripts: mkhash fail on hashing a folder

2020-07-17 Thread Paul Spooren
Hi, On 16.07.20 21:20, Bjørn Mork wrote: Paul Spooren writes: To avoid hashing of folders `fopen()` is called in `r+` mode which fails on folders, as their are not writeable. Regular files work as before. This prevents mkhash from working with read-only files. That's unexpected, and

[PATCH usign] usign: add VERIFYONLY option

2020-07-18 Thread Paul Spooren
conditions to reduce the code size. If VERIFYONLY is set, the usign binary size is reduced by 4kB. Only the functions `-V` for verification and `-F` for fingerprint printing are enabled. [0]: https://github.com/openwrt/openwrt/pull/2911 Signed-off-by: Paul Spooren --- main.c | 118

Re: [PATCH buildbot] phase1: add JSON merge step

2020-07-19 Thread Paul Spooren
On 30.06.20 13:28, Paul Spooren wrote: The refactored JSON info files require a final merge step which sums up all created JSON info files of a target into a single `profiles.json` files. This patch adds the extra step to run `make json_overview_image_info` just before calculating the checksums

[PATCH v2] build: store buildsystem revision in packages

2020-07-20 Thread Paul Spooren
ifest. Tested with buildsystem and SDK on ath79/generic. Signed-off-by: Paul Spooren --- v2: Improved the commit message include/package-ipkg.mk | 1 + package/Makefile| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/package-ipkg.mk b/include/package-ipkg.mk

[PATCH] tools: Add PKG_VERSION to flock

2020-07-22 Thread Paul Spooren
The stored source code of flock contains the version string of version 2.18, reflect that in the Makefile. Motivation is the tracking of changes in the buildsystem, which requires versioning of packages. Signed-off-by: Paul Spooren --- tools/flock/Makefile | 1 + 1 file changed, 1 insertion

[PATCH] tools: Add PKG_VERSION to sstrip

2020-07-22 Thread Paul Spooren
ommit/df4426a0f0ada861064d75c08cbebaac7c16b3ae#diff-d3ba694d91432a068d5d3b36abf8cd0f Signed-off-by: Paul Spooren --- tools/sstrip/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/sstrip/Makefile b/tools/sstrip/Makefile index 180bd1743e..99be063f4c 100644 --- a/tools/sstrip/Makefile +++ b/tools/sstrip/Makefile @@ -7,6

[PATCH] tools: add PKG_VERSION to patch-image

2020-07-22 Thread Paul Spooren
Based on no modifications for 5 years I'm assuming it's safe to call it a version 1.0.0, reflect that in the Makefile. Motivation is the tracking of changes in the buildsystem, which requires versioning of packages. Also update copyright. Signed-off-by: Paul Spooren --- tools/p

[PATCH] tools: add PKG_VERSION to firmware-utils

2020-07-22 Thread Paul Spooren
pdate copyright. Signed-off-by: Paul Spooren --- tools/firmware-utils/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/firmware-utils/Makefile b/tools/firmware-utils/Makefile index 3dd9ac5c2c..4ea3f773b9 100644 --- a/tools/firmware-utils/Makefile +++ b/tools/firmware-

Re: [PATCH] dropbear: allow disabling support for scp

2020-07-22 Thread Paul Spooren
Hi Rui, I imagine it could be helpful if you use sstrip[0] on the created binaries to give a clearer size comparison. [0]: https://github.com/BR903/ELFkickers/blob/master/sstrip/ Best, Paul On 22.07.20 03:31, Rui Salvaterra wrote: If not needed, disabling scp allows for a nice size reductio

Re: [PATCH] tools: Add PKG_VERSION to sstrip

2020-07-22 Thread Paul Spooren
On 22.07.20 12:49, m...@adrianschmutzler.de wrote: Hi Paul, -Original Message- From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] On Behalf Of Paul Spooren Sent: Donnerstag, 23. Juli 2020 00:15 To: openwrt-devel@lists.openwrt.org Cc: Paul Spooren Subject: [PATCH

[PATCH v2] tools: add PKG_RELEASE to patch-image

2020-07-22 Thread Paul Spooren
There is no versioning information in the patch-image code nor the Makefile. Consider it as first release by adding PKG_RELEASE. Motivation is the tracking of changes in the buildsystem, which requires versioning of packages. Also update copyright. Signed-off-by: Paul Spooren --- tools/patch

[PATCH v2] tools: add PKG_RELEASE to firmware-utils

2020-07-22 Thread Paul Spooren
There is no versioning information in the firmware-utils code nor the Makefile. Consider it as first release by adding PKG_RELEASE. Motivation is the tracking of changes in the buildsystem, which requires versioning of packages. Also update copyright. Signed-off-by: Paul Spooren --- tools

[PATCH v2] tools: add PKG_{VERSION,RELEASE} to sstrip

2020-07-22 Thread Paul Spooren
ommit/df4426a0f0ada861064d75c08cbebaac7c16b3ae#diff-d3ba694d91432a068d5d3b36abf8cd0f Signed-off-by: Paul Spooren --- v2: * Add release * Lowercase after ':' tools/sstrip/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/sstrip/Makefile b/tools/sstrip/Makefile index 180bd1743e..bab172a95a 100644 ---

[PATCH v2] tools: add PKG_{VERSION,RELEASE} to flock

2020-07-22 Thread Paul Spooren
The stored source code of flock contains the version string of version 2.18, reflect that in the Makefile. Motivation is the tracking of changes in the buildsystem, which requires versioning of packages. Signed-off-by: Paul Spooren --- v2: * Add release * Lowercase after ':' t

[PATCH] toolchain: treewide add PKG_RELEASE if local files

2020-07-23 Thread Paul Spooren
local files. Whenever a local file is changed the release must be increased. Also update the copyright of touched files to 2020. Signed-off-by: Paul Spooren --- toolchain/binutils/Makefile | 3 ++- toolchain/gcc/common.mk | 3 ++- toolchain/gdb/Makefile | 3 ++- toolchain/glibc/common.mk

[PATCH v2] dropbear: Enable Ed25519 for normal devices

2020-07-25 Thread Paul Spooren
cleaner than splitting `dropbear` into two packages like `dropbear` and `dropbear-ed25519`. Signed-off-by: Paul Spooren --- v2: * Add storage impact to commit message * Increase package release package/network/services/dropbear/Config.in | 2 +- package/network/services/dropbear/Makefile | 2 +- 2

Re: [PATCH 4/4] lantiq: disable default build for devices with 4M flash

2020-07-25 Thread Paul Spooren
On 25.07.20 08:29, Adrian Schmutzler wrote: It has been decided that the 19.07 release will be last one to include 4/32 devices. This disables default build for all devices with 4M flash on lantiq. Note that this will affect _all_ devices for amazonse ("ase") and xway_legacy subtarget. Isn't it

Re: [PATCH 4/4] lantiq: disable default build for devices with 4M flash

2020-07-25 Thread Paul Spooren
On 25.07.20 11:21, m...@adrianschmutzler.de wrote: -Original Message- From: Paul Spooren [mailto:m...@aparcar.org] Sent: Samstag, 25. Juli 2020 23:19 To: Adrian Schmutzler ; openwrt- de...@lists.openwrt.org Subject: Re: [PATCH 4/4] lantiq: disable default build for devices with 4M

Re: [PATCH 3/3] treewide: switch to HTTPS by default

2020-07-25 Thread Paul Spooren
,$(CONFIG_VERSION_DIST)) VERSION_DIST:=$(if $(VERSION_DIST),$(VERSION_DIST),OpenWrt) Exciting! Encrypted opkg downloads per default! Tested-by: Paul Spooren ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org

Port README to 21st century

2020-07-25 Thread Paul Spooren
Hi, I created a pull request on GitHub[0] with a reworked and extended README. Essentially it uses Markdown instead of plain text and embed the new logo and handy links to documentation and community resources. Adrian requested to announce the idea on the lists as it's basically the "busines

[PATCH 2/2] LICENSE: add SPDX identifiers

2020-07-29 Thread Paul Spooren
-2.0+` identifiers are deprecated[1] and are in contrast to the Linux Kernel not added. When adding such headers it should be the latest SPDX version. [0]: https://github.com/torvalds/linux/commit/255247c2770ada6edace04173b35307869b47d99 [1]: https://spdx.org/licenses/ Signed-off-by: Paul Spooren

[PATCH 1/2] LICENSE: use updated GNU copy

2020-07-29 Thread Paul Spooren
GPL-2.0 LICENSE file are availalbe[1]. [0]: https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt [1]: https://github.com/pombredanne/gpl-history Signed-off-by: Paul Spooren --- LICENSE | 41 - 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a

[PATCH 0/2] LICENSE: port to 21st century

2020-07-29 Thread Paul Spooren
Update LICENSE file to latest official and prettiest formatted version and add SPDX identifiers. The SPDX identifiers could later be used to check correct licensing of added code. Not run tested. Paul Spooren (2): LICENSE: use updated GNU copy LICENSE: add SPDX identifiers LICENSE | 56

Re: [PATCH 2/2] build: image: return sizes if check-size fails

2020-07-29 Thread Paul Spooren
Is there an easy way to test this? As in, how do I force the Kernel to be to big? On 29.07.20 09:00, Adrian Schmutzler wrote: Instead of just printing a warning that an image is too big, also print both actual size and limit in the string: WARNING: Image file somename.bin is too big: 2096101 >

Re: dm-verity support

2020-07-29 Thread Paul Spooren
Security sounds fun. Should I just compile the patches and flash on a device? Any concrete test cases to see if it did work? Would any router work or do I need some flagship x86 device? Best, Paul On 29.07.20 12:29, W. Michael Petullo wrote: I'm sorry, and although I fear a similar fate wil

[PATCH] tools: add libyaml

2020-07-29 Thread Paul Spooren
reduce human resources spent on reviewing DTS files. [0]: https://github.com/robherring/dt-schema Signed-off-by: Paul Spooren --- tools/Makefile | 2 +- tools/libyaml/Makefile | 34 ++ 2 files changed, 35 insertions(+), 1 deletion(-) create mode 100644

[PATCH v2] tools: add libyaml

2020-07-29 Thread Paul Spooren
reduce human resources spent on reviewing DTS files. [0]: https://github.com/robherring/dt-schema Signed-off-by: Paul Spooren --- v2: * Use autotools as upstream doesn't fully support CMake * Add MIT license tools/Makefile | 2 +- tools/libyaml/Makefile | 25 +++

[PATCH] tools: add yaml library

2020-07-30 Thread Paul Spooren
reduce human resources spent on reviewing DTS files. [0]: https://github.com/robherring/dt-schema Signed-off-by: Paul Spooren --- v3: * rename to yaml (was libyaml) * follow Makefile style from packages.git tools/Makefile | 2 +- tools/yaml/Makefile | 41

Re: [PATCH] tools: add yaml library

2020-07-30 Thread Paul Spooren
On 29.07.20 22:48, Moritz Warning wrote: On 7/30/20 10:26 AM, Paul Spooren wrote: libyaml is used to process YAML files, a popular human readable configuration format. If available during compilation, the device-tree-compiler (dtc) will enable YAML as export format. The exported YAML files

Re: [PATCH v2] dropbear: Enable Ed25519 for normal devices

2020-07-30 Thread Paul Spooren
On 26.07.20 05:20, Hauke Mehrtens wrote: On 7/25/20 11:06 PM, Paul Spooren wrote: The Ed25519 key pairs are much shorter than RSA pairs and are supported by default in OpenSSH. Looking at websites explaining how to create new SSH keys, many suggest using Ed25519 rather than RSA, however

[PATCH] scripts: add size_compare.sh

2020-07-30 Thread Paul Spooren
plan to integrate this script into the CI so we have a summary how sizes change over different architectures. Signed-off-by: Paul Spooren --- scripts/size_compare.sh | 117 1 file changed, 117 insertions(+) create mode 100755 scripts/size_compare.sh diff

Re: [PATCH 2/2] LICENSE: add SPDX identifiers

2020-08-02 Thread Paul Spooren
Hi Adrian, On 28.07.20 23:32, Paul Spooren wrote: SPDX license header follow a machine readable and versioned identifier format for licenses. The adoption to such system would simplify scanning of licenses within OpenWrt. Adopted from the Linux Kernel[0] store store SPDX identifiers at the top

Re: [PATCH] tools: add libyaml

2020-08-02 Thread Paul Spooren
On 30.07.20 03:17, Daniel Golle wrote: On Thu, Jul 30, 2020 at 02:55:33PM +0200, Petr Štetiar wrote: Paul Spooren [2020-07-29 12:45:25]: Once available this can be used within a CI to reduce human resources spent on reviewing DTS files. That's indeed cool, but I quite fail to see why

[PATCH v2] scripts: Add Buildbot dump-target-info.pl script

2020-08-03 Thread Paul Spooren
m the buildbot repository and maintained only here. Rename `dumpinfo.pl` to `dump-target-info.pl` to improve verbosity of filename. [0]: https://git.openwrt.org/?p=buildbot.git;a=blob;f=scripts/dumpinfo.pl;h=aa97f8d60379076a41b968402e9337cea824ece5;hb=HEAD Signed-off-by: Paul Spooren --- scripts

[PATCH v3] scripts: Add Buildbot dump-target-info.pl script

2020-08-03 Thread Paul Spooren
ld be removed from the buildbot repository and maintained only here. Rename `dumpinfo.pl` to `dump-target-info.pl` to improve verbosity of filename. [0]: https://git.openwrt.org/?p=buildbot.git;a=blob;f=scripts/dumpinfo.pl;h=aa97f8d60379076a41b968402e9337cea824ece5;hb=HEAD Signed-off-by: Paul Sp

Re: [PATCH] busybox: fix fwmark and add fwmask support to ip rule

2020-08-03 Thread Paul Spooren
Hi Rui, please increase the PKG_RELEASE whenever you change anything inside a package. On 03.08.20 12:54, Rui Salvaterra wrote: BusyBox ip (rule) applet supports fwmark for policy routing (albeit through the old and deprecated RTA_PROTOINFO message attribute), but fwmask is completely unsuppo

Re: [PATCH v2] busybox: fix fwmark and add fwmask support to ip rule

2020-08-04 Thread Paul Spooren
Hi Rui, On 03.08.20 22:14, Rui Salvaterra wrote: BusyBox ip (rule) applet supports fwmark for policy routing (albeit through the old and deprecated RTA_PROTOINFO message attribute), but fwmask is completely unsupported. For this reason, mwan3 depends on ip(-tiny), which compiles to over 280 kiB

Re: [PATCH] tools/firmware-utils: use UTC for image timestamps

2020-08-06 Thread Paul Spooren
Please increase the PKG_RELEASE on code changes. On 06.08.20 09:10, Sander Vanheule wrote: By using localtime() to determine the timestamp that goes into factory images, the resulting image depends on the timezone of the build system. Use gmtime() instead, which results in more reproducible imag

[PATCH 2/4] build: ipkg-build use fakeroot with PKG_FILE_MODES

2020-08-07 Thread Paul Spooren
input. Lastly the option `-c` is removed as it's unused within the script. Signed-off-by: Paul Spooren --- include/package-ipkg.mk | 6 +- scripts/ipkg-build | 41 + 2 files changed, 26 insertions(+), 21 deletions(-) diff --git a/in

[PATCH 1/4] tools: add fakeroot

2020-08-07 Thread Paul Spooren
' original work is available at http://lists.infradead.org/pipermail/openwrt-devel/2019-November/025976.html. Signed-off-by: W. Michael Petullo [add rules.mk FAKEROOT variable] Signed-off-by: Paul Spooren --- rules.mk| 1 + tools/Makefile | 2 +- tools/fakeroot/Makefile

[PATCH 4/4] build: remove INSTALL_SUID

2020-08-07 Thread Paul Spooren
Instead of INSTALL_SUID the PKG_FILE_MODES variable should be used Signed-off-by: Paul Spooren --- rules.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/rules.mk b/rules.mk index 45d96d6be4..d535e57266 100644 --- a/rules.mk +++ b/rules.mk @@ -281,7 +281,6 @@ PATCH:=patch PYTHON:=python

[PATCH 3/4] busybox: Use PKG_FILE_MODES for SUID

2020-08-07 Thread Paul Spooren
Instead of using INSTALL_SUID use the more flexible PKG_FILE_MODES variable withn the Makefile to set the SUID bit. Signed-off-by: Paul Spooren --- package/utils/busybox/Makefile | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/package/utils/busybox/Makefile b

[RFC] Policy for PKG_RELEASE bumps

2020-08-07 Thread Paul Spooren
Hi team, currently exist two different ideas on when to raise the PKG_RELEASE of a package. * When functional things change     For example, a OpenWrt specific patch is added * When anything inside the packages ipk file changes     Includes patch and so called "cosmetic" changes outside the

[PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Paul Spooren
Fix shellcheck SC2230 > which is non-standard. Use builtin 'command -v' instead. Once applied to everything concerning OpenWrt we can disable the busybox feature `which` and save 3.8kB. Signed-off-by: Paul Spooren --- include/rootfs.mk| 6 ++

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Paul Spooren
On 07.08.20 14:18, Rosen Penev wrote: On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: Fix shellcheck SC2230 which is non-standard. Use builtin 'command -v' instead. Once applied to everything concerning OpenWrt we can disable the busybox feature `which` and save 3.8kB.

Re: OpenWrt's 'procd' now speaks containers

2020-08-07 Thread Paul Spooren
On 07.08.20 09:47, Daniel Golle wrote: Dear community, in the past couple of months I've been working on implementing the Open Container Initiative Runtime Specification [1] in procd by extending the already existing support for slim containers ('ujail'). As a result, there is now a new CLI tool

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Paul Spooren
On 07.08.20 16:48, Rosen Penev wrote: On Fri, Aug 7, 2020 at 5:42 PM Paul Spooren wrote: On 07.08.20 14:18, Rosen Penev wrote: On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: Fix shellcheck SC2230 which is non-standard. Use builtin 'command -v' instead. Once applied to

Re: [PATCH 1/4] tools: add fakeroot

2020-08-09 Thread Paul Spooren
On 07.08.20 20:18, Felix Fietkau wrote: On 2020-08-07 23:12, Paul Spooren wrote: From: Thomas Petazzoni SELinux support requires setting the appropriate SELinux security context to files and directories, which needs to happen at build time in order to support read-only root filesystem

Re: [PATCH 4/4] build: remove INSTALL_SUID

2020-08-09 Thread Paul Spooren
On 07.08.20 11:13, Paul Spooren wrote: Instead of INSTALL_SUID the PKG_FILE_MODES variable should be used Signed-off-by: Paul Spooren --- rules.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/rules.mk b/rules.mk index 45d96d6be4..d535e57266 100644 --- a/rules.mk +++ b/rules.mk

[PATCH] busybox: Disable `which` command

2020-08-09 Thread Paul Spooren
ld be disabled for busybox, freeing roughly 4kB. Signed-off-by: Paul Spooren --- This patch depends on the following three patches: openwrt.git: https://patchwork.ozlabs.org/project/openwrt/list/?series=194732 packages.git: https://github.com/openwrt/packages/pull/13059 luci.git: https://github.com/op

[PATCH procd] initd/init: add minimal SELinux policy loading support

2020-08-09 Thread Paul Spooren
runs with the SELinux policy in place and enforced. Signed-off-by: Thomas Petazzoni [fix spelling of OpenWrt] Signed-off-by: Paul Spooren --- This is part of a bigger PR on GitHub[1], however this patch should be added directly to `procd` rather than as a patch in openwrt.git. As some core devs

[PATCH v2] treewide: replace `which` with `command -v`

2020-08-09 Thread Paul Spooren
penWrt we can disable the busybox feature `which` and save 3.8kB. Acked-by: Stijn Tintel Signed-off-by: Paul Spooren --- include/rootfs.mk| 6 +++--- package/base-files/files/lib/upgrade/stage2 | 2 +- .../kernel/broadcom-wl/files/lib/wifi/broadc

Re: [RFC] Policy for PKG_RELEASE bumps

2020-08-09 Thread Paul Spooren
12:32 -1000, Paul Spooren wrote: Hi team, currently exist two different ideas on when to raise the PKG_RELEASE of a package. * When functional things change For example, a OpenWrt specific patch is added * When anything inside the packages ipk file changes Includes patch and so c

[PATCH] build: SDK/IB reproducible and faster compression

2020-08-13 Thread Paul Spooren
Both IB and SDK now use the same logic for packing. This commit add reproducible multithread compression to the SDK and corrects the file mtime for both. Previously all files where just copied over from the build system, generating random mtimes. Signed-off-by: Paul Spooren --- This speeds up

[PATCH 1/4] build: Fix Shellcheck for get_source_date_epoch.sh

2020-08-13 Thread Paul Spooren
If a `cd` to `TOPDIR` fails the script should quit. Also unify `try_mtime` function by storing it in a variable. Signed-off-by: Paul Spooren --- scripts/get_source_date_epoch.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/get_source_date_epoch.sh b/scripts

[PATCH 3/4] build: store granular timestamps in packages

2020-08-13 Thread Paul Spooren
SOURCE_DATE_EPOCH is used or as last resort the current time. The redundant checks for `.git/` and `.svn/` are removed. Signed-off-by: Paul Spooren --- include/package-ipkg.mk | 1 + scripts/ipkg-build | 12 +++- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/include/package

[PATCH 2/4] build: get_source_date_epoch allow external repos

2020-08-13 Thread Paul Spooren
allows granular but still reproducible timestamps. As packages might be distributed over multiple repositories the check for `.git/` becomes unfeasible. Instead tell `git` and `hg` to change their working directories and automatically traverse the repo folder. Signed-off-by: Paul Spooren --- scripts

[PATCH 4/4] build: store SourceDateEpoch in manifest

2020-08-13 Thread Paul Spooren
The usage of granular `SOURCE_DATE_EPOCH` for packages is an incrementing integer which could be useful for downstream tooling, therefore add it to the packages manifest. Signed-off-by: Paul Spooren --- include/package-ipkg.mk | 1 + package/Makefile| 2 +- 2 files changed, 2 insertions

[PATCH 0/4] Granular timestamps in packages

2020-08-13 Thread Paul Spooren
erate different binaries (this seems to be the lesser problem atm) Part 2 will be tackled in some later patches. [1]: http://logs.nslu2-linux.org/livelogs/openwrt-devel/openwrt-devel.20200807.txt Paul Spooren (4): build: Fix Shellcheck for get_source_date_epoch.sh build: get_source_d

[PATCH v2 2/4] build: get_source_date_epoch allow external repos

2020-08-14 Thread Paul Spooren
allows granular but still reproducible timestamps. As packages might be distributed over multiple repositories the check for `.git/` becomes unfeasible. Instead tell `git` and `hg` to change their working directories and automatically traverse the repo folder. Signed-off-by: Paul Spooren --- scripts

[PATCH v2 0/4] Granular timestamps in packages

2020-08-14 Thread Paul Spooren
logs.nslu2-linux.org/livelogs/openwrt-devel/openwrt-devel.20200807.txt Paul Spooren (4): build: Fix Shellcheck for get_source_date_epoch.sh build: get_source_date_epoch allow external repos build: store granular timestamps in packages build: store SourceDateEpoch in manifest include/package-i

[PATCH v2 3/4] build: store granular timestamps in packages

2020-08-14 Thread Paul Spooren
SOURCE_DATE_EPOCH is used or as last resort the current time. The redundant checks for `.git/` and `.svn/` are removed. Signed-off-by: Paul Spooren --- include/package-ipkg.mk | 1 + scripts/ipkg-build | 12 +++- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/include/package

[PATCH v2 1/4] build: Fix Shellcheck for get_source_date_epoch.sh

2020-08-14 Thread Paul Spooren
If a `cd` to `TOPDIR` fails the script should quit. Also unify `try_mtime` function by storing it in a variable. Signed-off-by: Paul Spooren --- scripts/get_source_date_epoch.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/get_source_date_epoch.sh b/scripts

[PATCH v2 4/4] build: store SourceDateEpoch in manifest

2020-08-14 Thread Paul Spooren
The usage of granular `SOURCE_DATE_EPOCH` for packages is an incrementing integer which could be useful for downstream tooling, therefore add it to the packages manifest. Signed-off-by: Paul Spooren --- include/package-ipkg.mk | 1 + package/Makefile| 2 +- 2 files changed, 2 insertions

Re: [PATCH] mbedtls: Update to version 2.16.7

2020-08-15 Thread Paul Spooren
Duplicate of this one? https://patchwork.ozlabs.org/project/openwrt/patch/20200725121928.10850-1-mkro...@gmail.com/ -- Aug 15, 2020 7:49:33 AM Hauke Mehrtens : This fixes multiple minor security problems. Signed-off-by: Hauke Mehrtens --- package/libs/mbedtls/Makefile |  8 +

<    1   2   3   4   5   6   7   >